mirror of
https://github.com/BaaRai/ARTEX.git
synced 2026-11-18 14:10:54 +08:00
feat(traffic): replay an edited request through the recording proxy
Traffic.Replay sends an edited request (method, URL, headers, body) through the local proxy, which records the exchange like any other, and returns the response bounded to 2 MiB. POST /api/traffic/replay exposes it to operators only (no agent tool). Invalid input is rejected with ErrReplayInvalid; hop-by-hop headers are dropped, redirects are not followed, and a Host that differs from the URL is refused because the proxy routes by Host.
This commit is contained in:
@@ -2,6 +2,7 @@ package server
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/base64"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"fmt"
|
||||
@@ -826,6 +827,7 @@ func (s *Server) Handler() http.Handler {
|
||||
mux.HandleFunc("GET /api/traffic/stream", s.getTrafficStream)
|
||||
mux.HandleFunc("GET /api/traffic/blob", s.getTrafficBlob)
|
||||
mux.HandleFunc("POST /api/traffic/ingest", s.ingestTraffic)
|
||||
mux.HandleFunc("POST /api/traffic/replay", s.replayTraffic)
|
||||
mux.HandleFunc("GET /api/commands", s.pgListCommands)
|
||||
mux.HandleFunc("GET /api/commands/stats", s.pgToolStats) // aggregate call counts per tool
|
||||
mux.HandleFunc("GET /api/llm/records", s.pgListLLMRecords)
|
||||
@@ -3485,6 +3487,66 @@ func (s *Server) getTrafficStream(w http.ResponseWriter, r *http.Request) {
|
||||
writeJSON(w, 200, map[string]any{"items": msgs, "total": total})
|
||||
}
|
||||
|
||||
// maxReplayRequestBytes bounds the replay request body (JSON, with the payload
|
||||
// possibly base64-encoded); traffic.Replay applies its own body limit after
|
||||
// decoding.
|
||||
const maxReplayRequestBytes = 16 << 20
|
||||
|
||||
// replayTraffic sends an edited request through the recording proxy and returns
|
||||
// the response; the proxy records the exchange like any other.
|
||||
//
|
||||
// Operator-only: this is the equivalent of pointing a browser at the proxy, and
|
||||
// no agent tool exposes it. If an agent tool is ever added, it must go through
|
||||
// the target gate and the task's scope like every other outbound request.
|
||||
func (s *Server) replayTraffic(w http.ResponseWriter, r *http.Request) {
|
||||
tr := s.m.Traffic()
|
||||
if tr == nil {
|
||||
writeErr(w, 503, "traffic disabled")
|
||||
return
|
||||
}
|
||||
r.Body = http.MaxBytesReader(w, r.Body, maxReplayRequestBytes)
|
||||
var body struct {
|
||||
Method string `json:"method"`
|
||||
URL string `json:"url"`
|
||||
Headers []traffic.ReplayHeader `json:"headers"`
|
||||
Body string `json:"body"`
|
||||
BodyBase64 bool `json:"body_base64"`
|
||||
}
|
||||
if err := json.NewDecoder(r.Body).Decode(&body); err != nil {
|
||||
var tooLarge *http.MaxBytesError
|
||||
if errors.As(err, &tooLarge) {
|
||||
writeErr(w, 413, "replay request too large")
|
||||
return
|
||||
}
|
||||
writeErr(w, 400, "bad json: "+err.Error())
|
||||
return
|
||||
}
|
||||
payload := []byte(body.Body)
|
||||
if body.BodyBase64 {
|
||||
decoded, err := base64.StdEncoding.DecodeString(body.Body)
|
||||
if err != nil {
|
||||
writeErr(w, 400, "body is not valid base64: "+err.Error())
|
||||
return
|
||||
}
|
||||
payload = decoded
|
||||
}
|
||||
ctx, cancel := context.WithTimeout(r.Context(), 60*time.Second)
|
||||
defer cancel()
|
||||
res, err := tr.Replay(ctx, traffic.ReplayRequest{Method: body.Method, URL: body.URL, Headers: body.Headers, Body: payload})
|
||||
switch {
|
||||
case errors.Is(err, traffic.ErrReplayInvalid):
|
||||
writeErr(w, 400, err.Error())
|
||||
return
|
||||
case errors.Is(err, context.DeadlineExceeded):
|
||||
writeErr(w, 504, "replay timed out")
|
||||
return
|
||||
case err != nil:
|
||||
writeErr(w, 502, err.Error())
|
||||
return
|
||||
}
|
||||
writeJSON(w, 200, map[string]any{"status": res.Status, "raw": res.Raw, "duration_ms": res.DurationMS, "truncated": res.Truncated})
|
||||
}
|
||||
|
||||
// getTrafficBlob streams one oversized body by its sha256. Bodies past the inline
|
||||
// threshold are not carried by the exchange endpoint — it returns a preview plus
|
||||
// an "@blob sha256:<hash>" pointer — so this is how the UI fetches them whole.
|
||||
|
||||
@@ -0,0 +1,154 @@
|
||||
package server
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/base64"
|
||||
"encoding/json"
|
||||
"io"
|
||||
"net"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/Autumn-27/artex/traffic"
|
||||
)
|
||||
|
||||
// replayServer wires a Server like ingestServer. With traffic off,
|
||||
// s.m.Traffic() is nil. With trafficOn but not live, the store is open and the
|
||||
// proxy is not listening. With live, NewManager opens the store and starts the
|
||||
// recording proxy on a free loopback port, as in production; the proxy has no
|
||||
// exported stop, so it keeps listening until the test binary exits.
|
||||
func replayServer(t *testing.T, trafficOn, live bool) (*Server, func(body string) *httptest.ResponseRecorder) {
|
||||
t.Helper()
|
||||
skipWithoutDSN(t)
|
||||
proxyAddr := ""
|
||||
if live {
|
||||
ln, err := net.Listen("tcp", "127.0.0.1:0")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
proxyAddr = ln.Addr().String()
|
||||
ln.Close()
|
||||
}
|
||||
m, err := NewManager(t.TempDir(), proxyAddr)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
t.Cleanup(func() { m.Close() })
|
||||
if live {
|
||||
if m.traffic == nil {
|
||||
t.Fatal("NewManager did not open the traffic store")
|
||||
}
|
||||
deadline := time.Now().Add(5 * time.Second)
|
||||
for {
|
||||
c, err := net.Dial("tcp", proxyAddr)
|
||||
if err == nil {
|
||||
c.Close()
|
||||
break
|
||||
}
|
||||
if time.Now().After(deadline) {
|
||||
t.Fatalf("proxy did not listen on %s: %v", proxyAddr, err)
|
||||
}
|
||||
time.Sleep(10 * time.Millisecond)
|
||||
}
|
||||
} else if trafficOn {
|
||||
if m.traffic, err = traffic.Open(filepath.Join(m.dir, "traffic"), ":0"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
ctx, cancel := context.WithCancel(context.Background())
|
||||
cancel()
|
||||
s := New(ctx, m, t.TempDir(), t.TempDir(), t.TempDir())
|
||||
s.archiveWG.Wait()
|
||||
<-s.side.done
|
||||
token, err := signJWT(s.jwtKey)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
return s, func(body string) *httptest.ResponseRecorder {
|
||||
r := httptest.NewRequest("POST", "/api/traffic/replay", strings.NewReader(body))
|
||||
r.Header.Set("Authorization", "Bearer "+token)
|
||||
r.Header.Set("Content-Type", "application/json")
|
||||
w := httptest.NewRecorder()
|
||||
s.Handler().ServeHTTP(w, r)
|
||||
return w
|
||||
}
|
||||
}
|
||||
|
||||
func TestTrafficReplayRouteTrafficOff(t *testing.T) {
|
||||
_, replay := replayServer(t, false, false)
|
||||
if w := replay(`{"method":"GET","url":"http://example.com/"}`); w.Code != 503 {
|
||||
t.Fatalf("traffic off = %d %s, want 503", w.Code, w.Body)
|
||||
}
|
||||
}
|
||||
|
||||
func TestTrafficReplayRouteValidation(t *testing.T) {
|
||||
_, replay := replayServer(t, true, false)
|
||||
for name, c := range map[string]struct {
|
||||
body string
|
||||
want int
|
||||
}{
|
||||
"bad json": {`{"method":`, 400},
|
||||
"CONNECT": {`{"method":"CONNECT","url":"http://example.com/"}`, 400},
|
||||
"ftp url": {`{"method":"GET","url":"ftp://example.com/x"}`, 400},
|
||||
"no host": {`{"method":"GET","url":"http:///x"}`, 400},
|
||||
"bad base64": {`{"method":"POST","url":"http://example.com/","body":"%%%","body_base64":true}`, 400},
|
||||
"header CRLF": {`{"method":"GET","url":"http://example.com/","headers":[{"name":"X-A","value":"a\r\nb"}]}`, 400},
|
||||
"too large": {`{"method":"POST","url":"http://example.com/","body":"` + strings.Repeat("a", 17<<20) + `"}`, 413},
|
||||
"proxy down": {`{"method":"GET","url":"http://127.0.0.1:1/"}`, 502},
|
||||
"body too big": {`{"method":"POST","url":"http://example.com/","body":"` + base64.StdEncoding.EncodeToString(make([]byte, 9<<20)) + `","body_base64":true}`, 400},
|
||||
} {
|
||||
if w := replay(c.body); w.Code != c.want {
|
||||
t.Errorf("%s: %d %s, want %d", name, w.Code, strings.TrimSpace(w.Body.String()), c.want)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestTrafficReplayRouteEndToEnd(t *testing.T) {
|
||||
s, replay := replayServer(t, true, true)
|
||||
target := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
b, _ := io.ReadAll(r.Body)
|
||||
w.Header().Set("X-Seen", r.Method+" "+r.Header.Get("X-Custom"))
|
||||
_, _ = w.Write(append([]byte("got:"), b...))
|
||||
}))
|
||||
t.Cleanup(target.Close)
|
||||
url := target.URL + "/replayed?x=1"
|
||||
req, _ := json.Marshal(map[string]any{
|
||||
"method": "PUT", "url": url,
|
||||
"headers": []map[string]string{{"name": "X-Custom", "value": "edited"}},
|
||||
"body": base64.StdEncoding.EncodeToString([]byte("payload")), "body_base64": true,
|
||||
})
|
||||
w := replay(string(req))
|
||||
if w.Code != 200 {
|
||||
t.Fatalf("replay = %d %s", w.Code, w.Body)
|
||||
}
|
||||
var res struct {
|
||||
Status int `json:"status"`
|
||||
Raw string `json:"raw"`
|
||||
DurationMS int64 `json:"duration_ms"`
|
||||
Truncated bool `json:"truncated"`
|
||||
}
|
||||
if err := json.Unmarshal(w.Body.Bytes(), &res); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if res.Status != 200 || res.Truncated || !strings.Contains(res.Raw, "X-Seen: PUT edited") || !strings.HasSuffix(res.Raw, "got:payload") {
|
||||
t.Fatalf("result %+v", res)
|
||||
}
|
||||
deadline := time.Now().Add(5 * time.Second)
|
||||
for {
|
||||
var n int
|
||||
if err := s.m.Traffic().DB().QueryRow(`SELECT COUNT(*) FROM exchanges WHERE method='PUT' AND url=?`, url).Scan(&n); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if n == 1 {
|
||||
break
|
||||
}
|
||||
if time.Now().After(deadline) {
|
||||
t.Fatalf("replayed exchange not recorded (%d rows)", n)
|
||||
}
|
||||
time.Sleep(20 * time.Millisecond)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user