Commit Graph
4 Commits
Author SHA1 Message Date
dach-a fa33d4dac0 test: assert compression by size, not by looking for a word
The plaintext-substring guard encoded one encoder's output shape: it only held
while a small input compressed to fewer bytes than it started with, and Go
1.27 stores instead. Comparing sizes states the same invariant without
assuming how flate picks between stored and compressed blocks: a stored block
is larger than its input by construction, so "output is under half the input"
is true for any working encoder on a repetitive body and false for a body that
was never compressed.

Checked against the old 60-byte fixture on go1.27.4: it fails with "fixture is
not compressed: 60 bytes in, 85 bytes out", so the guard still catches the
case it was written for.
2026-11-17 03:49:25 +00:00
dach-a 25816c7fd6 test: make the gzip fixture compressible on every toolchain
TestDecodeEvidenceBodyGzipQuoteFound built its body from the 60-byte
decodeHTML constant and guarded with "the stream must not contain admin".
That assumes the encoder always deflates, and Go 1.27's flate does not: for
this input it emits a stored block, the stream is 85 bytes, and the raw bytes
are the plaintext the guard rejects. The test then fails on the encoder's
choice rather than on the decode it is meant to cover.

Repeat the body so it has something to compress, and assert the decoded
output equals it, so the guard measures the round trip instead of one
encoder's block selection. The quote and the body's content are unchanged,
and the sibling truncated/deflate tests already use repeated input.
2026-11-17 03:31:36 +00:00
BaaRai 05df40eecb test(verification): lock that an empty bound body never satisfies a quote
A response captured with Content-Encoding: gzip and no body (HEAD, 304) is
decoded to an empty body without error. Pin that behaviour, and pin that an
empty body, compressed or not, matches no non-empty quote through
readBoundResponse and quoteInBodies, so it can never lead to a verified
finding.
2026-11-10 12:52:56 +01:00
BaaRai f4f0df128a fix(verification): decode gzip/deflate response bodies before the S1 quote check
Compressed HTML responses are stored as captured, so the S1 receipt check saw them as binary and returned not_assessed. readBoundResponse now undoes the Content-Encoding declared in the snapshot's response head before the text/binary detection and the quote search.

decodeEvidenceBody handles identity and a single layer of gzip or deflate (zlib-wrapped or bare), bounded by verificationReadCap on the decoded side. Any other coding, stacked codings, or a stream that fails to decode is an error, which the caller reports as not_assessed (evidence body unreadable). The stored evidence bytes are unchanged.
2026-11-10 12:33:40 +01:00