mirror of
https://github.com/BaaRai/ARTEX.git
synced 2026-11-13 11:40:53 +08:00
BaaRai
07d272727d
Descriptions written through the API were interpolated raw into the SKILL.md frontmatter, so a value containing a colon+space made the whole frontmatter unparseable: every field silently stayed empty, the skill loaded under its directory name, and a skill-gated MCP server was silently skipped. The same applied to updates through the meta rewrite, and the shipped scopesentry skill had a malformed name line all along. - yamlScalar: plain-safe tokens stay bare, everything else single-quoted - fsCreateSkill/fsUpdateSkillMeta emit safe values and re-verify the written file with the real skill parser (name + mcps must survive), rejecting the write otherwise - warnBrokenSkills at startup logs skills whose name fell back to the directory (the signature of broken frontmatter) - fix skills/scopesentry/SKILL.md name line Closes #39
73 lines
2.4 KiB
Go
73 lines
2.4 KiB
Go
package server
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Autumn-27/norma/skill"
|
|
)
|
|
|
|
func TestYamlScalar(t *testing.T) {
|
|
cases := []struct{ in, want string }{
|
|
{"rea", "rea"},
|
|
{"api-recon", "api-recon"},
|
|
{"plain value with spaces", "plain value with spaces"},
|
|
{"target: embedded", "'target: embedded'"},
|
|
{"it's quoted", "'it''s quoted'"},
|
|
{"ends #now", "'ends #now'"},
|
|
{"comma, separated", "'comma, separated'"},
|
|
{" leading", "' leading'"},
|
|
{"", "''"},
|
|
}
|
|
for _, c := range cases {
|
|
if got := yamlScalar(c.in); got != c.want {
|
|
t.Errorf("yamlScalar(%q) = %q, want %q", c.in, got, c.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
// A SKILL.md written the way fsCreateSkill now writes it (yamlScalar values)
|
|
// must round-trip through the real parser with name and mcps intact, even with
|
|
// a colon+space and quotes in the description. The pre-fix format (raw
|
|
// interpolation) fails exactly there and falls back to the directory name.
|
|
func TestSkillFrontmatterRoundTrip(t *testing.T) {
|
|
dir := t.TempDir()
|
|
skillDir := filepath.Join(dir, "colon-skill")
|
|
if err := os.MkdirAll(skillDir, 0o755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
desc := "Analyze target: embedded secrets, it's binary"
|
|
content := fmt.Sprintf("---\nname: %s\ndescription: %s\nmcps: %s\n---\nbody instructions\n",
|
|
yamlScalar("colon-skill"), yamlScalar(desc), yamlScalar("rea"))
|
|
|
|
skillMD := filepath.Join(skillDir, "SKILL.md")
|
|
if err := os.WriteFile(skillMD, []byte(content), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := verifySkillFile(skillDir, "colon-skill", []string{"rea"}); err != nil {
|
|
t.Fatalf("safe format failed verification: %v", err)
|
|
}
|
|
reg, err := skill.LoadDir(skillDir)
|
|
if err != nil || len(reg.List()) != 1 {
|
|
t.Fatalf("LoadDir: %v (%d skills)", err, len(reg.List()))
|
|
}
|
|
s := reg.List()[0]
|
|
if s.Name != "colon-skill" || s.Description != desc || len(s.MCPs) != 1 || s.MCPs[0] != "rea" {
|
|
t.Fatalf("round-trip mismatch: name=%q desc=%q mcps=%v", s.Name, s.Description, s.MCPs)
|
|
}
|
|
|
|
// the old, unsafe emission: unquoted colon+space breaks the whole frontmatter
|
|
unsafe := fmt.Sprintf("---\nname: %s\ndescription: %s\nmcps: rea\n---\nbody\n", "colon-skill", desc)
|
|
if err := os.WriteFile(skillMD, []byte(unsafe), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := verifySkillFile(skillDir, "colon-skill", []string{"rea"}); err == nil {
|
|
t.Fatal("unsafe format unexpectedly verified")
|
|
} else if !strings.Contains(err.Error(), "fell back") {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
}
|