mirror of
https://github.com/BaaRai/ARTEX.git
synced 2026-11-18 14:10:54 +08:00
The task report and the findings export asserted every finding with no qualification: nothing said how far exploitation actually reached (PoE level), whether the claim was machine-verified (verification status and note), whether counterevidence was recorded, or whether any traffic was bound. The web UI badges all of it (VERIFICATION_META, the detail page), so the report — the artifact a client actually reads — was the last surface still asserting bare claims. Render it from one place: - report/quality.go (new): two constructors and two pure renderers, no I/O, no DB handle, so the block is unit-tested without a database. - Both surfaces call the same helpers, which is the point: the task report and the per-finding export cannot drift apart the way duplicated formatting does. - Missing is explicit: a finding node with no standalone row prints "not assessed (no finding record)" instead of an invented zero — the honest gap the existing coverage work (#207) also insists on. - Labels match the shipped UI wording (Verification, Confidence rationale, Counterevidence) and states are humanised ("Not assessed", "False positive"), with an unrecognised value printed verbatim so a new state cannot silently vanish from a report. - Bound-traffic count appears once per document: as a Proof bullet in the task report (it has no traffic section), and in the export only when nothing is bound — otherwise the traffic section already states it. - The detailed report is capped at 8 KiB in the task report only, rune-safe, with the cap derived into the truncation message; the export is the canonical per-finding document and is never silently shortened. - The export keeps its document structure: the single-finding document gets "## Detailed Report" (a section like its siblings), the multi-finding summary gets a bold label. Read paths only: no change to the write side of poe_level or verification_status, no schema change (all five columns already exist), no API/DTO change (the widened FindingMeta stays internal to the report path, and the findings list keeps selecting only what it renders). One extra task-scoped query on GET /api/report, because findings bodies stay off the list path. docs/vulnerability-traffic-evidence.md §Export describes the new Markdown.
109 lines
4.0 KiB
Go
109 lines
4.0 KiB
Go
package db
|
|
|
|
import "testing"
|
|
|
|
// The report path reads proof strength, the two attestations, both evidence
|
|
// versions and the reporter-written body in one query; the task findings list keeps
|
|
// its own lean meta query. Both are exercised here because the 13-column Scan in
|
|
// FindingQualityByNodeID has no other coverage: a column added, dropped or reordered
|
|
// silently shifts fields into each other, and nothing else would notice.
|
|
func TestFindingQualityByNodeID(t *testing.T) {
|
|
d, err := Open(testDSN(t))
|
|
if err != nil {
|
|
t.Skipf("postgres unavailable (%v) — skipping", err)
|
|
}
|
|
defer d.Close()
|
|
tk, err := d.CreateTask("finding quality lookup", "goal", nil, 0, 0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer d.DeleteTask(tk.ID)
|
|
|
|
es := d.Exploration(tk.ExplorationID)
|
|
rec, err := es.RecordFinding(t.Context(), RecordFindingInput{
|
|
TaskID: tk.ID, VulnClass: "IDOR", Severity: "high", Summary: "with proof", Worker: "test",
|
|
Counterevidence: "guessing a UUID returned 404",
|
|
ConfidenceRationale: "two accounts returned each other's order",
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := d.SetFindingVerification(rec.FindingID, VerificationVerified, 3, "reproduced twice on staging"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
const body = "## Overview\n\nThe 200 carries the victim's order body.\n\n## Fix\n\nbind the owner server-side."
|
|
if _, err := d.SetFindingReportVersionByNodeID(t.Context(), rec.NodeID, body, nil); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// Binding or re-binding evidence is what bumps evidence_version; moving it after
|
|
// the report was written is exactly what makes that report stale.
|
|
if _, err := d.Exec(`UPDATE findings SET evidence_version=evidence_version+1 WHERE id=$1`, rec.FindingID); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// 1) The report-only query carries the whole proof-strength footprint.
|
|
got, err := d.FindingQualityByNodeID(tk.ID)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
q, ok := got[rec.NodeID]
|
|
if !ok {
|
|
t.Fatalf("node %d missing from the quality lookup (%d rows)", rec.NodeID, len(got))
|
|
}
|
|
if q.ID != rec.FindingID {
|
|
t.Errorf("record id = %d, want %d", q.ID, rec.FindingID)
|
|
}
|
|
if q.Status != FindingPending {
|
|
t.Errorf("status = %q, want %q", q.Status, FindingPending)
|
|
}
|
|
if q.PoeLevel != 3 || q.VerificationStatus != VerificationVerified {
|
|
t.Errorf("poe/verification = %d/%q, want 3/%q", q.PoeLevel, q.VerificationStatus, VerificationVerified)
|
|
}
|
|
if q.VerificationNote != "reproduced twice on staging" {
|
|
t.Errorf("verification note = %q", q.VerificationNote)
|
|
}
|
|
if q.Counterevidence != "guessing a UUID returned 404" {
|
|
t.Errorf("counterevidence = %q", q.Counterevidence)
|
|
}
|
|
if q.ConfidenceRationale != "two accounts returned each other's order" {
|
|
t.Errorf("confidence rationale = %q", q.ConfidenceRationale)
|
|
}
|
|
if q.Report != body {
|
|
t.Errorf("report body = %q, want %q", q.Report, body)
|
|
}
|
|
if q.EvidenceVersion != 1 || q.ReportEvidenceVersion != 0 {
|
|
t.Errorf("versions = %d/%d, want 1/0", q.EvidenceVersion, q.ReportEvidenceVersion)
|
|
}
|
|
if !q.ReportStale() {
|
|
t.Error("a report written before the evidence moved must be stale")
|
|
}
|
|
if q.TrafficCount != 0 {
|
|
t.Errorf("traffic count = %d, want 0", q.TrafficCount)
|
|
}
|
|
|
|
// 2) The findings list keeps its lean query, and it must still resolve the row.
|
|
meta, err := d.FindingMetaByNodeID(tk.ID)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
m, ok := meta[rec.NodeID]
|
|
if !ok {
|
|
t.Fatalf("node %d missing from the meta lookup", rec.NodeID)
|
|
}
|
|
if m.ID != rec.FindingID || m.Status != FindingPending || m.TrafficCount != 0 {
|
|
t.Errorf("meta = {id:%d status:%q traffic:%d}, want {id:%d status:%q traffic:0}", m.ID, m.Status, m.TrafficCount, rec.FindingID, FindingPending)
|
|
}
|
|
|
|
// 3) Rows are keyed by task: another task sees its own (empty) set, not this one.
|
|
other, err := d.CreateTask("finding quality lookup (other)", "goal", nil, 0, 0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer d.DeleteTask(other.ID)
|
|
if rows, err := d.FindingQualityByNodeID(other.ID); err != nil {
|
|
t.Fatal(err)
|
|
} else if len(rows) != 0 {
|
|
t.Errorf("other task sees %d rows, want 0", len(rows))
|
|
}
|
|
}
|