mirror of
https://github.com/BaaRai/ARTEX.git
synced 2026-11-22 08:00:54 +08:00
Two root file operations took a path the agent controls. - ingest_bbot opened the path it was given with os.Open in the server process, which is root in the image: any root-readable file could be named, and the result counts told its line structure. The tool now opens the file through the file tools' confinement (openWorkRoot on the run's working directory under the data directory, then os.Root): an absolute path elsewhere, "..", a symlink, a hard-linked file and a run directory reached by a symlink are refused. It fails closed without a data directory or a working directory. The worker passes its data directory to the ToolSet (SetWorkBase); the tool reads the ToolContext for the working directory, like ingest_scan_output. - execPython wrote the script of a custom tool as root to <run dir>/.tools and then chowned it. The executor can write the run directory, so it could turn .tools into a symlink and have root create and chown a file elsewhere. With the privilege drop on, the script now goes to <data>/exec-scripts, created by PrepareExecPrivilege as root:<exec gid> 0750, outside tasks/ and sessions/: the executor reads the 0640 script and cannot create, rename or replace an entry. An enabled drop without that directory is an error, not a fallback to the run directory. Without the drop nothing changes. PrepareExecPrivilege takes the privilege by pointer to record ExecPrivilege.ScriptDir. Tests: TestOpenBbotOutputConfined and TestIngestBbotToolConfined (no Postgres), TestExecPythonNeedsScriptDirWhenDropping, and the root-only TestExecPythonScriptDirAsRoot (.tools planted as a symlink to a root-only directory). TestIngestBbotScopeSplit now places its file in a run directory. SECURITY.md: the two paths leave the residual list; the command-output spill stays.