mirror of
https://github.com/BaaRai/ARTEX.git
synced 2026-11-15 04:30:55 +08:00
BaaRai
07cc87c1a3
Seal the four credential columns with AES-256-GCM (random nonce per value,
AAD "<table>.<column>"): llm_profiles.api_key and task_credentials.password
store "enc:v1:<base64(nonce||ciphertext)>"; mcp_servers.env and
notification_channels.config store {"__artex_enc":"enc:v1:..."} over the
canonical JSON. The db layer encrypts on write and decrypts on read, so agent
tools (LLM provider, MCP, notifier, test credentials) get plaintext
server-side. Decryption failure is an error, never a plaintext fallback.
Key: ARTEX_SECRET_KEY (32 bytes, base64 or hex) or keys/secret.key next to
jwt.key, generated with crypto/rand at first start (0600). Startup refuses
when encrypted values exist and no key is available, and when the key does
not decrypt them. An idempotent backfill under the schema advisory lock
encrypts legacy plaintext rows and logs only a count.
API: MCP env is masked on read and masked placeholders on write keep the
stored value; task credential passwords are masked server-side and a masked
password on write is refused. ARTEX_SECRET_KEY is scrubbed from the process
environment with the other startup secrets.
67 lines
1.9 KiB
Go
67 lines
1.9 KiB
Go
package server
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"os/exec"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// A child process spawned after startup must not see the startup secrets, while
|
|
// other variables still pass through.
|
|
func TestScrubSecretEnvHidesSecretsFromChildren(t *testing.T) {
|
|
sh, err := exec.LookPath("sh")
|
|
if err != nil {
|
|
t.Skip("no sh in PATH")
|
|
}
|
|
for _, k := range secretEnv {
|
|
t.Setenv(k, "leak-"+k)
|
|
}
|
|
t.Setenv("ARTEX_SCRUB_KEEP", "kept")
|
|
|
|
ScrubSecretEnv()
|
|
|
|
out, err := exec.Command(sh, "-c", "env").Output()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
env := "\n" + string(out)
|
|
for _, k := range secretEnv {
|
|
if strings.Contains(env, "\n"+k+"=") {
|
|
t.Errorf("%s still reaches child processes", k)
|
|
}
|
|
}
|
|
if !strings.Contains(env, "\nARTEX_SCRUB_KEEP=kept\n") {
|
|
t.Errorf("non-secret variable did not reach the child process")
|
|
}
|
|
}
|
|
|
|
// New must apply the options it receives. An earlier version accepted
|
|
// ...Option and never called them, so the binary kept the secrets in the
|
|
// environment while the unit test above still passed.
|
|
func TestNewAppliesSecretScrubOption(t *testing.T) {
|
|
// t.Setenv restores both after the test: the scrub unsets them for the rest
|
|
// of this process, and later tests still need the DSN.
|
|
if dsn := os.Getenv("ARTEX_PG_DSN"); dsn != "" {
|
|
t.Setenv("ARTEX_PG_DSN", dsn)
|
|
}
|
|
t.Setenv("ARTEX_SECRET_KEY", os.Getenv("ARTEX_SECRET_KEY"))
|
|
t.Setenv("ANTHROPIC_API_KEY", "scrub-probe")
|
|
t.Setenv("OPENAI_API_KEY", "scrub-probe")
|
|
|
|
m, err := NewManager(t.TempDir(), "")
|
|
if err != nil {
|
|
t.Skipf("no manager: %v", err)
|
|
}
|
|
t.Cleanup(func() { m.Close() })
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
cancel()
|
|
_ = New(ctx, m, t.TempDir(), t.TempDir(), t.TempDir(), WithSecretScrub())
|
|
|
|
if os.Getenv("ANTHROPIC_API_KEY") != "" || os.Getenv("OPENAI_API_KEY") != "" {
|
|
t.Fatal("New did not apply WithSecretScrub: the secrets are still in the environment")
|
|
}
|
|
}
|