mirror of
https://github.com/BaaRai/ARTEX.git
synced 2026-11-18 14:10:54 +08:00
Handlers that decode JSON directly were still unbounded, and a body past the cap was reported as a bad request.
69 lines
2.1 KiB
Go
69 lines
2.1 KiB
Go
package server
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"strings"
|
|
"unicode/utf8"
|
|
|
|
"github.com/Autumn-27/artex/db"
|
|
)
|
|
|
|
const (
|
|
maxTaskNameRunes = 200
|
|
maxTaskMetadataRequestSize = 16 << 10
|
|
)
|
|
|
|
// updateTaskMetadata changes list-only task metadata. It intentionally does not
|
|
// touch lifecycle state, scheduling, or the task's immutable description/goal.
|
|
func (s *Server) updateTaskMetadata(w http.ResponseWriter, r *http.Request) {
|
|
taskID := r.PathValue("id")
|
|
if _, ok := s.m.Task(taskID); !ok {
|
|
writeErr(w, http.StatusNotFound, "task not found")
|
|
return
|
|
}
|
|
r.Body = http.MaxBytesReader(w, r.Body, maxTaskMetadataRequestSize)
|
|
var request struct {
|
|
Name *string `json:"name"`
|
|
Pinned *bool `json:"pinned"`
|
|
PlanQuietMode *bool `json:"plan_quiet_mode"`
|
|
TargetGate *bool `json:"target_gate"`
|
|
}
|
|
if err := decode(w, r, &request); err != nil {
|
|
var tooLarge *http.MaxBytesError
|
|
if errors.As(err, &tooLarge) {
|
|
writeErr(w, http.StatusRequestEntityTooLarge, "request body too large")
|
|
} else {
|
|
writeErr(w, http.StatusBadRequest, err.Error())
|
|
}
|
|
return
|
|
}
|
|
if request.Name == nil && request.Pinned == nil && request.PlanQuietMode == nil && request.TargetGate == nil {
|
|
writeErr(w, http.StatusBadRequest, "at least one of name, pinned, plan_quiet_mode or target_gate must be provided")
|
|
return
|
|
}
|
|
if request.Name != nil {
|
|
name := strings.TrimSpace(*request.Name)
|
|
if name == "" {
|
|
writeErr(w, http.StatusBadRequest, "task name cannot be empty")
|
|
return
|
|
}
|
|
if utf8.RuneCountInString(name) > maxTaskNameRunes {
|
|
writeErr(w, http.StatusBadRequest, fmt.Sprintf("task name must be at most %d characters", maxTaskNameRunes))
|
|
return
|
|
}
|
|
request.Name = &name
|
|
}
|
|
task, err := s.m.UpdateTaskMetadata(taskID, db.TaskPatch{Name: request.Name, Pinned: request.Pinned, PlanQuietMode: request.PlanQuietMode, TargetGate: request.TargetGate})
|
|
if err != nil {
|
|
writeErr(w, http.StatusInternalServerError, err.Error())
|
|
return
|
|
}
|
|
if task == nil {
|
|
writeErr(w, http.StatusNotFound, "task not found")
|
|
return
|
|
}
|
|
writeJSON(w, http.StatusOK, taskDTO(task, s.resolvedTaskStatus(task)))
|
|
}
|