Files
ARTEX/server/bulk_finding_status_test.go
T

69 lines
2.1 KiB
Go

package server
import (
"net/http"
"net/http/httptest"
"strings"
"testing"
)
// The bulk endpoint validates the whole request before touching the database, so
// a malformed body, an unknown status and an empty id list are client errors.
func TestBulkFindingStatusValidation(t *testing.T) {
s := &Server{m: &Manager{}}
cases := []struct {
name string
body string
want int
}{
{"bad json", `{`, http.StatusBadRequest},
{"unknown status", `{"ids":[1],"status":"nope"}`, http.StatusBadRequest},
{"empty ids", `{"ids":[],"status":"confirmed"}`, http.StatusBadRequest},
{"non-positive ids", `{"ids":[0,-3],"status":"confirmed"}`, http.StatusBadRequest},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
rec := httptest.NewRecorder()
req := httptest.NewRequest(http.MethodPost, "/api/exploration/findings/bulk-status", strings.NewReader(tc.body))
s.bulkPatchFindingStatus(rec, req)
if rec.Code != tc.want {
t.Fatalf("status %d, want %d: %s", rec.Code, tc.want, rec.Body.String())
}
})
}
}
func TestNormalizeFindingIDs(t *testing.T) {
got := normalizeFindingIDs([]int64{0, -1, 2, 2, 3, 4}, 2)
if len(got) != 2 || got[0] != 2 || got[1] != 3 {
t.Fatalf("got %v, want [2 3]", got)
}
if got := normalizeFindingIDs(nil, 500); len(got) != 0 {
t.Fatalf("empty input: %v", got)
}
}
func TestBulkFindingReportStateValidation(t *testing.T) {
s := &Server{m: &Manager{}}
cases := []struct {
name string
body string
want int
}{
{"bad json", `{`, http.StatusBadRequest},
{"unknown state", `{"ids":[1],"report_state":"confirmed"}`, http.StatusBadRequest},
{"empty ids", `{"ids":[],"report_state":"submitted"}`, http.StatusBadRequest},
{"non-positive ids", `{"ids":[0,-3],"report_state":"submitted"}`, http.StatusBadRequest},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
rec := httptest.NewRecorder()
req := httptest.NewRequest(http.MethodPost, "/api/exploration/findings/bulk-report-state", strings.NewReader(tc.body))
s.bulkPatchFindingReportState(rec, req)
if rec.Code != tc.want {
t.Fatalf("status %d, want %d: %s", rec.Code, tc.want, rec.Body.String())
}
})
}
}