mirror of
https://github.com/BaaRai/ARTEX.git
synced 2026-11-19 14:40:53 +08:00
getTask computed the list metrics of every task to read one; it now calls TaskListMetrics(expID), which runs the same laterals as TaskListMetricsAll with a WHERE on the exploration. listTasks keeps the global query. The latest_activity lateral ordered by its EXTRACT(EPOCH) output alias, so PostgreSQL read and sorted every activity row of each task; it now orders by activity.created_at and idx_act_latest serves the LIMIT 1. Both queries share one SQL constant.
153 lines
5.3 KiB
Go
153 lines
5.3 KiB
Go
package server
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strconv"
|
|
"testing"
|
|
)
|
|
|
|
func TestTaskDetailReturnsListMetrics(t *testing.T) {
|
|
m, err := NewManager(t.TempDir(), "")
|
|
if err != nil {
|
|
t.Skipf("postgres unavailable (%v) — skipping", err)
|
|
}
|
|
defer m.Close()
|
|
task, err := m.CreateTask("detail metrics", "goal", nil, 0, 0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
taskID, _ := strconv.ParseInt(task.ID, 10, 64)
|
|
defer func() { _ = m.pg.DeleteTask(taskID) }()
|
|
|
|
// Seed the aggregates the metrics query reads: one result-activity with
|
|
// tokens, one non-result row that must be excluded, and two goals (1 met).
|
|
if _, err := m.pg.Exec(`
|
|
INSERT INTO activity(
|
|
exploration_id, kind, input_tokens, output_tokens,
|
|
cache_read_tokens, cache_write_tokens, created_at
|
|
) VALUES ($1,'result',11,7,3,2,now()), ($1,'tool_result',999,999,999,999,now())`,
|
|
task.ExpID); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := m.pg.Exec(`
|
|
INSERT INTO exploration_nodes(exploration_id, kind, payload, state)
|
|
VALUES ($1,'goal','{}','met'), ($1,'goal','{}','open')`, task.ExpID); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// A second task, so the detail must pick its own row and the list must keep
|
|
// serving every task.
|
|
other, err := m.CreateTask("detail metrics other", "goal", nil, 0, 0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
otherID, _ := strconv.ParseInt(other.ID, 10, 64)
|
|
defer func() { _, _ = m.pg.DeleteTaskCascade(otherID, false, true) }()
|
|
defer func() { _, _ = m.pg.Exec(`DELETE FROM findings WHERE task_id=$1`, taskID) }()
|
|
if _, err := m.pg.Exec(`
|
|
INSERT INTO findings(task_id, severity) VALUES ($1,'critical'), ($1,'high'), ($1,'high'), ($1,'low'), ($2,'medium')`,
|
|
taskID, otherID); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
s := New(ctx, m, t.TempDir(), t.TempDir(), t.TempDir())
|
|
defer stopTestServer(t, s, cancel)
|
|
token, err := signJWT(s.jwtKey)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// After New: restoring the task resets running intents to open.
|
|
if _, err := m.pg.Exec(`
|
|
INSERT INTO exploration_nodes(exploration_id, kind, payload, state)
|
|
VALUES ($1,'intent','{}','running'), ($1,'intent','{}','done')`, task.ExpID); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
type findingCounts struct {
|
|
Critical int `json:"critical"`
|
|
High int `json:"high"`
|
|
Medium int `json:"medium"`
|
|
Low int `json:"low"`
|
|
}
|
|
var probe struct {
|
|
Tokens struct {
|
|
InputTokens int `json:"input_tokens"`
|
|
OutputTokens int `json:"output_tokens"`
|
|
CacheReadTokens int `json:"cache_read_tokens"`
|
|
CacheWriteTokens int `json:"cache_write_tokens"`
|
|
} `json:"tokens"`
|
|
GoalsMet int `json:"goals_met"`
|
|
GoalsTotal int `json:"goals_total"`
|
|
InFlight int `json:"in_flight"`
|
|
Findings findingCounts `json:"findings"`
|
|
}
|
|
req := httptest.NewRequest(http.MethodGet, "/api/tasks/"+task.ID, nil)
|
|
req.Header.Set("Authorization", "Bearer "+token)
|
|
rec := httptest.NewRecorder()
|
|
s.Handler().ServeHTTP(rec, req)
|
|
if rec.Code != http.StatusOK {
|
|
t.Fatalf("detail status=%d body=%s", rec.Code, rec.Body.String())
|
|
}
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &probe); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if probe.Tokens.InputTokens != 11 || probe.Tokens.OutputTokens != 7 ||
|
|
probe.Tokens.CacheReadTokens != 3 || probe.Tokens.CacheWriteTokens != 2 {
|
|
t.Fatalf("detail tokens not filled from metrics: %+v", probe.Tokens)
|
|
}
|
|
if probe.GoalsMet != 1 || probe.GoalsTotal != 2 {
|
|
t.Fatalf("detail goal progress not filled from metrics: %d/%d", probe.GoalsMet, probe.GoalsTotal)
|
|
}
|
|
if probe.InFlight != 1 || probe.Findings != (findingCounts{Critical: 1, High: 2, Low: 1}) {
|
|
t.Fatalf("detail in-flight/findings not filled from this task's metrics: %d %+v", probe.InFlight, probe.Findings)
|
|
}
|
|
|
|
// The list endpoint must report the same numbers for the same task.
|
|
listReq := httptest.NewRequest(http.MethodGet, "/api/tasks", nil)
|
|
listReq.Header.Set("Authorization", "Bearer "+token)
|
|
listRec := httptest.NewRecorder()
|
|
s.Handler().ServeHTTP(listRec, listReq)
|
|
if listRec.Code != http.StatusOK {
|
|
t.Fatalf("list status=%d body=%s", listRec.Code, listRec.Body.String())
|
|
}
|
|
var listed struct {
|
|
Tasks []struct {
|
|
ID string `json:"id"`
|
|
Tokens struct {
|
|
InputTokens int `json:"input_tokens"`
|
|
OutputTokens int `json:"output_tokens"`
|
|
} `json:"tokens"`
|
|
GoalsMet int `json:"goals_met"`
|
|
GoalsTotal int `json:"goals_total"`
|
|
InFlight int `json:"in_flight"`
|
|
Findings findingCounts `json:"findings"`
|
|
} `json:"tasks"`
|
|
}
|
|
if err := json.Unmarshal(listRec.Body.Bytes(), &listed); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
found, foundOther := false, false
|
|
for _, lt := range listed.Tasks {
|
|
if lt.ID == other.ID {
|
|
foundOther = lt.Findings == (findingCounts{Medium: 1})
|
|
}
|
|
if lt.ID != task.ID {
|
|
continue
|
|
}
|
|
found = true
|
|
if lt.Tokens.InputTokens != probe.Tokens.InputTokens ||
|
|
lt.Tokens.OutputTokens != probe.Tokens.OutputTokens ||
|
|
lt.GoalsMet != probe.GoalsMet || lt.GoalsTotal != probe.GoalsTotal ||
|
|
lt.InFlight != probe.InFlight || lt.Findings != probe.Findings {
|
|
t.Fatalf("list and detail metrics disagree: list=%+v detail=%+v", lt, probe)
|
|
}
|
|
}
|
|
if !found || !foundOther {
|
|
t.Fatalf("list misses a task or its metrics: task %s found=%v, task %s with its findings=%v", task.ID, found, other.ID, foundOther)
|
|
}
|
|
}
|