From c4413dabb5f06dd5871b16db916740dffce8b3bc Mon Sep 17 00:00:00 2001 From: DrSmoothl <1787882683@qq.com> Date: Sat, 30 May 2026 17:29:17 +0800 Subject: [PATCH] fix(proto): correct 0x8FC body/targetName field tags (set_group_card) set_group_card always failed with `OIDB error 1007 on 0x8fc_3` (issue #70). The 0x8FC request protos put the body wrapper at tag 2 and the member card name at tag 2, but QQ-NT expects body at tag 3 and targetName at tag 8, so the server found neither and rejected the request. Cross-checked byte-for-byte against two working references: - Lagrange.Core OidbSvcTrpcTcp0x8FC: Body=ProtoMember(3), TargetName=8 - NapCat Oidb.0x8FC_2: body=ProtoField(3), targetName=8 Fixes OidbRenameMember (0x8FC_3 set card) and the same latent bug in OidbSpecialTitle (0x8FC_2 set special title), whose body was also at tag 2. Send-only protos (empty deserialize); existing tests assert the command name, not field tags, so they're unaffected. --- packages/proto-defs/src/oidb-actions/base.ts | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/packages/proto-defs/src/oidb-actions/base.ts b/packages/proto-defs/src/oidb-actions/base.ts index dc414159..650e40dc 100644 --- a/packages/proto-defs/src/oidb-actions/base.ts +++ b/packages/proto-defs/src/oidb-actions/base.ts @@ -90,13 +90,19 @@ export interface OidbSetAdmin { uid?: pb<2, string>; isAdmin?: pb<3, bool>; } +// 0x8FC_3 (set member card) shares its wire shape with 0x8FC_2 (special +// title): the body wrapper sits at tag 3, and the card name at tag 8 — +// NOT tags 2/2. Sending body@2 / targetName@2 makes the server miss both +// and reject with `OIDB error 1007`. Cross-checked byte-for-byte against: +// dev/Lagrange.Core/…/Request/OidbSvcTrpcTcp0x8FC.cs (Body=3, TargetName=8) +// dev/napcatQQInside/…/proto/oidb/Oidb.0x8FC_2.ts (body=3, targetName=8) export interface OidbRenameMemberBody { targetUid?: pb<1, string>; - targetName?: pb<2, string>; + targetName?: pb<8, string>; } export interface OidbRenameMember { groupUin?: pb<1, uint_32>; - body?: pb<2, OidbRenameMemberBody>; + body?: pb<3, OidbRenameMemberBody>; } export interface OidbRenameGroupBody { targetName?: pb<1, string>; @@ -112,7 +118,8 @@ export interface OidbSpecialTitleBody { } export interface OidbSpecialTitle { groupUin?: pb<1, uint_32>; - body?: pb<2, OidbSpecialTitleBody>; + // Same family as 0x8FC_3 above — body wrapper is tag 3, not 2. + body?: pb<3, OidbSpecialTitleBody>; } // 0x7E5_104 (FriendLike) request body. Field numbers 11/12/13 (NOT // 1/2/3) — the server reads `targetUid` from tag 11 and rejects with