注入的竞态窗口里,native hook 偶发上报 13 位垃圾 UIN(时间戳型,读到 QQ 尚未落定
的内存)。TS 层防御缺失,导致两个连锁问题:
1) 幽灵账号:isRealUin 只查「纯数字且 ≥5 位」、无上限,垃圾值通过后建会话并把
config/onebot_<垃圾>.json 落盘 → OneBot 节点配置里出现随机幽灵账号(跨重启残留)。
2) 进程崩溃:logger 彩色路径 ' '.repeat(SLOT - tagLen),UIN tag(含方括号)超宽 →
负数 → RangeError: Invalid count value → uncaughtException。
跨平台(Win DLL / Linux .so 同逻辑)+「更新 QQ 后消失」都印证是 native 读到那块内存
的偶发垃圾;根修在 SnowLumaNative,此处补齐 TS 防御:
- 抽出唯一的 @snowluma/common/uin::isRealUin = /^\d{5,10}$/(真实 QQ ≤ uint32 →
10 位)。删除 bridge/core 两处重复副本(重复正是这次漏加上限的温床)。等价旧逻辑,
仅新增拒 11+ 位。
- logger.ts 加 Math.max(0, …),日志永不崩进程(独立健壮化)。
- 收紧 WebUI UIN_REGEX /^\d{5,12}$/ → /^\d{5,10}$/ 保持一致。
- 启动时 cleanupInvalidPerUinConfigs() 清掉已落盘的幽灵 onebot_<uin>.json(只删
UIN 不合法的,绝不碰合法账号/全局配置)。
测试:common +8(uin 6 / logger 2)、onebot +3(cleanup)。typecheck 12 包干净;
common 58 / onebot 519 / core 471 / bridge 73 全绿。对抗性 Agent 逐输入核验等价性、
三层 gate 堵死幽灵入口、cleanup 安全时序,无回归。
46 lines
1.9 KiB
TypeScript
46 lines
1.9 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
|
|
|
|
// The file transport writes to disk; stub it so the test has no side effects.
|
|
vi.mock('../src/log-file-transport', () => ({
|
|
getFileTransport: () => ({ write: () => {} }),
|
|
}));
|
|
|
|
import { createLogger } from '../src/logger';
|
|
|
|
// Regression for issue #162: a hook-reported garbage UIN (13-digit, timestamp
|
|
// shaped) produced a `[…]` tag wider than the fixed UIN slot, and the colored
|
|
// render path did `' '.repeat(slot - tagLen)` → RangeError: Invalid count value
|
|
// → uncaughtException. The padding must clamp at zero.
|
|
describe('logger UIN slot padding', () => {
|
|
let prevTTY: boolean | undefined;
|
|
let prevNoColor: string | undefined;
|
|
|
|
beforeEach(() => {
|
|
prevTTY = process.stdout.isTTY;
|
|
prevNoColor = process.env.NO_COLOR;
|
|
// Force the colored render path (the only one that used .repeat()).
|
|
(process.stdout as unknown as { isTTY: boolean }).isTTY = true;
|
|
delete process.env.NO_COLOR;
|
|
vi.spyOn(process.stdout, 'write').mockReturnValue(true);
|
|
vi.spyOn(process.stderr, 'write').mockReturnValue(true);
|
|
});
|
|
|
|
afterEach(() => {
|
|
(process.stdout as unknown as { isTTY: boolean | undefined }).isTTY = prevTTY;
|
|
if (prevNoColor === undefined) delete process.env.NO_COLOR;
|
|
else process.env.NO_COLOR = prevNoColor;
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
it('does not throw when the UIN tag exceeds the slot width', () => {
|
|
const log = createLogger('Test').child({ uin: '1701414379536' }); // 13-digit → [..] = 15 chars
|
|
expect(() => log.info('phantom account line')).not.toThrow();
|
|
expect(() => log.error('phantom error line')).not.toThrow();
|
|
});
|
|
|
|
it('still renders a normal-width UIN and a no-UIN logger', () => {
|
|
expect(() => createLogger('Test').child({ uin: '10001' }).info('ok')).not.toThrow();
|
|
expect(() => createLogger('Test').info('no uin')).not.toThrow();
|
|
});
|
|
});
|