mirror of
https://github.com/BaaRai/ARTEX.git
synced 2026-11-13 19:50:54 +08:00
Compare commits
12
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
bbc4f6269a | ||
|
|
e38e48e80e | ||
|
|
f6b29b835b | ||
|
|
08830365c4 | ||
|
|
1c3a5f4ffa | ||
|
|
1e616c9286 | ||
|
|
46e81f5f67 | ||
|
|
c5e12541bd | ||
|
|
743e6b0d15 | ||
|
|
ca15063db7 | ||
|
|
f07e84ac7a | ||
|
|
a77851db7d |
+1
-4
@@ -128,13 +128,10 @@ func (c *ChatAgent) Chat(ctx context.Context, agentKey, sessionID, message strin
|
||||
Provider: c.prov,
|
||||
SystemPrompt: system,
|
||||
DynamicBoundary: boundary,
|
||||
Tools: tools,
|
||||
Tools: withWebFetch(ctx, tools, c.proxyAddr, c.proxyCACert), // WebFetch: routed through the recording proxy for tracing; loads the proxy CA to verify MITM-resigned HTTPS certificates; every redirect hop is gated
|
||||
DeferredTools: def.Deferred,
|
||||
UnlockSet: def.Unlock,
|
||||
PermissionMode: permission.ModeBypass,
|
||||
EnableWebFetch: true, // routed through the recording proxy for tracing; loads the proxy CA to verify MITM-resigned HTTPS certificates
|
||||
WebFetchProxy: c.proxyAddr,
|
||||
WebFetchCACert: c.proxyCACert,
|
||||
// Web search (optional). ddgs needs no key; brave-free needs BraveKey; tavily needs TavilyKey.
|
||||
// WebSearchProxy is a dedicated egress proxy (http/https/socks5), unrelated to the traffic-recording MITM proxy; empty = direct.
|
||||
EnableWebSearch: ws.Enabled,
|
||||
|
||||
+1
-4
@@ -144,13 +144,10 @@ func (m *MainAgent) Chat(ctx context.Context, taskID int64, mainSeg int, as *db.
|
||||
Provider: m.prov,
|
||||
SystemPrompt: system,
|
||||
DynamicBoundary: boundary,
|
||||
Tools: tools,
|
||||
Tools: withWebFetch(ctx, tools, m.proxyAddr, m.proxyCACert), // WebFetch: routed through the recording proxy for tracing; loads the proxy CA to verify MITM-resigned HTTPS certificates; every redirect hop is gated
|
||||
DeferredTools: def.Deferred,
|
||||
UnlockSet: def.Unlock,
|
||||
PermissionMode: permission.ModeBypass,
|
||||
EnableWebFetch: true, // routed through the recording proxy for tracing; loads the proxy CA to verify MITM-resigned HTTPS certificates
|
||||
WebFetchProxy: m.proxyAddr,
|
||||
WebFetchCACert: m.proxyCACert,
|
||||
// Web search (optional). ddgs needs no key; brave-free needs BraveKey; tavily needs TavilyKey.
|
||||
// WebSearchProxy is a dedicated egress proxy (http/https/socks5), unrelated to the traffic-recording MITM proxy; empty = direct.
|
||||
EnableWebSearch: m.webSearch.Enabled,
|
||||
|
||||
+1
-4
@@ -426,13 +426,10 @@ func (p *Planner) Plan(ctx context.Context, taskID int64, as *db.AssetStore, ts
|
||||
Provider: p.prov,
|
||||
SystemPrompt: system,
|
||||
DynamicBoundary: boundary,
|
||||
Tools: tools,
|
||||
Tools: withWebFetch(ctx, tools, p.proxyAddr, p.proxyCACert), // WebFetch: route through the recording proxy for traceability; load the proxy CA to verify MITM-re-signed HTTPS certs; every redirect hop is gated
|
||||
DeferredTools: def.Deferred,
|
||||
UnlockSet: def.Unlock,
|
||||
PermissionMode: permission.ModeBypass,
|
||||
EnableWebFetch: true, // route through the recording proxy for traceability; load the proxy CA to verify MITM-re-signed HTTPS certs
|
||||
WebFetchProxy: p.proxyAddr,
|
||||
WebFetchCACert: p.proxyCACert,
|
||||
// Web search (optional). ddgs needs no key; brave-free needs BraveKey; tavily needs TavilyKey.
|
||||
// WebSearchProxy is a dedicated egress proxy (http/https/socks5), unrelated to the traffic-recording MITM proxy; empty = direct.
|
||||
EnableWebSearch: p.webSearch.Enabled,
|
||||
|
||||
@@ -0,0 +1,27 @@
|
||||
package agent
|
||||
|
||||
import (
|
||||
"context"
|
||||
|
||||
"github.com/Autumn-27/artex/intercept"
|
||||
actool "github.com/Autumn-27/norma/tool"
|
||||
)
|
||||
|
||||
// withWebFetch returns tools plus the WebFetch tool of an agent session. Every
|
||||
// agent kind builds WebFetch here, one tool per run, so that its configuration
|
||||
// can depend on the run: every redirect hop goes through the target gate
|
||||
// (intercept.RedirectCheck), and every connection through the pinned dialer
|
||||
// (intercept.PinnedDialer), on the client that uses proxy and on the direct
|
||||
// retry client alike. ctx is the context of the run: when it carries a target
|
||||
// scope the dialer never connects without one, and when that scope's gate is
|
||||
// on the direct retry is turned off for the run, since it would leave without
|
||||
// the proxy. The tool is added after the session's own tools, where agentcore
|
||||
// adds it, so the tool list keeps its order. caCert is the recording proxy's
|
||||
// CA, trusted to verify the HTTPS it re-signs. tools is not modified.
|
||||
func withWebFetch(ctx context.Context, tools []actool.CoreTool, proxy, caCert string) []actool.CoreTool {
|
||||
scope, scoped := intercept.TargetScopeFromContext(ctx)
|
||||
gated := scoped && scope.Enabled != nil && scope.Enabled()
|
||||
webFetch := actool.NewWebFetch(actool.WebFetchConfig{Proxy: proxy, CACert: caCert, CheckRedirect: intercept.RedirectCheck("WebFetch"),
|
||||
DialContext: intercept.PinnedDialer("WebFetch", scoped), DisableDirectRetry: gated})
|
||||
return append(tools[:len(tools):len(tools)], webFetch)
|
||||
}
|
||||
@@ -0,0 +1,262 @@
|
||||
package agent
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"fmt"
|
||||
"net"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"net/netip"
|
||||
"slices"
|
||||
"strings"
|
||||
"sync"
|
||||
"sync/atomic"
|
||||
"testing"
|
||||
|
||||
"github.com/Autumn-27/artex/db"
|
||||
"github.com/Autumn-27/artex/guard"
|
||||
"github.com/Autumn-27/artex/intercept"
|
||||
actool "github.com/Autumn-27/norma/tool"
|
||||
)
|
||||
|
||||
// Step 2.1: the WebFetch tool of every agent kind connects through the pinned
|
||||
// dialer. In a gated scope it reaches a target only at an address a pin holds.
|
||||
|
||||
// tableResolver answers from a table and counts the lookups.
|
||||
type tableResolver struct {
|
||||
mu sync.Mutex
|
||||
answers map[string][]string
|
||||
n int
|
||||
}
|
||||
|
||||
func newTableResolver() *tableResolver { return &tableResolver{answers: map[string][]string{}} }
|
||||
|
||||
func (r *tableResolver) Name() string { return "table" }
|
||||
|
||||
func (r *tableResolver) LookupIPs(_ context.Context, host string) ([]netip.Addr, error) {
|
||||
r.mu.Lock()
|
||||
defer r.mu.Unlock()
|
||||
r.n++
|
||||
var out []netip.Addr
|
||||
for _, ip := range r.answers[host] {
|
||||
out = append(out, netip.MustParseAddr(ip))
|
||||
}
|
||||
if len(out) == 0 {
|
||||
return nil, fmt.Errorf("no answer for %s", host)
|
||||
}
|
||||
return out, nil
|
||||
}
|
||||
|
||||
func (r *tableResolver) set(host string, ips ...string) {
|
||||
r.mu.Lock()
|
||||
r.answers[host] = ips
|
||||
r.mu.Unlock()
|
||||
}
|
||||
|
||||
func (r *tableResolver) lookups() int {
|
||||
r.mu.Lock()
|
||||
defer r.mu.Unlock()
|
||||
return r.n
|
||||
}
|
||||
|
||||
// testDialer is the base dialer of the gate in these tests: it records every
|
||||
// address, connects the routed TEST-NET addresses to local listeners and a
|
||||
// loopback address to itself, and refuses the rest.
|
||||
type testDialer struct {
|
||||
mu sync.Mutex
|
||||
routes map[string]string
|
||||
dialed []string
|
||||
}
|
||||
|
||||
func newTestDialer() *testDialer { return &testDialer{routes: map[string]string{}} }
|
||||
|
||||
func (d *testDialer) route(addr, to string) {
|
||||
d.mu.Lock()
|
||||
d.routes[addr] = to
|
||||
d.mu.Unlock()
|
||||
}
|
||||
|
||||
func (d *testDialer) dial(ctx context.Context, network, addr string) (net.Conn, error) {
|
||||
d.mu.Lock()
|
||||
d.dialed = append(d.dialed, addr)
|
||||
to, ok := d.routes[addr]
|
||||
d.mu.Unlock()
|
||||
if !ok && strings.HasPrefix(addr, "127.0.0.1:") {
|
||||
to, ok = addr, true
|
||||
}
|
||||
if !ok {
|
||||
return nil, &net.OpError{Op: "dial", Net: network, Err: errors.New("no route in the test dialer")}
|
||||
}
|
||||
return (&net.Dialer{}).DialContext(ctx, network, to)
|
||||
}
|
||||
|
||||
func (d *testDialer) calls() []string {
|
||||
d.mu.Lock()
|
||||
defer d.mu.Unlock()
|
||||
return slices.Clone(d.dialed)
|
||||
}
|
||||
|
||||
// dialFixture is a gated scope on task taskID whose gate resolves through a
|
||||
// table and dials through a testDialer.
|
||||
func dialFixture(t *testing.T, d *db.DB, taskID string) (intercept.TargetScope, *tableResolver, *testDialer) {
|
||||
t.Helper()
|
||||
scope := gatedScope(t, d, taskID)
|
||||
res, dialer := newTableResolver(), newTestDialer()
|
||||
scope.Interceptor.SetResolver(res)
|
||||
scope.Interceptor.SetBaseDialer(dialer.dial)
|
||||
return scope, res, dialer
|
||||
}
|
||||
|
||||
// listener is an HTTP server that counts its requests; port is its port.
|
||||
func listener(t *testing.T, body string) (addr, port string, hits *atomic.Int64) {
|
||||
t.Helper()
|
||||
hits = &atomic.Int64{}
|
||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
hits.Add(1)
|
||||
w.Header().Set("Content-Type", "text/plain")
|
||||
_, _ = w.Write([]byte(body))
|
||||
}))
|
||||
t.Cleanup(srv.Close)
|
||||
addr = srv.Listener.Addr().String()
|
||||
_, port, _ = net.SplitHostPort(addr)
|
||||
return addr, port, hits
|
||||
}
|
||||
|
||||
// runAgentKind runs one scripted WebFetch call with the agent kind on ctx.
|
||||
func runAgentKind(t *testing.T, kind string, f hookReachFixture, ctx context.Context, rawURL string) {
|
||||
t.Helper()
|
||||
prov := toolCallThenStop("WebFetch", fetchInputJSON(rawURL))
|
||||
switch kind {
|
||||
case "worker":
|
||||
payload := map[string]any{"summary": "dial probe"}
|
||||
intentID, err := f.ts.AddNode("intent", payload, 0, "running", "planner", nil)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
raw, _ := json.Marshal(payload)
|
||||
w := NewWorker(prov, "test-model", f.workDir, nil, 0, 3)
|
||||
if _, _, err := w.Execute(ctx, "work#1", f.expID, nil, f.ts, &db.Node{ID: intentID, Payload: raw}, passHooks{}, nil, nil, nil); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
case "planner":
|
||||
p := NewPlanner(prov, "test-model", f.workDir, nil, 0, 3)
|
||||
if _, _, err := p.Plan(ctx, f.expID, nil, f.ts, "probe goal", nil, passHooks{}, nil); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
case "mainagent":
|
||||
m := NewMainAgent(prov, "test-model", f.workDir, nil, 0, 3)
|
||||
if _, err := m.Chat(ctx, f.expID, 0, nil, f.ts, "probe goal", "status?", passHooks{}, nil, nil, nil, nil, nil); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
case "chat":
|
||||
c := NewChatAgent(prov, "test-model", t.TempDir(), nil, 0)
|
||||
c.SetGuard(guard.New())
|
||||
if _, err := c.Chat(ctx, "assistant", "conv-dial-probe", "fetch it", 3, 0, false, nil); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Each agent kind's WebFetch reaches a pinned name at its pinned address, and
|
||||
// once the name answers another address it connects nowhere and asks. A fifth
|
||||
// agent kind built without the dialer fails this table once it is added to it.
|
||||
func TestWebFetchDialerWiredOnEveryAgentKind(t *testing.T) {
|
||||
for _, kind := range []string{"worker", "planner", "mainagent", "chat"} {
|
||||
t.Run(kind, func(t *testing.T) {
|
||||
f := newHookReachFixture(t)
|
||||
d := testDB(t)
|
||||
t.Cleanup(func() { _ = d.Close() })
|
||||
addr, port, hits := listener(t, "pinned-reached")
|
||||
scope, res, dialer := dialFixture(t, d, f.taskID)
|
||||
dialer.route("203.0.113.7:"+port, addr)
|
||||
dialer.route("203.0.113.9:"+port, addr)
|
||||
res.set("a.example", "203.0.113.7")
|
||||
u := "http://a.example:" + port + "/"
|
||||
pinTarget(t, d, scope, u)
|
||||
ctx := intercept.WithTargetScope(t.Context(), scope)
|
||||
|
||||
runAgentKind(t, kind, f, ctx, u)
|
||||
if hits.Load() != 1 || !slices.Equal(dialer.calls(), []string{"203.0.113.7:" + port}) {
|
||||
t.Fatalf("pinned: hits=%d dialled %v, want the pinned address", hits.Load(), dialer.calls())
|
||||
}
|
||||
res.set("a.example", "203.0.113.9")
|
||||
runAgentKind(t, kind, f, ctx, u)
|
||||
if hits.Load() != 1 || len(dialer.calls()) != 1 {
|
||||
t.Fatalf("address changed: hits=%d dialled %v, want nothing more", hits.Load(), dialer.calls())
|
||||
}
|
||||
if keys := openRedirectRequests(t, d, f.taskID); len(keys) != 1 || keys[0] != "a.example:"+port {
|
||||
t.Fatalf("open requests = %v, want one for a.example:%s", keys, port)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// S2: through a proxy, the dialer is given the proxy's address, never the
|
||||
// target's. The proxy is a derived exemption: dialled as received, no lookup,
|
||||
// no row. The connection to the target is the proxy's (step 2.2 binds it).
|
||||
func TestWebFetchProxiedDialIsTheProxy(t *testing.T) {
|
||||
d := testDB(t)
|
||||
t.Cleanup(func() { _ = d.Close() })
|
||||
f := newHookReachFixture(t)
|
||||
scope, res, dialer := dialFixture(t, d, f.taskID)
|
||||
proxy := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
_, _ = w.Write([]byte("via-proxy " + r.URL.Host))
|
||||
}))
|
||||
t.Cleanup(proxy.Close)
|
||||
scope.Interceptor.SetDerivedExemptions(func() []string { return []string{proxy.URL} })
|
||||
res.set("a.example", "203.0.113.7")
|
||||
ctx := intercept.WithTargetScope(t.Context(), scope)
|
||||
|
||||
out, isErr := callWebFetch(t, ctx, proxy.URL, "http://a.example:8080/")
|
||||
if isErr || !strings.Contains(out, "via-proxy a.example:8080") {
|
||||
t.Fatalf("proxied fetch: error=%v out=%q", isErr, out)
|
||||
}
|
||||
if got := dialer.calls(); !slices.Equal(got, []string{proxy.Listener.Addr().String()}) || res.lookups() != 0 {
|
||||
t.Fatalf("dialled %v after %d lookups, want the proxy only", got, res.lookups())
|
||||
}
|
||||
if keys := openRedirectRequests(t, d, f.taskID); len(keys) != 0 {
|
||||
t.Fatalf("open requests = %v", keys)
|
||||
}
|
||||
}
|
||||
|
||||
// D-8: a run built with the gate off keeps its direct retry when the gate is
|
||||
// switched on during the run, and the retry goes through the pinned dialer: a
|
||||
// pinned target is dialled at its pinned address, an unpinned one nowhere.
|
||||
func TestWebFetchRetryAfterLiveSwitchIsPinned(t *testing.T) {
|
||||
d := testDB(t)
|
||||
t.Cleanup(func() { _ = d.Close() })
|
||||
f := newHookReachFixture(t)
|
||||
scope, res, dialer := dialFixture(t, d, f.taskID)
|
||||
var on atomic.Bool
|
||||
scope.Enabled = on.Load
|
||||
scope.Interceptor.SetDerivedExemptions(func() []string { return []string{"http://127.0.0.1:1"} })
|
||||
addr, port, hits := listener(t, "retry-reached")
|
||||
dialer.route("203.0.113.7:"+port, addr)
|
||||
dialer.route("203.0.113.8:"+port, addr)
|
||||
res.set("a.example", "203.0.113.7")
|
||||
res.set("b.example", "203.0.113.8")
|
||||
ctx := intercept.WithTargetScope(t.Context(), scope)
|
||||
tools := withWebFetch(ctx, nil, "http://127.0.0.1:1", "")
|
||||
|
||||
on.Store(true)
|
||||
pinTarget(t, d, scope, "http://a.example:"+port+"/")
|
||||
call := func(u string) (string, bool) {
|
||||
r, err := tools[0].Call(ctx, json.RawMessage(fetchInputJSON(u)), &actool.ToolContext{})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
return r.Flatten(), r.IsError
|
||||
}
|
||||
if out, isErr := call("http://a.example:" + port + "/"); isErr || !strings.Contains(out, "retry-reached") || hits.Load() != 1 {
|
||||
t.Fatalf("pinned target through the retry: error=%v out=%q", isErr, out)
|
||||
}
|
||||
if out, isErr := call("http://b.example:" + port + "/"); !isErr || !strings.Contains(out, intercept.TargetApprovalPending) || hits.Load() != 1 {
|
||||
t.Fatalf("unpinned target through the retry: error=%v out=%q", isErr, out)
|
||||
}
|
||||
want := []string{"127.0.0.1:1", "203.0.113.7:" + port, "127.0.0.1:1"}
|
||||
if got := dialer.calls(); !slices.Equal(got, want) {
|
||||
t.Fatalf("dialled %v, want %v", got, want)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,258 @@
|
||||
package agent
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"net/url"
|
||||
"strconv"
|
||||
"strings"
|
||||
"sync/atomic"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/Autumn-27/artex/db"
|
||||
"github.com/Autumn-27/artex/guard"
|
||||
"github.com/Autumn-27/artex/intercept"
|
||||
"github.com/Autumn-27/norma/llm"
|
||||
actool "github.com/Autumn-27/norma/tool"
|
||||
)
|
||||
|
||||
// Step 1.9: the WebFetch tool of every agent kind checks each redirect hop
|
||||
// against the target gate. With the gate off it follows redirects as before.
|
||||
// Step 2.1: in a gated scope WebFetch has no direct retry.
|
||||
|
||||
// passHooks lets every tool call run.
|
||||
type passHooks struct{}
|
||||
|
||||
func (passHooks) PreToolUse(context.Context, string, []byte) (bool, string, []byte) {
|
||||
return false, "", nil
|
||||
}
|
||||
|
||||
func (passHooks) PostToolUse(context.Context, string, []byte, []byte, bool) {}
|
||||
|
||||
func (passHooks) Stop(context.Context, []llm.Message) (bool, []string, string) {
|
||||
return false, nil, ""
|
||||
}
|
||||
|
||||
// redirectPair is a server that redirects to a second one on another port of
|
||||
// 127.0.0.1, so the hop is another target (an IP literal: never resolved).
|
||||
type redirectPair struct {
|
||||
start, final string // URLs
|
||||
startHits, finalHits *atomic.Int64
|
||||
finalKey string // host:port of the redirect target
|
||||
}
|
||||
|
||||
func newRedirectPair(t *testing.T) redirectPair {
|
||||
t.Helper()
|
||||
p := redirectPair{startHits: &atomic.Int64{}, finalHits: &atomic.Int64{}}
|
||||
final := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
p.finalHits.Add(1)
|
||||
w.Header().Set("Content-Type", "text/plain")
|
||||
_, _ = w.Write([]byte("redirect-target-reached"))
|
||||
}))
|
||||
t.Cleanup(final.Close)
|
||||
start := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
p.startHits.Add(1)
|
||||
http.Redirect(w, r, final.URL+"/final", http.StatusFound)
|
||||
}))
|
||||
t.Cleanup(start.Close)
|
||||
u, _ := url.Parse(final.URL)
|
||||
p.start, p.final, p.finalKey = start.URL+"/start", final.URL+"/final", u.Host
|
||||
return p
|
||||
}
|
||||
|
||||
// gatedScope is a gated target scope on task taskID, whose rows are removed
|
||||
// afterwards.
|
||||
func gatedScope(t *testing.T, d *db.DB, taskID string) intercept.TargetScope {
|
||||
t.Helper()
|
||||
t.Cleanup(func() { _, _ = d.Exec(`DELETE FROM intercept_pending WHERE task_id=$1`, taskID) })
|
||||
return intercept.TargetScope{TaskID: taskID, Enabled: func() bool { return true },
|
||||
WaitBound: intercept.DefaultTargetWaitBound, Interceptor: intercept.New(d)}
|
||||
}
|
||||
|
||||
// openRedirectRequests returns the target keys of the open requests of task.
|
||||
func openRedirectRequests(t *testing.T, d *db.DB, taskID string) []string {
|
||||
t.Helper()
|
||||
rows, err := d.Query(`SELECT target_key FROM intercept_pending WHERE task_id=$1 AND status='pending' AND target_key IS NOT NULL ORDER BY id`, taskID)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer rows.Close()
|
||||
var keys []string
|
||||
for rows.Next() {
|
||||
var k string
|
||||
if err := rows.Scan(&k); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
keys = append(keys, k)
|
||||
}
|
||||
return keys
|
||||
}
|
||||
|
||||
func fetchInputJSON(u string) string {
|
||||
b, _ := json.Marshal(map[string]string{"url": u})
|
||||
return string(b)
|
||||
}
|
||||
|
||||
// Each agent kind runs a scripted WebFetch on a URL that redirects to a target
|
||||
// no pin covers. The hooks let the call run, so the hop is what the gate sees:
|
||||
// each kind must stop at the hop, leave the redirect target untouched and open
|
||||
// one request for it. A fifth agent kind added without the redirect policy
|
||||
// fails this table once it is added to it. The origin is pinned first: the
|
||||
// hooks never check it here, and the pinned dialer (step 2.1) connects only to
|
||||
// a pinned target.
|
||||
func TestWebFetchRedirectCheckWiredOnEveryAgentKind(t *testing.T) {
|
||||
for _, kind := range []string{"worker", "planner", "mainagent", "chat"} {
|
||||
t.Run(kind, func(t *testing.T) {
|
||||
f := newHookReachFixture(t)
|
||||
d := testDB(t)
|
||||
t.Cleanup(func() { _ = d.Close() })
|
||||
pair := newRedirectPair(t)
|
||||
scope := gatedScope(t, d, f.taskID)
|
||||
pinTarget(t, d, scope, pair.start)
|
||||
ctx := intercept.WithTargetScope(t.Context(), scope)
|
||||
prov := toolCallThenStop("WebFetch", fetchInputJSON(pair.start))
|
||||
|
||||
switch kind {
|
||||
case "worker":
|
||||
payload := map[string]any{"summary": "redirect probe"}
|
||||
intentID, err := f.ts.AddNode("intent", payload, 0, "running", "planner", nil)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
raw, _ := json.Marshal(payload)
|
||||
w := NewWorker(prov, "test-model", f.workDir, nil, 0, 3)
|
||||
if _, _, err := w.Execute(ctx, "work#1", f.expID, nil, f.ts, &db.Node{ID: intentID, Payload: raw}, passHooks{}, nil, nil, nil); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
case "planner":
|
||||
p := NewPlanner(prov, "test-model", f.workDir, nil, 0, 3)
|
||||
if _, _, err := p.Plan(ctx, f.expID, nil, f.ts, "probe goal", nil, passHooks{}, nil); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
case "mainagent":
|
||||
m := NewMainAgent(prov, "test-model", f.workDir, nil, 0, 3)
|
||||
if _, err := m.Chat(ctx, f.expID, 0, nil, f.ts, "probe goal", "status?", passHooks{}, nil, nil, nil, nil, nil); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
case "chat":
|
||||
c := NewChatAgent(prov, "test-model", t.TempDir(), nil, 0)
|
||||
c.SetGuard(guard.New())
|
||||
if _, err := c.Chat(ctx, "assistant", "conv-redirect-probe", "fetch it", 3, 0, false, nil); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
if pair.startHits.Load() != 1 {
|
||||
t.Fatalf("the fetch did not run: %d hits on the origin", pair.startHits.Load())
|
||||
}
|
||||
if pair.finalHits.Load() != 0 {
|
||||
t.Fatal("the redirect was followed to a target no pin covers")
|
||||
}
|
||||
if keys := openRedirectRequests(t, d, f.taskID); len(keys) != 1 || keys[0] != pair.finalKey {
|
||||
t.Fatalf("open requests = %v, want one for %s", keys, pair.finalKey)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// In a gated scope the direct retry is off (D-8): with a proxy that refuses the
|
||||
// connection, the fetch fails with the proxy's error and never leaves without
|
||||
// it. The proxy is a derived exemption, so its dial asks for nothing.
|
||||
func TestWebFetchGatedScopeHasNoDirectRetry(t *testing.T) {
|
||||
d := testDB(t)
|
||||
t.Cleanup(func() { _ = d.Close() })
|
||||
expID, err := d.CreateExploration("no direct retry probe", "a gated scope has no direct retry")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
t.Cleanup(func() { _, _ = d.Exec(`DELETE FROM explorations WHERE id=$1`, expID) })
|
||||
taskID := fmt.Sprint(expID)
|
||||
pair := newRedirectPair(t)
|
||||
scope := gatedScope(t, d, taskID)
|
||||
scope.Interceptor.SetDerivedExemptions(func() []string { return []string{"http://127.0.0.1:1"} })
|
||||
ctx := intercept.WithTargetScope(t.Context(), scope)
|
||||
|
||||
out, isErr := callWebFetch(t, ctx, "http://127.0.0.1:1", pair.start)
|
||||
if !isErr || !strings.Contains(out, "proxyconnect") || strings.Contains(out, "TARGET_") {
|
||||
t.Fatalf("proxied fetch: error=%v out=%q, want the proxy's error", isErr, out)
|
||||
}
|
||||
if pair.startHits.Load() != 0 || pair.finalHits.Load() != 0 {
|
||||
t.Fatalf("hits origin=%d target=%d, want no direct retry", pair.startHits.Load(), pair.finalHits.Load())
|
||||
}
|
||||
var requests int
|
||||
if err := d.QueryRow(`SELECT count(*) FROM intercept_pending WHERE task_id=$1 AND target_key IS NOT NULL`, taskID).Scan(&requests); err != nil || requests != 0 {
|
||||
t.Fatalf("%d requests, %v; want none", requests, err)
|
||||
}
|
||||
}
|
||||
|
||||
// With the gate off, or without a scope, WebFetch follows redirects as it did
|
||||
// with agentcore's own tool: to the end of the chain, and the same error after
|
||||
// 10 hops. No database.
|
||||
func TestWebFetchRedirectGateOffUnchanged(t *testing.T) {
|
||||
loop := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
http.Redirect(w, r, r.URL.Path+"x", http.StatusFound)
|
||||
}))
|
||||
t.Cleanup(loop.Close)
|
||||
for name, ctx := range map[string]context.Context{
|
||||
"no scope": t.Context(),
|
||||
"flag off": intercept.WithTargetScope(t.Context(), intercept.TargetScope{TaskID: "7", Enabled: func() bool { return false },
|
||||
WaitBound: time.Minute, Interceptor: intercept.New(nil)}),
|
||||
} {
|
||||
pair := newRedirectPair(t)
|
||||
for _, proxy := range []string{"", "http://127.0.0.1:1"} {
|
||||
if out, isErr := callWebFetch(t, ctx, proxy, pair.start); isErr || !strings.Contains(out, "redirect-target-reached") {
|
||||
t.Fatalf("%s, proxy %q: error=%v out=%q", name, proxy, isErr, out)
|
||||
}
|
||||
}
|
||||
if pair.finalHits.Load() != 2 {
|
||||
t.Fatalf("%s: %d hits on the redirect target, want 2", name, pair.finalHits.Load())
|
||||
}
|
||||
got, _ := callWebFetch(t, ctx, "", loop.URL+"/l")
|
||||
want := actool.NewWebFetch(actool.WebFetchConfig{}).Call
|
||||
res, err := want(ctx, json.RawMessage(fetchInputJSON(loop.URL+"/l")), &actool.ToolContext{})
|
||||
if err != nil || got != res.Flatten() || !strings.Contains(got, "stopped after 10 redirects") {
|
||||
t.Fatalf("%s: redirect loop: %q, want agentcore's %q", name, got, res.Flatten())
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// pinTarget opens the request for the target of rawURL in scope and approves
|
||||
// it, as a click on the approval card does.
|
||||
func pinTarget(t *testing.T, d *db.DB, scope intercept.TargetScope, rawURL string) {
|
||||
t.Helper()
|
||||
ic, input := scope.Interceptor, []byte(fetchInputJSON(rawURL))
|
||||
reqs, res := ic.CheckTargets(t.Context(), scope, "WebFetch", input)
|
||||
if res.Code != "" || len(reqs) != 1 {
|
||||
t.Fatalf("%s: requests=%+v result=%+v, want one request", rawURL, reqs, res)
|
||||
}
|
||||
scope.WaitBound = 0
|
||||
if res = ic.RequestTargets(t.Context(), scope, "WebFetch", input, reqs, nil); res.Code != intercept.TargetApprovalPending || res.PendingID == 0 {
|
||||
t.Fatalf("%s: request = %+v", rawURL, res)
|
||||
}
|
||||
if err := ic.Decide(res.PendingID, true, "test", "192.0.2.1"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
taskID, err := strconv.ParseInt(scope.TaskID, 10, 64)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
t.Cleanup(func() { _, _ = d.Exec(`DELETE FROM target_pins WHERE task_id=$1`, taskID) })
|
||||
}
|
||||
|
||||
// callWebFetch runs the WebFetch tool the agents build, with proxy.
|
||||
func callWebFetch(t *testing.T, ctx context.Context, proxy, u string) (string, bool) {
|
||||
t.Helper()
|
||||
tools := withWebFetch(ctx, nil, proxy, "")
|
||||
if len(tools) != 1 || tools[0].Name() != "WebFetch" {
|
||||
t.Fatalf("withWebFetch built %d tools", len(tools))
|
||||
}
|
||||
res, err := tools[0].Call(ctx, json.RawMessage(fetchInputJSON(u)), &actool.ToolContext{})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
return res.Flatten(), res.IsError
|
||||
}
|
||||
+5
-7
@@ -482,16 +482,14 @@ func (w *Worker) execute(ctx context.Context, name string, taskID int64, as *db.
|
||||
Provider: w.prov,
|
||||
SystemPrompt: system,
|
||||
DynamicBoundary: boundary,
|
||||
Tools: tools,
|
||||
Tools: withWebFetch(ctx, tools, w.proxyAddr, w.proxyCACert),
|
||||
DeferredTools: def.Deferred,
|
||||
UnlockSet: def.Unlock,
|
||||
PermissionMode: permission.ModeBypass,
|
||||
// WebFetch goes through the recording proxy, so its HTTP is recorded just like
|
||||
// curl; loading the proxy CA lets MITM-re-signed HTTPS certs [verify normally]
|
||||
// (rather than disabling verification). Direct when proxy is empty.
|
||||
EnableWebFetch: true,
|
||||
WebFetchProxy: w.proxyAddr,
|
||||
WebFetchCACert: w.proxyCACert,
|
||||
// WebFetch (added to Tools above) goes through the recording proxy, so its
|
||||
// HTTP is recorded just like curl; loading the proxy CA lets MITM-re-signed
|
||||
// HTTPS certs [verify normally] (rather than disabling verification). Direct
|
||||
// when proxy is empty. Every redirect hop goes through the target gate.
|
||||
// Web search (optional). ddgs needs no key; brave-free needs BraveKey; tavily needs TavilyKey.
|
||||
// WebSearchProxy is a dedicated egress proxy (http/https/socks5), unrelated to the traffic-recording MITM proxy; empty = direct.
|
||||
EnableWebSearch: w.webSearch.Enabled,
|
||||
|
||||
@@ -45,6 +45,12 @@ func (r AssetInterceptRule) Reason() string {
|
||||
|
||||
// matchOne checks whether a single enabled rule matches the given domain/IP/URL
|
||||
// candidates, and returns the concrete matched value.
|
||||
//
|
||||
// URL rules match the URL string as given, with no normalisation. Known limit:
|
||||
// exact_url misses any other spelling of the same URL (case, percent-encoding
|
||||
// such as %2F, a trailing slash, an added query, /./), and fuzzy_url misses an
|
||||
// encoded form of its substring. At tool dispatch the string is the URL the
|
||||
// call declares (intercept, targetCheck.run).
|
||||
func matchOne(r AssetInterceptRule, domains, ips, urls []string) (string, bool) {
|
||||
p := strings.TrimSpace(r.Pattern)
|
||||
if p == "" {
|
||||
|
||||
@@ -76,6 +76,9 @@ type InterceptTarget struct {
|
||||
// ExemptVoid: a stored exemption names this target, and did not apply because
|
||||
// the name resolved to a private, loopback or otherwise local address.
|
||||
ExemptVoid bool `json:"exempt_void,omitempty"`
|
||||
// RedirectFrom: the origin (host:port) of the redirect hop that led to this
|
||||
// target; empty when the call named the target itself.
|
||||
RedirectFrom string `json:"redirect_from,omitempty"`
|
||||
}
|
||||
|
||||
type InterceptDetail struct {
|
||||
|
||||
@@ -61,4 +61,4 @@ require (
|
||||
modernc.org/memory v1.11.0 // indirect
|
||||
)
|
||||
|
||||
replace github.com/Autumn-27/norma => github.com/BaaRai/Norma v0.4.6
|
||||
replace github.com/Autumn-27/norma => github.com/BaaRai/Norma v0.4.8
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
github.com/BaaRai/Norma v0.4.6 h1:sEm58Gx7gw+UU/05aHZBZ+Xqm5dMYiuSQpc1aXnbElc=
|
||||
github.com/BaaRai/Norma v0.4.6/go.mod h1:BudWrf7iHl96FgHqFr/HwN3mKYmGjJDt+xL2ZHXfFZw=
|
||||
github.com/BaaRai/Norma v0.4.8 h1:k3at2aYSJ6aIDjEo7tC4VDSLBHXw2HobYjpKChVe6hI=
|
||||
github.com/BaaRai/Norma v0.4.8/go.mod h1:BudWrf7iHl96FgHqFr/HwN3mKYmGjJDt+xL2ZHXfFZw=
|
||||
github.com/andybalholm/brotli v1.2.1 h1:R+f5xP285VArJDRgowrfb9DqL18yVK0gKAW/F+eTWro=
|
||||
github.com/andybalholm/brotli v1.2.1/go.mod h1:rzTDkvFWvIrjDXZHkuS16NPggd91W3kUSvPlQ1pLaKY=
|
||||
github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2 h1:DklsrG3dyBCFEj5IhUbnKptjxatkF07cF2ak3yi77so=
|
||||
|
||||
@@ -282,18 +282,27 @@ type gateDB struct {
|
||||
task string // task id
|
||||
}
|
||||
|
||||
// stubResolver answers every name with the addresses it holds.
|
||||
// stubResolver answers every name with the addresses it holds, and counts the
|
||||
// lookups.
|
||||
type stubResolver struct {
|
||||
mu sync.Mutex
|
||||
ips []string
|
||||
err error
|
||||
n int
|
||||
}
|
||||
|
||||
func (r *stubResolver) Name() string { return "stub" }
|
||||
|
||||
func (r *stubResolver) lookups() int {
|
||||
r.mu.Lock()
|
||||
defer r.mu.Unlock()
|
||||
return r.n
|
||||
}
|
||||
|
||||
func (r *stubResolver) LookupIPs(context.Context, string) ([]netip.Addr, error) {
|
||||
r.mu.Lock()
|
||||
defer r.mu.Unlock()
|
||||
r.n++
|
||||
if r.err != nil {
|
||||
return nil, r.err
|
||||
}
|
||||
@@ -576,8 +585,8 @@ func TestGateOffLeavesEveryBranchUnchanged(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// A deny by a rule blocks first, as before: the gate is not consulted and no
|
||||
// target request exists.
|
||||
// A deny by a rule or by the judge blocks first, as before: the gate is not
|
||||
// consulted, nothing is resolved and no target request exists.
|
||||
func TestDenyRuleWinsBeforeTargetRequest(t *testing.T) {
|
||||
g := newGateDB(t)
|
||||
m := marker(t)
|
||||
@@ -601,8 +610,77 @@ func TestDenyRuleWinsBeforeTargetRequest(t *testing.T) {
|
||||
if block, _ := pre(guard, g.ctx(true, time.Minute), "Bash", `{"command":"curl https://app.example.com/ # `+m+`"}`); !block {
|
||||
t.Fatal("deny did not block")
|
||||
}
|
||||
if len(g.pending()) != 0 || len(g.pins()) != 0 {
|
||||
t.Fatalf("pending=%+v pins=%+v, want none", g.pending(), g.pins())
|
||||
if len(g.pending()) != 0 || len(g.pins()) != 0 || g.res.lookups() != 0 {
|
||||
t.Fatalf("pending=%+v pins=%+v lookups=%d, want none", g.pending(), g.pins(), g.res.lookups())
|
||||
}
|
||||
|
||||
// A deny by the judge takes the same branch.
|
||||
g.judge("deny")
|
||||
input := `{"command":"curl https://judged.example.com/"}`
|
||||
gate = &fakeGate{t: t, check: unpinnedOnce}
|
||||
guard = NewWithInterceptor(g.ic)
|
||||
guard.gate = gate
|
||||
before := len(g.rows())
|
||||
if block, msg := pre(guard, g.ctx(true, time.Minute), "Bash", input); !block || !strings.Contains(msg, "judge says deny") || strings.Contains(msg, "TARGET_") {
|
||||
t.Fatalf("judge deny: block=%v msg=%q", block, msg)
|
||||
}
|
||||
if gate.checks != 0 || len(gate.asked) != 0 {
|
||||
t.Fatalf("judge deny: the gate was reached: %d checks, %d requests", gate.checks, len(gate.asked))
|
||||
}
|
||||
if rows := g.rows()[before:]; len(rows) != 1 || rows[0].status != "denied" || rows[0].decidedBy != "model" || rows[0].targetKey != "" {
|
||||
t.Fatalf("judge deny: rows = %+v, want the denied judge row only", rows)
|
||||
}
|
||||
guard = NewWithInterceptor(g.ic)
|
||||
if block, _ := pre(guard, g.ctx(true, time.Minute), "Bash", input); !block {
|
||||
t.Fatal("judge deny did not block")
|
||||
}
|
||||
if len(g.pending()) != 0 || len(g.pins()) != 0 || g.res.lookups() != 0 {
|
||||
t.Fatalf("judge deny: pending=%+v pins=%+v lookups=%d, want none", g.pending(), g.pins(), g.res.lookups())
|
||||
}
|
||||
}
|
||||
|
||||
// An asset block rule wins over an allow and an ask, of a rule or of the
|
||||
// judge: the call is blocked, the allow is not logged, no human is asked, and
|
||||
// the rule hits on what the call declares, so nothing is resolved. A name rule
|
||||
// and a URL rule behave the same.
|
||||
func TestBlockRuleWinsOverAllowAndAsk(t *testing.T) {
|
||||
const input = `{"command":"curl https://app.example.com/blocked-path # %s"}`
|
||||
for _, block := range []struct{ name, kind, pattern string }{
|
||||
{"name rule", "exact_domain", "app.example.com"},
|
||||
{"URL rule", "fuzzy_url", "/blocked-path"},
|
||||
} {
|
||||
for _, v := range []struct{ name, by, action string }{
|
||||
{"rule allow", "rule", "allow"},
|
||||
{"judge allow", "judge", "allow"},
|
||||
{"rule ask", "rule", "ask"},
|
||||
{"judge ask", "judge", "ask"},
|
||||
} {
|
||||
t.Run(block.name+" over "+v.name, func(t *testing.T) {
|
||||
g := newGateDB(t)
|
||||
id, _ := strconv.ParseInt(g.task, 10, 64)
|
||||
if _, err := g.d.Assets().CreateTaskInterceptRule(id, "block", block.kind, block.pattern, "guard test", true); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
m := marker(t)
|
||||
if v.by == "rule" {
|
||||
g.rule(v.action, m)
|
||||
} else {
|
||||
g.judge(v.action)
|
||||
}
|
||||
guard := NewWithInterceptor(g.ic)
|
||||
r := g.result(call(guard, g.ctx(true, time.Minute), "Bash", fmt.Sprintf(input, m)))
|
||||
if !r.block || !strings.Contains(r.msg, intercept.TargetRuleBlocked+": ") || !strings.Contains(r.msg, block.pattern) {
|
||||
t.Fatalf("block=%v msg=%q, want %s", r.block, r.msg, intercept.TargetRuleBlocked)
|
||||
}
|
||||
rows := g.rows()
|
||||
if len(rows) != 1 || rows[0].status != "denied" || rows[0].decidedBy != "system" || rows[0].ruleID != 0 {
|
||||
t.Fatalf("rows = %+v, want the one block row of the gate: no allow logged, nobody asked", rows)
|
||||
}
|
||||
if n := g.res.lookups(); n != 0 || len(g.pins()) != 0 {
|
||||
t.Fatalf("%d lookups, pins %+v; want none", n, g.pins())
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -16,6 +16,7 @@ import (
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"fmt"
|
||||
"net"
|
||||
"regexp"
|
||||
"strconv"
|
||||
"strings"
|
||||
@@ -190,6 +191,9 @@ type Interceptor struct {
|
||||
targets targetStore
|
||||
resolve *resolveCache
|
||||
firstUse sync.Map
|
||||
// dial is the base dialer of PinnedDialer: every connection it lets through
|
||||
// is opened here. See SetBaseDialer.
|
||||
dial func(ctx context.Context, network, addr string) (net.Conn, error)
|
||||
}
|
||||
|
||||
// SetUpstreamProxyCheck installs the function that reports whether an upstream
|
||||
@@ -220,7 +224,7 @@ var defaultEnabledTools = []string{
|
||||
// first use.
|
||||
func New(d *db.DB) *Interceptor {
|
||||
return &Interceptor{db: d, pending: newPendingManager(),
|
||||
targets: dbTargetStore{d}, resolve: newResolveCache(systemResolver{})}
|
||||
targets: dbTargetStore{d}, resolve: newResolveCache(systemResolver{}), dial: baseDial}
|
||||
}
|
||||
|
||||
// Invalidate clears the in-memory rule cache and the enabled-tools cache.
|
||||
|
||||
@@ -0,0 +1,193 @@
|
||||
package intercept
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"slices"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/Autumn-27/artex/db"
|
||||
)
|
||||
|
||||
// The declared forms of a call decide first: the URL block rules on the URLs
|
||||
// the call writes, then the block rules on every name, IP literal and range as
|
||||
// written. Nothing is resolved before that, so a hit costs no lookup.
|
||||
|
||||
func TestExtractDeclaredURLs(t *testing.T) {
|
||||
raw := func(v any) []byte {
|
||||
b, _ := json.Marshal(v)
|
||||
return b
|
||||
}
|
||||
for _, c := range []struct {
|
||||
name string
|
||||
tool string
|
||||
input []byte
|
||||
want []string
|
||||
}{
|
||||
{"WebFetch", "WebFetch", raw(map[string]string{"url": " https://app.example.com/admin?x=1 "}), []string{"https://app.example.com/admin?x=1"}},
|
||||
{"WebFetch without a target", "WebFetch", raw(map[string]string{"url": "http:///path"}), nil},
|
||||
{"Bash, query kept", "Bash", raw(command("curl -s 'https://a.example.com/admin?x=1'")), []string{"https://a.example.com/admin?x=1"}},
|
||||
{"Bash, two URLs", "Bash", raw(command("curl http://a.example.com/x && curl https://b.example.com:8443/y")),
|
||||
[]string{"http://a.example.com/x", "https://b.example.com:8443/y"}},
|
||||
{"shell_send", "shell_send", raw(map[string]string{"text": "curl http://a.example.com/x\n"}), []string{"http://a.example.com/x"}},
|
||||
{"Monitor", "Monitor", raw(command("watch curl http://198.51.100.9:8080/status")), []string{"http://198.51.100.9:8080/status"}},
|
||||
{"MCP string leaves", "mcp__scan__run", []byte(`{"target":"http://a.example.com/p","opts":{"list":["https://b.example.com/q"]}}`),
|
||||
[]string{"http://a.example.com/p", "https://b.example.com/q"}},
|
||||
{"ExecuteExtraTool unwrap", executeExtraTool, raw(map[string]any{"tool_name": "WebFetch", "params": map[string]string{"url": "https://a.example.com/z"}}),
|
||||
[]string{"https://a.example.com/z"}},
|
||||
{"tool without a target", "web_search", raw(map[string]string{"query": "https://a.example.com/admin"}), nil},
|
||||
{"wrapped tool without a target", executeExtraTool, raw(map[string]any{"tool_name": "web_search", "params": map[string]string{"query": "https://a.example.com/admin"}}), nil},
|
||||
{"authority that names no host", "Bash", raw(command("curl http://$HOST/x https://${H}:8443/admin")), nil},
|
||||
} {
|
||||
d := extractDeclared(c.tool, c.input)
|
||||
if !slices.Equal(d.urls, c.want) {
|
||||
t.Errorf("%s: urls = %q, want %q", c.name, d.urls, c.want)
|
||||
}
|
||||
// The targets are those ExtractTargets returns.
|
||||
if !slices.Equal(d.targets, ExtractTargets(c.tool, c.input)) {
|
||||
t.Errorf("%s: targets differ from ExtractTargets", c.name)
|
||||
}
|
||||
if len(d.urls) > 0 && len(d.targets) == 0 {
|
||||
t.Errorf("%s: a URL without a target", c.name)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// A name that a name rule blocks is blocked on the name as written: no lookup
|
||||
// is made for it, nor for another name of the same call that no rule blocks.
|
||||
func TestBlockRuleOnDeclaredNameNeedsNoLookup(t *testing.T) {
|
||||
for _, rule := range []db.AssetInterceptRule{
|
||||
{Enabled: true, Kind: "exact_domain", Pattern: "blocked.example.com"},
|
||||
{Enabled: true, Kind: "fuzzy_domain", Pattern: "blocked.example"},
|
||||
} {
|
||||
g := newGate(t)
|
||||
g.res.set("ok.example.com", "203.0.113.7")
|
||||
g.res.set("blocked.example.com", "203.0.113.8")
|
||||
g.store.rules = []db.AssetInterceptRule{rule}
|
||||
for name, v := range map[string]verdict{
|
||||
"WebFetch": g.fetch("https://blocked.example.com/"),
|
||||
// The unblocked name comes first in the call.
|
||||
"two names": g.check("Bash", `{"command":"curl https://ok.example.com/ https://blocked.example.com/"}`),
|
||||
} {
|
||||
res := g.blocked(rule.Kind+", "+name, TargetRuleBlocked, v)
|
||||
if res.Host != "blocked.example.com" || !strings.Contains(res.Reason, rule.Pattern) {
|
||||
t.Fatalf("%s, %s: result = %+v", rule.Kind, name, res)
|
||||
}
|
||||
}
|
||||
if n := g.res.total(); n != 0 {
|
||||
t.Fatalf("%s: %d lookups, want none", rule.Kind, n)
|
||||
}
|
||||
for _, row := range g.store.logged {
|
||||
if a := row.Audit.Targets[0]; a.Outcome != "rule_blocked" || len(a.ResolvedIPs) != 0 {
|
||||
t.Fatalf("%s: logged target = %+v, want rule_blocked with no address", rule.Kind, a)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// URL rules apply at dispatch, on the URLs the call declares, before anything
|
||||
// is resolved. A hit blocks with the code of every block rule, opens no
|
||||
// request, and wins over a pin and an exemption.
|
||||
func TestURLBlockRuleAtDispatch(t *testing.T) {
|
||||
g := newGate(t)
|
||||
g.res.set("app.example.com", "203.0.113.7")
|
||||
g.res.set("pypi.org", "151.101.0.223")
|
||||
g.store.exempt = []db.TargetExemption{{Host: "pypi.org", Port: 443}}
|
||||
g.store.approve(TargetRequest{Host: "app.example.com", Port: 443, ResolvedIPs: []string{"203.0.113.7"}})
|
||||
g.passes("pinned", g.fetch("https://app.example.com/admin"))
|
||||
g.passes("exempt", g.fetch("https://pypi.org/admin"))
|
||||
|
||||
rule := func(kind, pattern string, enabled bool) []db.AssetInterceptRule {
|
||||
return []db.AssetInterceptRule{{Enabled: enabled, Kind: kind, Pattern: pattern}}
|
||||
}
|
||||
// A disabled URL rule blocks nothing.
|
||||
g.store.rules = rule("exact_url", "https://app.example.com/admin", false)
|
||||
g.passes("disabled rule", g.fetch("https://app.example.com/admin"))
|
||||
|
||||
lookups, rows := g.res.total(), len(g.store.logged)
|
||||
for _, c := range []struct {
|
||||
name string
|
||||
rules []db.AssetInterceptRule
|
||||
v func() verdict
|
||||
host string
|
||||
port int
|
||||
matchedURL string
|
||||
}{
|
||||
{"exact_url, WebFetch of a pinned host", rule("exact_url", "https://app.example.com/admin", true),
|
||||
func() verdict { return g.fetch("https://app.example.com/admin") }, "app.example.com", 443, "https://app.example.com/admin"},
|
||||
{"fuzzy_url, exempt host", rule("fuzzy_url", "/admin", true),
|
||||
func() verdict { return g.fetch("https://pypi.org/admin") }, "pypi.org", 443, "https://pypi.org/admin"},
|
||||
{"fuzzy_url, Bash with a query", rule("fuzzy_url", "/admin", true),
|
||||
func() verdict { return g.check("Bash", `{"command":"curl -s 'https://app.example.com/admin?x=1'"}`) }, "app.example.com", 443, "https://app.example.com/admin?x=1"},
|
||||
{"fuzzy_url, second URL of the call", rule("fuzzy_url", "/admin", true),
|
||||
func() verdict {
|
||||
return g.check("Bash", `{"command":"curl https://app.example.com/ && curl http://198.51.100.9:8080/admin"}`)
|
||||
}, "198.51.100.9", 8080, "http://198.51.100.9:8080/admin"},
|
||||
{"fuzzy_url, MCP input", rule("fuzzy_url", "/ADMIN", true),
|
||||
func() verdict { return g.check("mcp__scan__run", `{"target":"https://app.example.com/admin/users"}`) }, "app.example.com", 443, "https://app.example.com/admin/users"},
|
||||
{"exact_url, wrapped WebFetch", rule("exact_url", "https://app.example.com/admin", true),
|
||||
func() verdict {
|
||||
return g.check(executeExtraTool, `{"tool_name":"WebFetch","params":{"url":"https://app.example.com/admin"}}`)
|
||||
}, "app.example.com", 443, "https://app.example.com/admin"},
|
||||
} {
|
||||
g.store.rules = c.rules
|
||||
g.res.set("app.example.com", "198.51.100.200") // a lookup would make a pinned host ask
|
||||
res := g.blocked(c.name, TargetRuleBlocked, c.v())
|
||||
if res.Host != c.host || res.Port != c.port || !strings.Contains(res.Reason, c.matchedURL+" is blocked by an asset rule") ||
|
||||
!strings.Contains(res.Reason, c.rules[0].Pattern) {
|
||||
t.Errorf("%s: result = %+v", c.name, res)
|
||||
}
|
||||
}
|
||||
if n := g.res.total() - lookups; n != 0 {
|
||||
t.Fatalf("%d lookups for calls a URL rule blocks, want none", n)
|
||||
}
|
||||
if got := g.store.outcomes()[rows:]; len(got) != 6 || slices.ContainsFunc(got, func(o string) bool { return o != "denied/rule_blocked" }) {
|
||||
t.Fatalf("logged rows = %v, want 6 rule_blocked rows", got)
|
||||
}
|
||||
|
||||
// The rendered URL of a custom http tool and the URLs of a rendered command
|
||||
// meet the same rules, with no lookup.
|
||||
g.store.rules = rule("exact_url", "https://app.example.com/admin", true)
|
||||
if res := GateRenderedURL(g.ctx(), "probe_http", "https://app.example.com/admin"); res.Code != TargetRuleBlocked || res.Host != "app.example.com" {
|
||||
t.Fatalf("rendered URL: %+v", res)
|
||||
}
|
||||
g.store.rules = rule("fuzzy_url", "/admin", true)
|
||||
if res := GateRenderedCommand(g.ctx(), "probe_cmd", "curl 'https://app.example.com/admin'"); res.Code != TargetRuleBlocked {
|
||||
t.Fatalf("rendered command: %+v", res)
|
||||
}
|
||||
if n := g.res.total() - lookups; n != 0 {
|
||||
t.Fatalf("%d lookups for rendered calls a URL rule blocks, want none", n)
|
||||
}
|
||||
}
|
||||
|
||||
// Documents the known limit of URL rules: they match the URL as the call
|
||||
// writes it. Another spelling of the same URL is not blocked. For a host, a
|
||||
// domain, IP or CIDR rule is the one to write.
|
||||
func TestExactURLRuleMatchesOnlyAsWritten(t *testing.T) {
|
||||
g := newGate(t)
|
||||
g.res.set("app.example.com", "203.0.113.7")
|
||||
g.store.approve(TargetRequest{Host: "app.example.com", Port: 443, ResolvedIPs: []string{"203.0.113.7"}})
|
||||
|
||||
g.store.rules = []db.AssetInterceptRule{{Enabled: true, Kind: "exact_url", Pattern: "https://app.example.com/admin"}}
|
||||
g.blocked("as written", TargetRuleBlocked, g.fetch("https://app.example.com/admin"))
|
||||
for _, u := range []string{
|
||||
"https://APP.example.com/admin", // case of the host
|
||||
"https://app.example.com/Admin", // case of the path
|
||||
"https://app.example.com/admin/", // trailing slash
|
||||
"https://app.example.com/admin?x=1", // added query
|
||||
"https://app.example.com/%61dmin", // percent-encoding
|
||||
"https://app.example.com/./admin", // dot segment
|
||||
"https://app.example.com:443/admin", // default port written out
|
||||
} {
|
||||
g.passes("exact_url, "+u, g.fetch(u))
|
||||
}
|
||||
|
||||
g.store.rules = []db.AssetInterceptRule{{Enabled: true, Kind: "fuzzy_url", Pattern: "/admin"}}
|
||||
g.blocked("fuzzy, as written", TargetRuleBlocked, g.fetch("https://app.example.com/x/admin"))
|
||||
for _, u := range []string{"https://app.example.com/%61dmin", "https://app.example.com/adm%69n", "https://app.example.com//%2fadmin"} {
|
||||
if strings.Contains(strings.ToLower(u), "/admin") {
|
||||
t.Fatalf("%s contains the pattern; the case documents an encoded form", u)
|
||||
}
|
||||
g.passes("fuzzy_url, "+u, g.fetch(u))
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,180 @@
|
||||
package intercept
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"net"
|
||||
"net/netip"
|
||||
"strconv"
|
||||
"strings"
|
||||
"time"
|
||||
)
|
||||
|
||||
// The HTTP clients the platform owns (WebFetch and the custom http tool)
|
||||
// connect through PinnedDialer. The hook, the rendered-URL gate and the
|
||||
// redirect policy decide on a URL, and the client then resolves the name again
|
||||
// on its own when it connects: a name can answer differently in between. In a
|
||||
// gated scope the dialer takes a second, independent decision on the address
|
||||
// it is asked to connect to (the target of the call, of a redirect hop, or a
|
||||
// proxy). It resolves the name afresh, compares the answer with the pins, and
|
||||
// connects only to the addresses it compared, never to the name. It never
|
||||
// waits: an address no pin covers finds or opens the approval request and
|
||||
// fails the connection at once with TARGET_APPROVAL_PENDING.
|
||||
|
||||
// baseDial opens a connection with the dialer settings of http.DefaultTransport.
|
||||
var baseDial = (&net.Dialer{Timeout: 30 * time.Second, KeepAlive: 30 * time.Second}).DialContext
|
||||
|
||||
// PinnedDialer returns the DialContext of a platform-owned HTTP client run by
|
||||
// the tool toolName. The scope is read from the context net/http passes to the
|
||||
// dial, which carries the values of the request's context: the scope the hook,
|
||||
// the rendered-URL gate and the redirect policy read.
|
||||
//
|
||||
// scoped is whether the client was built for a session with a target scope.
|
||||
// Such a client never dials without one: a scope missing at the dial means the
|
||||
// context value was lost on the way, and the dial fails with
|
||||
// TARGET_GATE_UNAVAILABLE. A client built without a scope (the operator's test
|
||||
// endpoint) dials as before, and so does every client while the gate is off.
|
||||
func PinnedDialer(toolName string, scoped bool) func(ctx context.Context, network, addr string) (net.Conn, error) {
|
||||
return func(ctx context.Context, network, addr string) (net.Conn, error) {
|
||||
scope, ok := TargetScopeFromContext(ctx)
|
||||
switch {
|
||||
case !ok && scoped:
|
||||
return nil, &dialError{code: TargetGateUnavailable, target: addr, reason: "the target scope of the session did not reach the connection"}
|
||||
case !ok:
|
||||
return baseDial(ctx, network, addr)
|
||||
case scope.Enabled == nil || !scope.Enabled():
|
||||
if scope.Interceptor != nil {
|
||||
return scope.Interceptor.baseDialer()(ctx, network, addr)
|
||||
}
|
||||
return baseDial(ctx, network, addr)
|
||||
case scope.Interceptor == nil:
|
||||
return nil, &dialError{code: TargetGateUnavailable, target: addr, reason: "the session's target scope carries no gate"}
|
||||
}
|
||||
return scope.Interceptor.dialTarget(ctx, scope, toolName, network, addr)
|
||||
}
|
||||
}
|
||||
|
||||
// GateOn reports whether ctx carries a target scope whose gate is on.
|
||||
func GateOn(ctx context.Context) bool {
|
||||
_, on := renderedScope(ctx)
|
||||
return on
|
||||
}
|
||||
|
||||
func (i *Interceptor) baseDialer() func(ctx context.Context, network, addr string) (net.Conn, error) {
|
||||
i.mu.RLock()
|
||||
defer i.mu.RUnlock()
|
||||
return i.dial
|
||||
}
|
||||
|
||||
// dialTarget decides one connection of a gated scope and opens it. The asset
|
||||
// block rules, exemptions and pins are those of the hook, on the target the
|
||||
// address names, with a fresh lookup. URL rules are not matched: they ran on
|
||||
// the URL at the hook and on each hop in RedirectCheck.
|
||||
//
|
||||
// A derived exemption, and a pin that is name-only for this connection, dial
|
||||
// the address as received. A stored exemption that holds, and a pin that
|
||||
// holds every address of the lookup, dial those addresses and nothing else.
|
||||
func (i *Interceptor) dialTarget(ctx context.Context, scope TargetScope, toolName, network, addr string) (net.Conn, error) {
|
||||
input, _ := json.Marshal(map[string]string{"dial": addr})
|
||||
ctx = WithCall(ctx, toolName, input)
|
||||
t, err := addrTarget(network, addr)
|
||||
if err != nil {
|
||||
res := undeterminedTarget(ctx, scope, toolName, input, "the address of the connection could not be read ("+err.Error()+")")
|
||||
return nil, &dialError{code: res.Code, target: addr, reason: res.Reason}
|
||||
}
|
||||
blocked := func(res TargetResult) error {
|
||||
return &dialError{code: res.Code, target: t.String(), reason: res.Reason}
|
||||
}
|
||||
c := &targetCheck{i: i, ctx: ctx, scope: scope, tool: toolName, input: input, fresh: true}
|
||||
unpinned, res := c.run([]Target{t})
|
||||
if res.Code != "" {
|
||||
return nil, blocked(res)
|
||||
}
|
||||
if len(unpinned) > 0 {
|
||||
// Wait bound 0: the request is found or created, and the dial does not wait.
|
||||
scope.WaitBound = 0
|
||||
res = i.RequestTargets(ctx, scope, toolName, input, unpinned, nil)
|
||||
if res.Code == TargetApprovalPending {
|
||||
res.Reason = notCovered(unpinned[0], scope)
|
||||
}
|
||||
return nil, blocked(res)
|
||||
}
|
||||
switch ct := c.checked[0]; ct.cover {
|
||||
case coverDerived, coverNameOnly:
|
||||
return i.baseDialer()(ctx, network, addr)
|
||||
default:
|
||||
return i.dialAddrs(ctx, network, ct.ips, t.Port)
|
||||
}
|
||||
}
|
||||
|
||||
// addrTarget reads the address net/http dials, host:port with the host in
|
||||
// ASCII form and the port always written, as the target urlTarget reads from
|
||||
// the URL.
|
||||
func addrTarget(network, addr string) (Target, error) {
|
||||
switch network {
|
||||
case "tcp", "tcp4", "tcp6":
|
||||
default:
|
||||
return Target{}, fmt.Errorf("network %q is not tcp", network)
|
||||
}
|
||||
host, port, err := net.SplitHostPort(addr)
|
||||
if err != nil {
|
||||
return Target{}, err
|
||||
}
|
||||
kind, h, ok := normalizeHost(host, true)
|
||||
if !ok || kind == TargetCIDR {
|
||||
return Target{}, fmt.Errorf("host %q", host)
|
||||
}
|
||||
t := Target{Kind: kind, Host: h, Port: validPort(port)}
|
||||
if t.Port == 0 {
|
||||
return Target{}, fmt.Errorf("port %q", port)
|
||||
}
|
||||
return t, nil
|
||||
}
|
||||
|
||||
// dialAddrs connects to the addresses the decision compared, in their canonical
|
||||
// order: the first that accepts wins. An address of the wrong family for tcp4
|
||||
// or tcp6 is skipped. When every attempt fails, the last error is returned.
|
||||
func (i *Interceptor) dialAddrs(ctx context.Context, network string, ips []string, port int) (net.Conn, error) {
|
||||
dial := i.baseDialer()
|
||||
var last error = &net.AddrError{Err: "no suitable address found", Addr: strings.Join(ips, ", ")}
|
||||
for _, ip := range ips {
|
||||
a, err := netip.ParseAddr(ip)
|
||||
if err != nil || network == "tcp4" && !a.Is4() || network == "tcp6" && !a.Is6() {
|
||||
continue
|
||||
}
|
||||
conn, err := dial(ctx, network, net.JoinHostPort(ip, strconv.Itoa(port)))
|
||||
if err == nil {
|
||||
return conn, nil
|
||||
}
|
||||
last = err
|
||||
}
|
||||
return nil, last
|
||||
}
|
||||
|
||||
// notCovered says why a connection needs an approval: the addresses the dial
|
||||
// resolved, and the pin they fall outside of.
|
||||
func notCovered(r TargetRequest, scope TargetScope) string {
|
||||
if r.Pin != nil {
|
||||
return fmt.Sprintf("%s now resolves to %s, outside pin v%d (%s) of %s",
|
||||
r.Host, strings.Join(r.ResolvedIPs, ", "), r.Pin.Version, strings.Join(r.Pin.PinnedIPs, ", "), scope.scopeName())
|
||||
}
|
||||
if r.Kind != TargetDomain {
|
||||
return fmt.Sprintf("%s is not approved for %s", r.Host, scope.scopeName())
|
||||
}
|
||||
return fmt.Sprintf("%s resolves to %s and is not approved for %s", r.Host, strings.Join(r.ResolvedIPs, ", "), scope.scopeName())
|
||||
}
|
||||
|
||||
// dialError is what PinnedDialer returns for a connection it does not open.
|
||||
// Both clients hand the error to the model as the tool result.
|
||||
type dialError struct {
|
||||
code, target, reason string
|
||||
}
|
||||
|
||||
func (e *dialError) Error() string {
|
||||
msg := "[ARTEX platform control, not target defense] " + e.code + ": the connection to " + e.target + " was not opened: " + e.reason + "."
|
||||
if e.code == TargetApprovalPending {
|
||||
msg += " An approval was requested. Retry the same call after the approval."
|
||||
}
|
||||
return msg + " Do not fetch the target with another tool or by its address."
|
||||
}
|
||||
@@ -0,0 +1,336 @@
|
||||
package intercept
|
||||
|
||||
import (
|
||||
"context"
|
||||
"net"
|
||||
"net/http/httptest"
|
||||
"slices"
|
||||
"strings"
|
||||
"sync"
|
||||
"sync/atomic"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/Autumn-27/artex/db"
|
||||
)
|
||||
|
||||
// Step 2.1 against PostgreSQL: a connection no pin covers at the dial opens or
|
||||
// finds the durable request, connects nowhere, and fails at once.
|
||||
|
||||
// pgDialGate is a gate on d with a fake resolver and a recording base dialer.
|
||||
func pgDialGate(t *testing.T, d *db.DB) (*Interceptor, *fakeResolver, *dialRecorder) {
|
||||
t.Helper()
|
||||
ic, res := pgGate(t, d)
|
||||
rec := newDialRecorder()
|
||||
ic.SetBaseDialer(rec.dial)
|
||||
return ic, res, rec
|
||||
}
|
||||
|
||||
// openTarget returns the audit target of the single open request of scope.
|
||||
func openTarget(t *testing.T, d *db.DB, scope TargetScope) (*db.InterceptDetail, db.InterceptTarget) {
|
||||
t.Helper()
|
||||
ids := openRows(t, d, scope)
|
||||
if len(ids) != 1 {
|
||||
t.Fatalf("open requests = %v, want one", ids)
|
||||
}
|
||||
detail, err := d.GetInterceptDetail(ids[0])
|
||||
if err != nil || detail == nil || detail.Audit == nil || len(detail.Audit.Targets) != 1 {
|
||||
t.Fatalf("request detail = %+v, %v", detail, err)
|
||||
}
|
||||
return detail, detail.Audit.Targets[0]
|
||||
}
|
||||
|
||||
// The failure test: the check passes on the pinned address, the name answers
|
||||
// another one before the dial, and the call connects nowhere: not to the old
|
||||
// address, not to the new one. One new_ip request shows both; once approved,
|
||||
// the same call connects to the new address.
|
||||
func TestPinAddressChangedBetweenCheckAndDialNotReachable(t *testing.T) {
|
||||
d := targetTestDB(t)
|
||||
ic, res, rec := pgDialGate(t, d)
|
||||
srv, hits, port := pinnedServer(t, "rebound")
|
||||
rec.route("203.0.113.7:"+port, srv.Listener.Addr().String())
|
||||
rec.route("203.0.113.9:"+port, srv.Listener.Addr().String())
|
||||
res.set("app.example.com", "203.0.113.7")
|
||||
scope := taskScope(t, d, ic, time.Minute)
|
||||
ctx := WithTargetScope(t.Context(), scope)
|
||||
u := "http://app.example.com:" + port + "/"
|
||||
pinURL(t, d, ic, scope, u)
|
||||
mustPass(t, "the check", ic, scope, u)
|
||||
|
||||
res.set("app.example.com", "203.0.113.9")
|
||||
began := time.Now()
|
||||
_, err := get(ctx, pinnedClient(true), u)
|
||||
want := "TARGET_APPROVAL_PENDING: the connection to app.example.com:" + port + " was not opened: app.example.com now resolves to 203.0.113.9, outside pin v1 (203.0.113.7) of task " + scope.TaskID
|
||||
if err == nil || !strings.Contains(err.Error(), want) || !strings.Contains(err.Error(), "Retry the same call after the approval") {
|
||||
t.Fatalf("dial after the rebind: %v", err)
|
||||
}
|
||||
if elapsed := time.Since(began); elapsed > 10*time.Second {
|
||||
t.Fatalf("the dial waited %v", elapsed)
|
||||
}
|
||||
if got := rec.calls(); len(got) != 0 || hits.Load() != 0 {
|
||||
t.Fatalf("dialled %v, hits %d; want nothing", got, hits.Load())
|
||||
}
|
||||
detail, tgt := openTarget(t, d, scope)
|
||||
if tgt.Reason != "new_ip" || !slices.Equal(tgt.ResolvedIPs, []string{"203.0.113.9"}) || tgt.PinVersion != 1 ||
|
||||
!slices.Equal(tgt.PinnedIPs, []string{"203.0.113.7"}) || detail.ToolName != "WebFetch" || !strings.Contains(string(detail.ToolInput), `"dial": "app.example.com:`+port+`"`) {
|
||||
t.Fatalf("request = %+v, target %+v", detail, tgt)
|
||||
}
|
||||
|
||||
approveAll(t, d, ic, scope)
|
||||
if body, err := get(ctx, pinnedClient(true), u); err != nil || body != "rebound" {
|
||||
t.Fatalf("after the approval: %q, %v", body, err)
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"203.0.113.9:" + port}) {
|
||||
t.Fatalf("dialled %v, want the new address", got)
|
||||
}
|
||||
if ps := pins(t, d, scope); len(ps) != 2 || ps[0].Version != 2 || !slices.Equal(ps[0].PinnedIPs, []string{"203.0.113.7", "203.0.113.9"}) {
|
||||
t.Fatalf("pins = %+v, want v2 with both addresses", ps)
|
||||
}
|
||||
}
|
||||
|
||||
// One address outside the pin is enough: nothing is dialled, not even the
|
||||
// pinned one.
|
||||
func TestPinnedDialPartialOverlapNotReachable(t *testing.T) {
|
||||
d := targetTestDB(t)
|
||||
ic, res, rec := pgDialGate(t, d)
|
||||
res.set("app.example.com", "203.0.113.7")
|
||||
scope := taskScope(t, d, ic, time.Minute)
|
||||
pinURL(t, d, ic, scope, "https://app.example.com/")
|
||||
res.set("app.example.com", "203.0.113.7", "203.0.113.8")
|
||||
_, err := PinnedDialer("WebFetch", true)(WithTargetScope(t.Context(), scope), "tcp", "app.example.com:443")
|
||||
if err == nil || !strings.Contains(err.Error(), TargetApprovalPending) || len(rec.calls()) != 0 {
|
||||
t.Fatalf("dial: %v, dialled %v", err, rec.calls())
|
||||
}
|
||||
if _, tgt := openTarget(t, d, scope); tgt.Reason != "new_ip" || !slices.Equal(tgt.ResolvedIPs, []string{"203.0.113.7", "203.0.113.8"}) {
|
||||
t.Fatalf("request target %+v", tgt)
|
||||
}
|
||||
}
|
||||
|
||||
// A pin revoked between the check and the dial connects nowhere and asks again.
|
||||
func TestPinnedDialRevokedBetweenCheckAndDial(t *testing.T) {
|
||||
d := targetTestDB(t)
|
||||
ic, res, rec := pgDialGate(t, d)
|
||||
res.set("app.example.com", "203.0.113.7")
|
||||
scope := taskScope(t, d, ic, time.Minute)
|
||||
pinURL(t, d, ic, scope, "https://app.example.com/")
|
||||
mustPass(t, "the check", ic, scope, "https://app.example.com/")
|
||||
ps := pins(t, d, scope)
|
||||
if _, err := d.RevokeTargetPin(scope.dbRef(t), ps[0].ID); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
_, err := PinnedDialer("WebFetch", true)(WithTargetScope(t.Context(), scope), "tcp", "app.example.com:443")
|
||||
if err == nil || !strings.Contains(err.Error(), TargetApprovalPending) || !strings.Contains(err.Error(), "is not approved for task") || len(rec.calls()) != 0 {
|
||||
t.Fatalf("dial: %v, dialled %v", err, rec.calls())
|
||||
}
|
||||
if _, tgt := openTarget(t, d, scope); tgt.Reason != "no_pin" {
|
||||
t.Fatalf("request target %+v", tgt)
|
||||
}
|
||||
}
|
||||
|
||||
// A stored exemption is dialled at the addresses the dial resolved and found
|
||||
// public; the same name on a private address is void at the dial, and with no
|
||||
// pin it asks, connecting nowhere.
|
||||
func TestPinnedDialStoredExemptionDialsCheckedAddresses(t *testing.T) {
|
||||
d := targetTestDB(t)
|
||||
ic, res, rec := pgDialGate(t, d)
|
||||
srv, _, port := pinnedServer(t, "package")
|
||||
rec.route("198.51.100.20:"+port, srv.Listener.Addr().String())
|
||||
rec.route("10.0.0.5:"+port, srv.Listener.Addr().String())
|
||||
storedExemptions(t, d, db.TargetExemption{Host: "pkg.example", Port: atoiPort(t, port)})
|
||||
scope := taskScope(t, d, ic, time.Minute)
|
||||
ctx := WithTargetScope(t.Context(), scope)
|
||||
u := "http://pkg.example:" + port + "/"
|
||||
|
||||
res.set("pkg.example", "198.51.100.20")
|
||||
if body, err := get(ctx, pinnedClient(true), u); err != nil || body != "package" {
|
||||
t.Fatalf("exempt fetch: %q, %v", body, err)
|
||||
}
|
||||
res.set("pkg.example", "10.0.0.5")
|
||||
if _, err := get(ctx, pinnedClient(true), u); err == nil || !strings.Contains(err.Error(), TargetApprovalPending) {
|
||||
t.Fatalf("void exemption: %v", err)
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"198.51.100.20:" + port}) {
|
||||
t.Fatalf("dialled %v, want the checked public address only", got)
|
||||
}
|
||||
if _, tgt := openTarget(t, d, scope); !tgt.ExemptVoid || tgt.Reason != "no_pin" {
|
||||
t.Fatalf("request target %+v, want a void exemption", tgt)
|
||||
}
|
||||
}
|
||||
|
||||
// A pinned IP literal is dialled as written, never resolved; a name that
|
||||
// resolves to the same address is another target, not covered (D22).
|
||||
func TestPinnedDialIPLiteralPin(t *testing.T) {
|
||||
d := targetTestDB(t)
|
||||
ic, res, rec := pgDialGate(t, d)
|
||||
srv, _, port := pinnedServer(t, "literal")
|
||||
rec.route("198.51.100.7:"+port, srv.Listener.Addr().String())
|
||||
scope := taskScope(t, d, ic, time.Minute)
|
||||
ctx := WithTargetScope(t.Context(), scope)
|
||||
pinURL(t, d, ic, scope, "http://198.51.100.7:"+port+"/")
|
||||
if body, err := get(ctx, pinnedClient(true), "http://198.51.100.7:"+port+"/"); err != nil || body != "literal" {
|
||||
t.Fatalf("literal: %q, %v", body, err)
|
||||
}
|
||||
if res.total() != 0 {
|
||||
t.Fatalf("%d lookups for an IP literal", res.total())
|
||||
}
|
||||
res.set("lit.example", "198.51.100.7")
|
||||
if _, err := get(ctx, pinnedClient(true), "http://lit.example:"+port+"/"); err == nil || !strings.Contains(err.Error(), TargetApprovalPending) {
|
||||
t.Fatalf("a name on the pinned address: %v", err)
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"198.51.100.7:" + port}) {
|
||||
t.Fatalf("dialled %v", got)
|
||||
}
|
||||
}
|
||||
|
||||
// Port precedence as at the check: a (host, 0) pin covers any port; a
|
||||
// (host, 443) pin does not cover port 80.
|
||||
func TestPinnedDialPortPrecedence(t *testing.T) {
|
||||
d := targetTestDB(t)
|
||||
ic, res, rec := pgDialGate(t, d)
|
||||
srv, _, _ := pinnedServer(t, "any-port")
|
||||
rec.route("203.0.113.7:8443", srv.Listener.Addr().String())
|
||||
res.set("app.example.com", "203.0.113.7")
|
||||
res.set("web.example.com", "203.0.113.8")
|
||||
scope := taskScope(t, d, ic, time.Minute)
|
||||
ctx := WithTargetScope(t.Context(), scope)
|
||||
|
||||
// A URL of a scheme without a default port declares no port: its pin is (host, 0).
|
||||
pinURL(t, d, ic, scope, "ssh://app.example.com/")
|
||||
if ps := pins(t, d, scope); len(ps) != 1 || ps[0].Port != 0 {
|
||||
t.Fatalf("pins = %+v, want one on (app.example.com, 0)", ps)
|
||||
}
|
||||
pinURL(t, d, ic, scope, "https://web.example.com/")
|
||||
|
||||
conn, err := PinnedDialer("WebFetch", true)(ctx, "tcp", "app.example.com:8443")
|
||||
if err != nil {
|
||||
t.Fatalf("(host, 0) pin, port 8443: %v", err)
|
||||
}
|
||||
conn.Close()
|
||||
if _, err := PinnedDialer("WebFetch", true)(ctx, "tcp", "web.example.com:80"); err == nil || !strings.Contains(err.Error(), TargetApprovalPending) {
|
||||
t.Fatalf("(host, 443) pin, port 80: %v", err)
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"203.0.113.7:8443"}) {
|
||||
t.Fatalf("dialled %v", got)
|
||||
}
|
||||
if _, tgt := openTarget(t, d, scope); tgt.Host != "web.example.com" || tgt.Port != 80 || tgt.Reason != "no_pin" {
|
||||
t.Fatalf("request target %+v, want web.example.com:80", tgt)
|
||||
}
|
||||
}
|
||||
|
||||
// D-5: a redirect hop is checked by the redirect policy and then dialled
|
||||
// against the pin of the hop's (host, port), never the origin's.
|
||||
func TestRedirectHopDialledAgainstHopPinNotOrigin(t *testing.T) {
|
||||
d := targetTestDB(t)
|
||||
final, finalHits, finalPort := pinnedServer(t, "hop-b")
|
||||
start, _, startPort := hopRedirect(t, "http://b.example:"+finalPort+"/final")
|
||||
aURL, bURL := "http://a.example:"+startPort+"/start", "http://b.example:"+finalPort+"/"
|
||||
setup := func(t *testing.T, pinB bool) (context.Context, TargetScope, *fakeResolver, *dialRecorder) {
|
||||
ic, res, rec := pgDialGate(t, d)
|
||||
rec.route("203.0.113.1:"+startPort, start.Listener.Addr().String())
|
||||
rec.route("203.0.113.2:"+finalPort, final.Listener.Addr().String())
|
||||
// Were the hop dialled at the origin's address, it would reach b as well.
|
||||
rec.route("203.0.113.1:"+finalPort, final.Listener.Addr().String())
|
||||
res.set("a.example", "203.0.113.1")
|
||||
res.set("b.example", "203.0.113.2")
|
||||
scope := taskScope(t, d, ic, time.Minute)
|
||||
pinURL(t, d, ic, scope, aURL)
|
||||
if pinB {
|
||||
pinURL(t, d, ic, scope, bURL)
|
||||
}
|
||||
return WithTargetScope(t.Context(), scope), scope, res, rec
|
||||
}
|
||||
|
||||
t.Run("each hop at its own pin", func(t *testing.T) {
|
||||
ctx, _, _, rec := setup(t, true)
|
||||
before := finalHits.Load()
|
||||
if body, err := get(ctx, pinnedClient(true), aURL); err != nil || body != "hop-b" || finalHits.Load() != before+1 {
|
||||
t.Fatalf("redirect: %q, %v", body, err)
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"203.0.113.1:" + startPort, "203.0.113.2:" + finalPort}) {
|
||||
t.Fatalf("dialled %v", got)
|
||||
}
|
||||
})
|
||||
t.Run("hop resolving to the origin's pinned address", func(t *testing.T) {
|
||||
ctx, scope, res, rec := setup(t, true)
|
||||
// The cache still holds b's pinned answer: the redirect policy passes.
|
||||
res.set("b.example", "203.0.113.1")
|
||||
before := finalHits.Load()
|
||||
_, err := get(ctx, pinnedClient(true), aURL)
|
||||
if err == nil || !strings.Contains(err.Error(), "TARGET_APPROVAL_PENDING: the connection to b.example:"+finalPort+" was not opened") {
|
||||
t.Fatalf("hop: %v", err)
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"203.0.113.1:" + startPort}) || finalHits.Load() != before {
|
||||
t.Fatalf("dialled %v, b hits %d; want the origin only", got, finalHits.Load()-before)
|
||||
}
|
||||
if _, tgt := openTarget(t, d, scope); tgt.Host != "b.example" || tgt.Port != atoiPort(t, finalPort) || tgt.Reason != "new_ip" {
|
||||
t.Fatalf("request target %+v, want new_ip on b.example", tgt)
|
||||
}
|
||||
})
|
||||
t.Run("hop without a pin", func(t *testing.T) {
|
||||
ctx, scope, _, rec := setup(t, false)
|
||||
before := finalHits.Load()
|
||||
_, err := get(ctx, pinnedClient(true), aURL)
|
||||
if err == nil || !strings.Contains(err.Error(), "redirects to b.example:"+finalPort) || !strings.Contains(err.Error(), "not followed") {
|
||||
t.Fatalf("hop: %v", err)
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"203.0.113.1:" + startPort}) || finalHits.Load() != before {
|
||||
t.Fatalf("dialled %v; want the dialer never called for b", got)
|
||||
}
|
||||
if _, tgt := openTarget(t, d, scope); tgt.Host != "b.example" || tgt.Reason != "no_pin" {
|
||||
t.Fatalf("request target %+v", tgt)
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
// hopRedirect is a server that redirects every request to location.
|
||||
func hopRedirect(t *testing.T, location string) (*httptest.Server, *atomic.Int64, string) {
|
||||
t.Helper()
|
||||
srv, hits, key := hopServer(t, location)
|
||||
_, port, _ := net.SplitHostPort(key)
|
||||
return srv, hits, port
|
||||
}
|
||||
|
||||
// Two concurrent dials of one host whose address changed share one request:
|
||||
// both fail at once, one approval extends the pin, both retries connect.
|
||||
func TestDialMismatchOpensOneNewIPRequest(t *testing.T) {
|
||||
d := targetTestDB(t)
|
||||
ic, res, rec := pgDialGate(t, d)
|
||||
srv, _, port := pinnedServer(t, "shared")
|
||||
rec.route("203.0.113.9:"+port, srv.Listener.Addr().String())
|
||||
res.set("app.example.com", "203.0.113.7")
|
||||
scope := taskScope(t, d, ic, time.Minute)
|
||||
ctx := WithTargetScope(t.Context(), scope)
|
||||
u := "http://app.example.com:" + port + "/"
|
||||
pinURL(t, d, ic, scope, u)
|
||||
res.set("app.example.com", "203.0.113.9")
|
||||
|
||||
fetchBoth := func() []error {
|
||||
var wg sync.WaitGroup
|
||||
errs := make([]error, 2)
|
||||
for n := range errs {
|
||||
wg.Go(func() { _, errs[n] = get(ctx, pinnedClient(true), u) })
|
||||
}
|
||||
wg.Wait()
|
||||
return errs
|
||||
}
|
||||
for n, err := range fetchBoth() {
|
||||
if err == nil || !strings.Contains(err.Error(), TargetApprovalPending) {
|
||||
t.Fatalf("dial %d: %v", n, err)
|
||||
}
|
||||
}
|
||||
if ids := openRows(t, d, scope); len(ids) != 1 || allRows(t, d, scope) != 2 {
|
||||
t.Fatalf("open %v, %d request rows; want the approved one and one new_ip", ids, allRows(t, d, scope))
|
||||
}
|
||||
if len(rec.calls()) != 0 {
|
||||
t.Fatalf("dialled %v", rec.calls())
|
||||
}
|
||||
approveAll(t, d, ic, scope)
|
||||
for n, err := range fetchBoth() {
|
||||
if err != nil {
|
||||
t.Fatalf("retry %d: %v", n, err)
|
||||
}
|
||||
}
|
||||
if got := rec.calls(); len(got) != 2 || got[0] != "203.0.113.9:"+port || got[1] != got[0] {
|
||||
t.Fatalf("dialled %v", got)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,537 @@
|
||||
package intercept
|
||||
|
||||
import (
|
||||
"context"
|
||||
"crypto/tls"
|
||||
"errors"
|
||||
"io"
|
||||
"net"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"slices"
|
||||
"strings"
|
||||
"sync"
|
||||
"sync/atomic"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/Autumn-27/artex/db"
|
||||
)
|
||||
|
||||
// Step 2.1: the pinned dialer of the platform-owned HTTP clients. Without a
|
||||
// database: a dial that would open a request is covered by the PostgreSQL
|
||||
// tests in target_dial_pg_test.go.
|
||||
|
||||
// dialRecorder is a base dialer for tests. It records every address it is
|
||||
// asked to connect to, connects the routed ones (TEST-NET addresses) to local
|
||||
// listeners and loopback addresses to themselves, and refuses the rest.
|
||||
type dialRecorder struct {
|
||||
mu sync.Mutex
|
||||
routes map[string]string
|
||||
refuse map[string]bool
|
||||
dialed []string
|
||||
}
|
||||
|
||||
func newDialRecorder() *dialRecorder {
|
||||
return &dialRecorder{routes: map[string]string{}, refuse: map[string]bool{}}
|
||||
}
|
||||
|
||||
func (d *dialRecorder) route(addr, to string) {
|
||||
d.mu.Lock()
|
||||
d.routes[addr] = to
|
||||
d.mu.Unlock()
|
||||
}
|
||||
|
||||
func (d *dialRecorder) dial(ctx context.Context, network, addr string) (net.Conn, error) {
|
||||
d.mu.Lock()
|
||||
d.dialed = append(d.dialed, addr)
|
||||
to, ok := d.routes[addr]
|
||||
refused := d.refuse[addr]
|
||||
d.mu.Unlock()
|
||||
if !ok && strings.HasPrefix(addr, "127.0.0.1:") {
|
||||
to, ok = addr, true
|
||||
}
|
||||
if refused || !ok {
|
||||
return nil, &net.OpError{Op: "dial", Net: network, Err: errors.New("connection refused by the test dialer")}
|
||||
}
|
||||
return (&net.Dialer{}).DialContext(ctx, network, to)
|
||||
}
|
||||
|
||||
func (d *dialRecorder) calls() []string {
|
||||
d.mu.Lock()
|
||||
defer d.mu.Unlock()
|
||||
return slices.Clone(d.dialed)
|
||||
}
|
||||
|
||||
// pinnedServer is a listener that counts its requests; port is its port.
|
||||
func pinnedServer(t *testing.T, body string) (srv *httptest.Server, hits *atomic.Int64, port string) {
|
||||
t.Helper()
|
||||
hits = &atomic.Int64{}
|
||||
srv = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
hits.Add(1)
|
||||
_, _ = w.Write([]byte(body))
|
||||
}))
|
||||
t.Cleanup(srv.Close)
|
||||
_, port, _ = net.SplitHostPort(srv.Listener.Addr().String())
|
||||
return srv, hits, port
|
||||
}
|
||||
|
||||
// dialGate is a gate fixture whose base dialer is a dialRecorder.
|
||||
func dialGate(t *testing.T) (*gateFixture, *dialRecorder) {
|
||||
t.Helper()
|
||||
g := newGate(t)
|
||||
rec := newDialRecorder()
|
||||
g.ic.SetBaseDialer(rec.dial)
|
||||
return g, rec
|
||||
}
|
||||
|
||||
func (g *gateFixture) pin(host string, port int, ips ...string) *db.TargetPin {
|
||||
g.store.mu.Lock()
|
||||
defer g.store.mu.Unlock()
|
||||
p := &db.TargetPin{ID: int64(len(g.store.pins) + 1), Host: host, Port: port, Version: 1, Status: db.TargetPinActive, PinnedIPs: ips}
|
||||
g.store.pins = append(g.store.pins, p)
|
||||
return p
|
||||
}
|
||||
|
||||
// pinnedClient is a client built like the platform's: the redirect policy and
|
||||
// the pinned dialer, keep-alive off.
|
||||
func pinnedClient(scoped bool) *http.Client {
|
||||
tr := http.DefaultTransport.(*http.Transport).Clone()
|
||||
tr.Proxy = nil
|
||||
tr.DialContext = PinnedDialer("WebFetch", scoped)
|
||||
tr.DisableKeepAlives = true
|
||||
return &http.Client{Transport: tr, CheckRedirect: RedirectCheck("WebFetch")}
|
||||
}
|
||||
|
||||
func get(ctx context.Context, client *http.Client, rawURL string) (string, error) {
|
||||
req, err := http.NewRequestWithContext(ctx, http.MethodGet, rawURL, nil)
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
resp, err := client.Do(req)
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
b, err := io.ReadAll(resp.Body)
|
||||
return string(b), err
|
||||
}
|
||||
|
||||
// With the gate off, or with no scope in a client built without one, the dial
|
||||
// is the dial of today: the address as received, no lookup, no store access.
|
||||
func TestPinnedDialGateOffIsPlainDial(t *testing.T) {
|
||||
g, rec := dialGate(t)
|
||||
srv, hits, port := pinnedServer(t, "plain")
|
||||
rec.route("app.example.com:"+port, srv.Listener.Addr().String())
|
||||
g.res.set("app.example.com", "203.0.113.7")
|
||||
|
||||
conn, err := PinnedDialer("WebFetch", false)(context.Background(), "tcp", srv.Listener.Addr().String())
|
||||
if err != nil {
|
||||
t.Fatalf("no scope: %v", err)
|
||||
}
|
||||
conn.Close()
|
||||
for name, scope := range map[string]TargetScope{
|
||||
"no flag": {TaskID: "7", WaitBound: time.Minute, Interceptor: g.ic},
|
||||
"flag off": {TaskID: "7", Enabled: func() bool { return false }, WaitBound: time.Minute, Interceptor: g.ic},
|
||||
} {
|
||||
if body, err := get(WithTargetScope(context.Background(), scope), pinnedClient(true), "http://app.example.com:"+port+"/"); err != nil || body != "plain" {
|
||||
t.Fatalf("%s: %q, %v", name, body, err)
|
||||
}
|
||||
}
|
||||
if got := rec.calls(); len(got) != 2 || got[0] != "app.example.com:"+port || got[1] != got[0] {
|
||||
t.Fatalf("dialled %v, want the address as received", got)
|
||||
}
|
||||
if hits.Load() != 2 || g.store.reads != 0 || len(g.store.logged) != 0 || g.res.total() != 0 {
|
||||
t.Fatalf("hits=%d, %d store reads, %d rows, %d lookups; want none but the hits", hits.Load(), g.store.reads, len(g.store.logged), g.res.total())
|
||||
}
|
||||
}
|
||||
|
||||
// A client built for a scope never dials without one: a lost context value
|
||||
// fails closed, nothing is dialled.
|
||||
func TestPinnedDialScopeLostFailsClosed(t *testing.T) {
|
||||
srv, hits, _ := pinnedServer(t, "unbound")
|
||||
_, err := PinnedDialer("WebFetch", true)(context.Background(), "tcp", srv.Listener.Addr().String())
|
||||
if err == nil || !strings.Contains(err.Error(), TargetGateUnavailable) || !strings.Contains(err.Error(), "did not reach the connection") {
|
||||
t.Fatalf("dial without the scope: %v", err)
|
||||
}
|
||||
if _, err := get(context.Background(), pinnedClient(true), srv.URL); err == nil || !strings.Contains(err.Error(), TargetGateUnavailable) {
|
||||
t.Fatalf("fetch without the scope: %v", err)
|
||||
}
|
||||
if hits.Load() != 0 {
|
||||
t.Fatalf("%d requests reached the server", hits.Load())
|
||||
}
|
||||
}
|
||||
|
||||
// Every way the gate cannot decide fails closed with TARGET_GATE_UNAVAILABLE,
|
||||
// dials nothing, and logs one decided row where there is a store and a scope.
|
||||
func TestPinnedDialScopeUnreadableFailsClosed(t *testing.T) {
|
||||
for _, tc := range []struct {
|
||||
name string
|
||||
setup func(g *gateFixture)
|
||||
network, addr string
|
||||
rows int
|
||||
}{
|
||||
{"nil interceptor", func(g *gateFixture) { g.scope.Interceptor = nil }, "tcp", "app.example.com:443", 0},
|
||||
{"task id", func(g *gateFixture) { g.scope.TaskID = "seven" }, "tcp", "app.example.com:443", 0},
|
||||
{"rules", func(g *gateFixture) { g.store.fail["BlockRules"] = errors.New("down") }, "tcp", "app.example.com:443", 1},
|
||||
{"pins", func(g *gateFixture) { g.store.fail["ActivePins"] = errors.New("down") }, "tcp", "app.example.com:443", 1},
|
||||
{"exemptions", func(g *gateFixture) { g.store.fail["Exemptions"] = errors.New("down") }, "tcp", "app.example.com:443", 1},
|
||||
{"address", nil, "tcp", "app.example.com", 1},
|
||||
{"port", nil, "tcp", "app.example.com:0", 1},
|
||||
{"network", nil, "udp", "app.example.com:443", 1},
|
||||
} {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
g, rec := dialGate(t)
|
||||
g.res.set("app.example.com", "203.0.113.7")
|
||||
g.pin("app.example.com", 443, "203.0.113.7")
|
||||
if tc.setup != nil {
|
||||
tc.setup(g)
|
||||
}
|
||||
_, err := PinnedDialer("WebFetch", true)(g.ctx(), tc.network, tc.addr)
|
||||
if err == nil || !strings.Contains(err.Error(), TargetGateUnavailable) {
|
||||
t.Fatalf("dial: %v, want TARGET_GATE_UNAVAILABLE", err)
|
||||
}
|
||||
if got := rec.calls(); len(got) != 0 {
|
||||
t.Fatalf("dialled %v", got)
|
||||
}
|
||||
if got := g.store.outcomes(); len(got) != tc.rows || tc.rows == 1 && got[0] != "denied/gate_unavailable" {
|
||||
t.Fatalf("rows = %v, want %d gate_unavailable", got, tc.rows)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// A pinned name is dialled at the address the lookup returned and the pin
|
||||
// holds, never by the name.
|
||||
func TestPinnedDialConnectsOnlyToPinnedAddresses(t *testing.T) {
|
||||
g, rec := dialGate(t)
|
||||
srv, hits, port := pinnedServer(t, "pinned")
|
||||
rec.route("203.0.113.7:"+port, srv.Listener.Addr().String())
|
||||
g.res.set("app.example.com", "203.0.113.7")
|
||||
g.pin("app.example.com", atoiPort(t, port), "203.0.113.7")
|
||||
|
||||
if body, err := get(g.ctx(), pinnedClient(true), "http://app.example.com:"+port+"/"); err != nil || body != "pinned" {
|
||||
t.Fatalf("pinned fetch: %q, %v", body, err)
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"203.0.113.7:" + port}) || hits.Load() != 1 {
|
||||
t.Fatalf("dialled %v, hits %d; want the pinned address only", got, hits.Load())
|
||||
}
|
||||
}
|
||||
|
||||
// A name that does not resolve at the dial is blocked without a request (the
|
||||
// fixture has no database: a request would fail the test), nothing is dialled.
|
||||
func TestPinnedDialResolveFailureBlocksWithoutRequest(t *testing.T) {
|
||||
g, rec := dialGate(t)
|
||||
g.pin("app.example.com", 443, "203.0.113.7")
|
||||
g.res.mu.Lock()
|
||||
g.res.errs["app.example.com"] = errors.New("no such host")
|
||||
g.res.mu.Unlock()
|
||||
_, err := PinnedDialer("WebFetch", true)(g.ctx(), "tcp", "app.example.com:443")
|
||||
if err == nil || !strings.Contains(err.Error(), TargetResolveFailed) || !strings.Contains(err.Error(), "app.example.com:443") {
|
||||
t.Fatalf("dial: %v", err)
|
||||
}
|
||||
if got := g.store.outcomes(); len(got) != 1 || got[0] != "denied/resolve_failed" || len(rec.calls()) != 0 {
|
||||
t.Fatalf("rows %v, dialled %v", got, rec.calls())
|
||||
}
|
||||
}
|
||||
|
||||
// An asset block rule on an address the dial resolves wins over the pin.
|
||||
func TestPinnedDialBlockRuleOnDialAddress(t *testing.T) {
|
||||
g, rec := dialGate(t)
|
||||
g.pin("app.example.com", 443, "203.0.113.7", "203.0.113.8")
|
||||
g.res.set("app.example.com", "203.0.113.8")
|
||||
g.store.rules = []db.AssetInterceptRule{{Enabled: true, Kind: "exact_ip", Pattern: "203.0.113.8"}}
|
||||
_, err := PinnedDialer("WebFetch", true)(g.ctx(), "tcp", "app.example.com:443")
|
||||
if err == nil || !strings.Contains(err.Error(), TargetRuleBlocked) {
|
||||
t.Fatalf("dial: %v", err)
|
||||
}
|
||||
if got := g.store.outcomes(); len(got) != 1 || got[0] != "denied/rule_blocked" || len(rec.calls()) != 0 {
|
||||
t.Fatalf("rows %v, dialled %v", got, rec.calls())
|
||||
}
|
||||
}
|
||||
|
||||
// A derived exemption is dialled as received and never resolved, wherever its
|
||||
// name points: an LLM gateway on an internal address, the recording proxy on
|
||||
// loopback.
|
||||
func TestPinnedDialDerivedExemptionDialsByName(t *testing.T) {
|
||||
g, rec := dialGate(t)
|
||||
srv, hits, port := pinnedServer(t, "gateway")
|
||||
rec.route("llm.example:"+port, srv.Listener.Addr().String())
|
||||
g.res.set("llm.example", "10.0.0.5")
|
||||
proxy := srv.Listener.Addr().String()
|
||||
g.ic.SetDerivedExemptions(func() []string { return []string{"https://llm.example:" + port, "http://" + proxy} })
|
||||
|
||||
for _, addr := range []string{"llm.example:" + port, proxy} {
|
||||
conn, err := PinnedDialer("WebFetch", true)(g.ctx(), "tcp", addr)
|
||||
if err != nil {
|
||||
t.Fatalf("%s: %v", addr, err)
|
||||
}
|
||||
conn.Close()
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"llm.example:" + port, proxy}) || g.res.total() != 0 || hits.Load() != 0 {
|
||||
t.Fatalf("dialled %v, %d lookups; want the addresses as received and no lookup", got, g.res.total())
|
||||
}
|
||||
}
|
||||
|
||||
// A pin that is name-only for this connection, by its mark or because the
|
||||
// upstream proxy is set now, is dialled by name: the platform does not bind it.
|
||||
func TestPinnedDialNameOnlyPinDialsByName(t *testing.T) {
|
||||
for _, tc := range []struct {
|
||||
name string
|
||||
marked bool
|
||||
proxied bool
|
||||
}{{"marked pin", true, false}, {"upstream proxy now", false, true}} {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
g, rec := dialGate(t)
|
||||
srv, _, port := pinnedServer(t, "name-only")
|
||||
rec.route("app.example.com:"+port, srv.Listener.Addr().String())
|
||||
g.res.set("app.example.com", "203.0.113.9")
|
||||
g.pin("app.example.com", atoiPort(t, port), "203.0.113.7").NameOnlyEffective = tc.marked
|
||||
g.ic.SetUpstreamProxyCheck(func() bool { return tc.proxied })
|
||||
if body, err := get(g.ctx(), pinnedClient(true), "http://app.example.com:"+port+"/"); err != nil || body != "name-only" {
|
||||
t.Fatalf("fetch: %q, %v", body, err)
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"app.example.com:" + port}) {
|
||||
t.Fatalf("dialled %v, want the name", got)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// The dial reads its address as the check reads the URL: same key for case,
|
||||
// trailing dot, Unicode, IPv6 brackets and IPv4-mapped IPv6. net/http dials the
|
||||
// ASCII form of a Unicode name with the scheme's port written (S3).
|
||||
func TestPinnedDialNormalisesLikeTheCheck(t *testing.T) {
|
||||
for _, tc := range []struct{ rawURL, addr string }{
|
||||
{"https://App.Example.COM./x", "App.Example.COM.:443"},
|
||||
{"http://bücher.example/", "xn--bcher-kva.example:80"},
|
||||
{"https://[2001:DB8::1]:8443/", "[2001:db8::1]:8443"},
|
||||
{"http://[::ffff:192.0.2.1]/", "[::ffff:192.0.2.1]:80"},
|
||||
} {
|
||||
want, err := urlTarget(tc.rawURL)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
got, err := addrTarget("tcp", tc.addr)
|
||||
if err != nil || got != want {
|
||||
t.Errorf("%s: dial key %+v (%v), check key %+v", tc.addr, got, err, want)
|
||||
}
|
||||
}
|
||||
var dialled string
|
||||
tr := &http.Transport{DialContext: func(_ context.Context, _, addr string) (net.Conn, error) {
|
||||
dialled = addr
|
||||
return nil, errors.New("recorded")
|
||||
}}
|
||||
_, _ = (&http.Client{Transport: tr}).Get("http://bücher.example/")
|
||||
if dialled != "xn--bcher-kva.example:80" {
|
||||
t.Fatalf("net/http dialled %q, want the ASCII name and the scheme's port", dialled)
|
||||
}
|
||||
}
|
||||
|
||||
// Concurrent dials of one host share one lookup; the cached answer is not
|
||||
// used, and the cache holds the new answer afterwards.
|
||||
func TestPinnedDialFreshLookupCollapsed(t *testing.T) {
|
||||
g, rec := dialGate(t)
|
||||
srv, _, port := pinnedServer(t, "fresh")
|
||||
rec.route("203.0.113.7:"+port, srv.Listener.Addr().String())
|
||||
g.pin("app.example.com", atoiPort(t, port), "203.0.113.7")
|
||||
g.res.set("app.example.com", "203.0.113.9")
|
||||
if _, err := g.ic.resolve.lookup(context.Background(), "app.example.com", false); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
// The cache now holds 203.0.113.9, which no pin covers: a dial that used it
|
||||
// would open a request, which this fixture cannot.
|
||||
g.res.set("app.example.com", "203.0.113.7")
|
||||
hold := make(chan struct{})
|
||||
g.res.mu.Lock()
|
||||
g.res.hold = hold
|
||||
g.res.mu.Unlock()
|
||||
var wg sync.WaitGroup
|
||||
errs := make(chan error, 2)
|
||||
for range 2 {
|
||||
wg.Go(func() {
|
||||
conn, err := PinnedDialer("WebFetch", true)(g.ctx(), "tcp", "app.example.com:"+port)
|
||||
if err == nil {
|
||||
conn.Close()
|
||||
}
|
||||
errs <- err
|
||||
})
|
||||
}
|
||||
eventually(t, "the shared lookup", func() bool { return g.res.lookups("app.example.com") == 2 })
|
||||
time.Sleep(100 * time.Millisecond)
|
||||
close(hold)
|
||||
wg.Wait()
|
||||
close(errs)
|
||||
for err := range errs {
|
||||
if err != nil {
|
||||
t.Fatalf("dial: %v", err)
|
||||
}
|
||||
}
|
||||
if n := g.res.lookups("app.example.com"); n != 2 {
|
||||
t.Fatalf("%d lookups, want the cached one and one shared by both dials", n)
|
||||
}
|
||||
g.ic.resolve.mu.Lock()
|
||||
cached := g.ic.resolve.entries["app.example.com"].ips
|
||||
g.ic.resolve.mu.Unlock()
|
||||
if !slices.Equal(cached, []string{"203.0.113.7"}) || !slices.Equal(rec.calls(), []string{"203.0.113.7:" + port, "203.0.113.7:" + port}) {
|
||||
t.Fatalf("cache %v, dialled %v", cached, rec.calls())
|
||||
}
|
||||
}
|
||||
|
||||
// The compared addresses are tried in canonical order, the first that accepts
|
||||
// wins; tcp4 skips the IPv6 ones.
|
||||
func TestPinnedDialTriesAddressesInOrder(t *testing.T) {
|
||||
g, rec := dialGate(t)
|
||||
srv, _, port := pinnedServer(t, "second")
|
||||
rec.refuse["203.0.113.7:"+port] = true
|
||||
rec.route("203.0.113.8:"+port, srv.Listener.Addr().String())
|
||||
g.pin("app.example.com", atoiPort(t, port), "203.0.113.7", "203.0.113.8")
|
||||
g.res.set("app.example.com", "203.0.113.8", "203.0.113.7")
|
||||
if body, err := get(g.ctx(), pinnedClient(true), "http://app.example.com:"+port+"/"); err != nil || body != "second" {
|
||||
t.Fatalf("fetch: %q, %v", body, err)
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"203.0.113.7:" + port, "203.0.113.8:" + port}) {
|
||||
t.Fatalf("dialled %v", got)
|
||||
}
|
||||
|
||||
g, rec = dialGate(t)
|
||||
rec.route("203.0.113.8:"+port, srv.Listener.Addr().String())
|
||||
g.pin("app.example.com", atoiPort(t, port), "2001:db8::1", "203.0.113.8")
|
||||
g.res.set("app.example.com", "2001:db8::1", "203.0.113.8")
|
||||
conn, err := PinnedDialer("WebFetch", true)(g.ctx(), "tcp4", "app.example.com:"+port)
|
||||
if err != nil {
|
||||
t.Fatalf("tcp4: %v", err)
|
||||
}
|
||||
conn.Close()
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"203.0.113.8:" + port}) {
|
||||
t.Fatalf("tcp4 dialled %v, want the IPv4 address only", got)
|
||||
}
|
||||
}
|
||||
|
||||
// S1: the context net/http passes to DialContext carries the values of the
|
||||
// request's context. The client is built without a scope (scoped=false), so
|
||||
// only the request's context can send the dial down the pinned path.
|
||||
func TestPinnedDialSeesScopeInDialContext(t *testing.T) {
|
||||
g, rec := dialGate(t)
|
||||
srv, _, port := pinnedServer(t, "scoped")
|
||||
rec.route("203.0.113.7:"+port, srv.Listener.Addr().String())
|
||||
g.pin("app.example.com", atoiPort(t, port), "203.0.113.7")
|
||||
g.res.set("app.example.com", "203.0.113.7")
|
||||
if body, err := get(g.ctx(), pinnedClient(false), "http://app.example.com:"+port+"/"); err != nil || body != "scoped" {
|
||||
t.Fatalf("fetch: %q, %v", body, err)
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"203.0.113.7:" + port}) || g.res.lookups("app.example.com") != 1 {
|
||||
t.Fatalf("dialled %v after %d lookups, want the pinned path", got, g.res.lookups("app.example.com"))
|
||||
}
|
||||
}
|
||||
|
||||
// S4: dialling the pinned address keeps HTTPS verified against the name of
|
||||
// the request. A name the certificate does not hold fails verification.
|
||||
func TestPinnedDialHTTPSVerifiesName(t *testing.T) {
|
||||
g, rec := dialGate(t)
|
||||
srv := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { _, _ = w.Write([]byte("verified")) }))
|
||||
t.Cleanup(srv.Close)
|
||||
_, port, _ := net.SplitHostPort(srv.Listener.Addr().String())
|
||||
rec.route("203.0.113.7:"+port, srv.Listener.Addr().String())
|
||||
// httptest's certificate holds example.com.
|
||||
for _, host := range []string{"example.com", "other.example"} {
|
||||
g.pin(host, atoiPort(t, port), "203.0.113.7")
|
||||
g.res.set(host, "203.0.113.7")
|
||||
}
|
||||
client := pinnedClient(true)
|
||||
client.Transport.(*http.Transport).TLSClientConfig = &tls.Config{RootCAs: srv.Client().Transport.(*http.Transport).TLSClientConfig.RootCAs}
|
||||
if body, err := get(g.ctx(), client, "https://example.com:"+port+"/"); err != nil || body != "verified" {
|
||||
t.Fatalf("https by the pinned address: %q, %v", body, err)
|
||||
}
|
||||
_, err := get(g.ctx(), client, "https://other.example:"+port+"/")
|
||||
var verr *tls.CertificateVerificationError
|
||||
if !errors.As(err, &verr) {
|
||||
t.Fatalf("a name the certificate does not hold: %v, want a verification error", err)
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"203.0.113.7:" + port, "203.0.113.7:" + port}) {
|
||||
t.Fatalf("dialled %v", got)
|
||||
}
|
||||
}
|
||||
|
||||
// S6: with keep-alive off (as Norma sets it on a transport with a dialer, and
|
||||
// the custom tool on its own), a second fetch of one client dials again: a pin
|
||||
// changed in between applies to it.
|
||||
func TestPinnedDialNoReuseAcrossCalls(t *testing.T) {
|
||||
g, rec := dialGate(t)
|
||||
srv, _, port := pinnedServer(t, "again")
|
||||
rec.route("203.0.113.7:"+port, srv.Listener.Addr().String())
|
||||
rec.route("203.0.113.8:"+port, srv.Listener.Addr().String())
|
||||
p := atoiPort(t, port)
|
||||
g.pin("app.example.com", p, "203.0.113.7")
|
||||
g.res.set("app.example.com", "203.0.113.7")
|
||||
client := pinnedClient(true)
|
||||
u := "http://app.example.com:" + port + "/"
|
||||
if _, err := get(g.ctx(), client, u); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
g.store.revoke("app.example.com", p)
|
||||
g.pin("app.example.com", p, "203.0.113.8")
|
||||
g.res.set("app.example.com", "203.0.113.8")
|
||||
if _, err := get(g.ctx(), client, u); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{"203.0.113.7:" + port, "203.0.113.8:" + port}) {
|
||||
t.Fatalf("dialled %v, want a new dial under the new pin", got)
|
||||
}
|
||||
}
|
||||
|
||||
// S5: the redirected request keeps the original request's context, so the
|
||||
// hop's redirect check and the hop's dial read the same target scope.
|
||||
func TestRedirectContextCarriesScope(t *testing.T) {
|
||||
g, rec := dialGate(t)
|
||||
final, finalHits, finalKey := hopServer(t, "")
|
||||
start, _, startKey := hopServer(t, final.URL+"/final")
|
||||
for _, key := range []string{startKey, finalKey} {
|
||||
host, port, _ := net.SplitHostPort(key)
|
||||
g.pin(host, atoiPort(t, port), host)
|
||||
}
|
||||
var hopScope TargetScope
|
||||
var hopOK bool
|
||||
client := pinnedClient(true)
|
||||
policy := client.CheckRedirect
|
||||
client.CheckRedirect = func(req *http.Request, via []*http.Request) error {
|
||||
hopScope, hopOK = TargetScopeFromContext(req.Context())
|
||||
return policy(req, via)
|
||||
}
|
||||
if body, err := get(g.ctx(), client, start.URL+"/start"); err != nil || body != "hop-reached" || finalHits.Load() != 1 {
|
||||
t.Fatalf("redirect: %q, %v", body, err)
|
||||
}
|
||||
if !hopOK || hopScope.TaskID != g.scope.TaskID || hopScope.Interceptor != g.ic {
|
||||
t.Fatalf("hop context scope = %+v (%v), want the scope of the call", hopScope, hopOK)
|
||||
}
|
||||
if got := rec.calls(); !slices.Equal(got, []string{startKey, finalKey}) {
|
||||
t.Fatalf("dialled %v, want the origin then the hop through the pinned path", got)
|
||||
}
|
||||
}
|
||||
|
||||
// D-2: a request raised while the upstream proxy is set says the platform does
|
||||
// not bind the connection.
|
||||
func TestNameOnlyReasonSaysConnectionNotBound(t *testing.T) {
|
||||
scope := TargetScope{TaskID: "7"}
|
||||
r := target("app.example.com", 443, "203.0.113.7")
|
||||
const sentence = "This approval is name-only. The platform does not bind the connection to these addresses."
|
||||
if got := targetReason(scope, r, nil, true); !strings.Contains(got, sentence) {
|
||||
t.Fatalf("name-only reason = %q", got)
|
||||
}
|
||||
if got := targetReason(scope, r, nil, false); strings.Contains(got, "does not bind") {
|
||||
t.Fatalf("reason without the upstream proxy = %q", got)
|
||||
}
|
||||
}
|
||||
|
||||
// D-2: the first-use row of an unmarked pin used while the upstream proxy is
|
||||
// set records the pin as name-only.
|
||||
func TestPinUsedRecordsEffectiveNameOnly(t *testing.T) {
|
||||
g := newGate(t)
|
||||
g.res.set("app.example.com", "203.0.113.7")
|
||||
g.pin("app.example.com", 443, "203.0.113.7")
|
||||
g.ic.SetUpstreamProxyCheck(func() bool { return true })
|
||||
g.passes("pinned", g.fetch(appURL))
|
||||
if got := g.store.outcomes(); len(got) != 1 || got[0] != "allowed/pin_match" || !g.store.logged[0].Audit.Targets[0].NameOnlyEffective {
|
||||
t.Fatalf("rows %v, target %+v; want a name-only first use", got, g.store.logged[0].Audit.Targets[0])
|
||||
}
|
||||
}
|
||||
@@ -73,8 +73,13 @@ func (i *Interceptor) SetDerivedExemptions(f func() []string) {
|
||||
i.mu.Unlock()
|
||||
}
|
||||
|
||||
// proxyPorts are the ports net/http dials for a proxy URL without one, for the
|
||||
// schemes schemePorts has no default for.
|
||||
var proxyPorts = map[string]int{"socks5": 1080, "socks5h": 1080}
|
||||
|
||||
// DerivedExemptions returns the exemptions derived from the configuration, as
|
||||
// exact host and port. An endpoint without a port is not listed.
|
||||
// exact host and port. An endpoint without a port gets the one net/http dials
|
||||
// (the scheme's default, 1080 for socks5); one with neither is not listed.
|
||||
func (i *Interceptor) DerivedExemptions() []db.TargetExemption {
|
||||
i.mu.RLock()
|
||||
f := i.derivedExempt
|
||||
@@ -86,6 +91,9 @@ func (i *Interceptor) DerivedExemptions() []db.TargetExemption {
|
||||
seen := map[string]bool{}
|
||||
for _, raw := range f() {
|
||||
t, ok := NormalizeTarget(raw)
|
||||
if scheme, _, found := strings.Cut(strings.TrimSpace(raw), "://"); ok && found && t.Port == 0 {
|
||||
t.Port = proxyPorts[strings.ToLower(scheme)]
|
||||
}
|
||||
if !ok || t.Port == 0 || t.Kind == TargetCIDR || seen[db.TargetKey(t.Host, t.Port)] {
|
||||
continue
|
||||
}
|
||||
|
||||
@@ -1,6 +1,11 @@
|
||||
package intercept
|
||||
|
||||
import "testing"
|
||||
import (
|
||||
"slices"
|
||||
"testing"
|
||||
|
||||
"github.com/Autumn-27/artex/db"
|
||||
)
|
||||
|
||||
// An operator may exempt a private unicast IP literal, never a loopback,
|
||||
// link-local (cloud metadata), unspecified or multicast one.
|
||||
@@ -27,3 +32,20 @@ func TestValidateExemptionHost(t *testing.T) {
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// A proxy endpoint configured without a port is exempt on the port net/http
|
||||
// dials for it (OPEN-9): the scheme's default, 1080 for socks5. An endpoint
|
||||
// with no port and no known scheme is not listed.
|
||||
func TestDerivedExemptionsDefaultProxyPort(t *testing.T) {
|
||||
ic := New(nil)
|
||||
ic.SetDerivedExemptions(func() []string {
|
||||
return []string{"socks5://egress.example.net", "SOCKS5H://dns.example.net", "http://proxy.example.net", "https://gw.example.net", "bare.example.net", "socks5://set.example.net:9050"}
|
||||
})
|
||||
want := []db.TargetExemption{
|
||||
{Host: "egress.example.net", Port: 1080}, {Host: "dns.example.net", Port: 1080}, {Host: "proxy.example.net", Port: 80},
|
||||
{Host: "gw.example.net", Port: 443}, {Host: "set.example.net", Port: 9050},
|
||||
}
|
||||
if got := ic.DerivedExemptions(); !slices.Equal(got, want) {
|
||||
t.Fatalf("derived exemptions = %+v, want %+v", got, want)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -62,6 +62,13 @@ func toolSet(names ...string) map[string]bool {
|
||||
// names on its own. The gate detects a declared target; it does not prevent an
|
||||
// undeclared connection.
|
||||
func ExtractTargets(toolName string, input []byte) []Target {
|
||||
return extractDeclared(toolName, input).targets
|
||||
}
|
||||
|
||||
// extractDeclared reads what a tool call declares: its targets, as
|
||||
// ExtractTargets returns them, and the URLs it writes, as written, for the URL
|
||||
// block rules. A URL is kept only when it names a target.
|
||||
func extractDeclared(toolName string, input []byte) targetList {
|
||||
if toolName == executeExtraTool {
|
||||
var in struct {
|
||||
ToolName string `json:"tool_name"`
|
||||
@@ -72,13 +79,15 @@ func ExtractTargets(toolName string, input []byte) []Target {
|
||||
}
|
||||
}
|
||||
if noTargetTools[toolName] {
|
||||
return nil
|
||||
return targetList{}
|
||||
}
|
||||
var out targetList
|
||||
switch toolName {
|
||||
case "WebFetch":
|
||||
if t, ok := NormalizeTarget(declaredFields(input).URL); ok {
|
||||
u := declaredFields(input).URL
|
||||
if t, ok := NormalizeTarget(u); ok {
|
||||
out.add(t)
|
||||
out.urls = append(out.urls, strings.TrimSpace(u))
|
||||
}
|
||||
case "Bash", "shell_open", "Monitor":
|
||||
out.scan(declaredFields(input).Command)
|
||||
@@ -87,7 +96,7 @@ func ExtractTargets(toolName string, input []byte) []Target {
|
||||
default:
|
||||
out.scanStrings(input)
|
||||
}
|
||||
return out.targets
|
||||
return out
|
||||
}
|
||||
|
||||
// declaredInput holds the fields of the built-in tools that carry a target.
|
||||
@@ -109,6 +118,7 @@ func declaredFields(input []byte) declaredInput {
|
||||
type targetList struct {
|
||||
targets []Target
|
||||
seen map[Target]bool
|
||||
urls []string // the URLs that name a target, as written
|
||||
}
|
||||
|
||||
func (l *targetList) add(t Target) {
|
||||
@@ -207,6 +217,10 @@ func (l *targetList) scan(s string) {
|
||||
found = true
|
||||
}
|
||||
}
|
||||
if found {
|
||||
// The whole token, path and query included, from the original string.
|
||||
l.urls = append(l.urls, s[m[0]:m[1]])
|
||||
}
|
||||
// The scheme and what follows the authority are never read again. An
|
||||
// authority that named no host is: an address written in it still counts.
|
||||
blank(m[0], m[4])
|
||||
|
||||
+72
-17
@@ -93,12 +93,12 @@ func (i *Interceptor) CheckTargets(ctx context.Context, scope TargetScope, toolN
|
||||
if scope.Enabled == nil || !scope.Enabled() {
|
||||
return nil, TargetResult{}
|
||||
}
|
||||
targets := ExtractTargets(toolName, input)
|
||||
if len(targets) == 0 {
|
||||
declared := extractDeclared(toolName, input)
|
||||
if len(declared.targets) == 0 {
|
||||
return nil, TargetResult{}
|
||||
}
|
||||
c := &targetCheck{i: i, ctx: ctx, scope: scope, tool: toolName, input: input}
|
||||
return c.run(targets)
|
||||
c := &targetCheck{i: i, ctx: ctx, scope: scope, tool: toolName, input: input, urls: declared.urls}
|
||||
return c.run(declared.targets)
|
||||
}
|
||||
|
||||
// targetCheck is one run of the gate decision.
|
||||
@@ -109,8 +109,24 @@ type targetCheck struct {
|
||||
ref db.TargetScopeRef
|
||||
tool string
|
||||
input []byte
|
||||
urls []string // the URLs the call declares, as written, for the URL block rules
|
||||
// redirectFrom is the origin (host:port) of a redirect hop; empty for a call.
|
||||
redirectFrom string
|
||||
// fresh makes every lookup skip the cache: the decision of a connection
|
||||
// (dialTarget) compares the answer it is about to dial.
|
||||
fresh bool
|
||||
// checked is what the run decided about each target, read by dialTarget.
|
||||
checked []*checkedTarget
|
||||
}
|
||||
|
||||
// What let a target pass, recorded in checkedTarget.cover.
|
||||
const (
|
||||
coverDerived = "derived" // an exemption derived from the configuration
|
||||
coverStored = "stored" // a stored exemption that holds
|
||||
coverPin = "pin" // a pin that holds every resolved address
|
||||
coverNameOnly = "name_only" // a pin that is name-only for this call
|
||||
)
|
||||
|
||||
// checkedTarget is one target of the call and what the gate learned about it.
|
||||
type checkedTarget struct {
|
||||
Target
|
||||
@@ -119,6 +135,7 @@ type checkedTarget struct {
|
||||
resolvedAt time.Time
|
||||
err error // the name did not resolve
|
||||
exemptVoid bool
|
||||
cover string // what let the target pass; empty when nothing did
|
||||
}
|
||||
|
||||
func (t Target) String() string {
|
||||
@@ -146,23 +163,48 @@ func (c *targetCheck) run(targets []Target) ([]TargetRequest, TargetResult) {
|
||||
return c.block(TargetGateUnavailable, "gate_unavailable", first, "the exemption list could not be read: "+err.Error())
|
||||
}
|
||||
|
||||
// Block rules come first, on the name and on what it resolves to: an exempt
|
||||
// or pinned host that matches one is blocked. A name the configuration
|
||||
// exempts is never resolved.
|
||||
// Block rules come first, and an exempt or pinned host that matches one is
|
||||
// blocked. They are matched on what the call declares before anything is
|
||||
// resolved: a hit there costs no lookup, for any target of the call.
|
||||
//
|
||||
// URL rules (exact_url, fuzzy_url) are matched once per decision, on the
|
||||
// URLs as the call writes them. That is a known limit: exact_url compares
|
||||
// the string as written, so another case, encoding (%2F), a trailing slash,
|
||||
// an added query or /./ does not match, and fuzzy_url is evaded by encoding
|
||||
// the substring; a command can also build its URL at run time. To keep an
|
||||
// agent away from a host, a domain, IP or CIDR rule is the one to write.
|
||||
if rule, u, hit := db.MatchAssetInterceptRules(rules, nil, nil, c.urls); hit {
|
||||
ct := &checkedTarget{Target: targets[0]}
|
||||
if t, ok := NormalizeTarget(u); ok {
|
||||
ct.Target = t
|
||||
}
|
||||
return c.block(TargetRuleBlocked, "rule_blocked", ct, fmt.Sprintf("%s is blocked by an asset rule. %s", u, rule.Reason()))
|
||||
}
|
||||
// Then the declared form of every target: the name as written, the IP
|
||||
// literal, the range.
|
||||
checked := make([]*checkedTarget, len(targets))
|
||||
c.checked = checked
|
||||
for n, t := range targets {
|
||||
ct := &checkedTarget{Target: t}
|
||||
checked[n] = ct
|
||||
switch {
|
||||
case t.Kind != TargetDomain:
|
||||
if t.Kind != TargetDomain {
|
||||
ct.ips, ct.resolver, ct.resolvedAt = []string{t.Host}, literalResolver, time.Now().UTC()
|
||||
case !ex.derived[db.TargetKey(t.Host, t.Port)]:
|
||||
c.resolve(ct, false)
|
||||
}
|
||||
if rule, hit := blockRule(rules, ct); hit {
|
||||
return c.block(TargetRuleBlocked, "rule_blocked", ct, fmt.Sprintf("%s is blocked by an asset rule. %s", t, rule.Reason()))
|
||||
}
|
||||
}
|
||||
// Only then are the names resolved, and the rules matched on the addresses.
|
||||
// A name the configuration exempts is never resolved.
|
||||
for _, ct := range checked {
|
||||
if ct.Kind != TargetDomain || ex.derived[db.TargetKey(ct.Host, ct.Port)] {
|
||||
continue
|
||||
}
|
||||
c.resolve(ct, c.fresh)
|
||||
if rule, hit := blockRule(rules, ct); hit {
|
||||
return c.block(TargetRuleBlocked, "rule_blocked", ct, fmt.Sprintf("%s is blocked by an asset rule. %s", ct.Target, rule.Reason()))
|
||||
}
|
||||
}
|
||||
|
||||
i.mu.RLock()
|
||||
proxied := i.upstreamProxy
|
||||
@@ -177,11 +219,13 @@ func (c *targetCheck) run(targets []Target) ([]TargetRequest, TargetResult) {
|
||||
for _, ct := range checked {
|
||||
key := db.TargetKey(ct.Host, ct.Port)
|
||||
if ex.derived[key] {
|
||||
ct.cover = coverDerived
|
||||
uses = append(uses, func() { c.exemptUsed(ct, ex.digest) })
|
||||
continue
|
||||
}
|
||||
if ex.stored[key] {
|
||||
if exemptionHolds(ct) {
|
||||
ct.cover = coverStored
|
||||
uses = append(uses, func() { c.exemptUsed(ct, ex.digest) })
|
||||
continue
|
||||
}
|
||||
@@ -196,9 +240,10 @@ func (c *targetCheck) run(targets []Target) ([]TargetRequest, TargetResult) {
|
||||
return c.block(TargetGateUnavailable, "gate_unavailable", ct, "the pins could not be read: "+err.Error())
|
||||
}
|
||||
pin := coveringPin(pins, ct.ips, nameOnly)
|
||||
if pin == nil && ct.Kind == TargetDomain {
|
||||
if pin == nil && ct.Kind == TargetDomain && !c.fresh {
|
||||
// A request is about to be raised: the addresses a human reads and
|
||||
// pins are resolved now, never taken from the cache.
|
||||
// pins are resolved now, never taken from the cache. A fresh run
|
||||
// already has them.
|
||||
if c.resolve(ct, true); ct.err != nil {
|
||||
return c.block(TargetResolveFailed, "resolve_failed", ct, c.resolveFailure(ct))
|
||||
}
|
||||
@@ -208,7 +253,11 @@ func (c *targetCheck) run(targets []Target) ([]TargetRequest, TargetResult) {
|
||||
pin = coveringPin(pins, ct.ips, nameOnly)
|
||||
}
|
||||
if pin != nil {
|
||||
uses = append(uses, func() { c.pinUsed(ct, pin) })
|
||||
ct.cover = coverPin
|
||||
if nameOnly || pin.NameOnlyEffective {
|
||||
ct.cover = coverNameOnly
|
||||
}
|
||||
uses = append(uses, func() { c.pinUsed(ct, pin, nameOnly) })
|
||||
continue
|
||||
}
|
||||
req := TargetRequest{Host: ct.Host, Port: ct.Port, Kind: ct.Kind, ResolvedIPs: ct.ips,
|
||||
@@ -278,6 +327,9 @@ func (c *targetCheck) log(status, reason, configDigest string, targets ...db.Int
|
||||
// The row records that a pin or an exemption was used, not this one call.
|
||||
audit.ExecutionStatus = "unknown"
|
||||
}
|
||||
for n := range targets {
|
||||
targets[n].RedirectFrom = c.redirectFrom
|
||||
}
|
||||
audit.Targets = targets
|
||||
_, agentName := taskInfoFromCtx(c.ctx)
|
||||
_ = c.i.targets.LogDecision(db.TargetDecision{Scope: c.ref, AgentName: agentName, ToolName: c.tool,
|
||||
@@ -296,17 +348,20 @@ func (c *targetCheck) exemptUsed(ct *checkedTarget, digest string) {
|
||||
}
|
||||
|
||||
// pinUsed logs the first call of this process that a pin version covers.
|
||||
func (c *targetCheck) pinUsed(ct *checkedTarget, pin *db.TargetPin) {
|
||||
// nameOnly is whether the upstream proxy made every pin name-only for the call:
|
||||
// the row records the effective state, not only the pin's mark.
|
||||
func (c *targetCheck) pinUsed(ct *checkedTarget, pin *db.TargetPin, nameOnly bool) {
|
||||
if _, seen := c.i.firstUse.LoadOrStore(fmt.Sprintf("pin|%d", pin.ID), true); seen {
|
||||
return
|
||||
}
|
||||
t := ct.audit("pin_match")
|
||||
t.PinID, t.PinVersion, t.PinnedIPs, t.NameOnlyEffective = pin.ID, pin.Version, pin.PinnedIPs, pin.NameOnlyEffective
|
||||
t.PinID, t.PinVersion, t.PinnedIPs, t.NameOnlyEffective = pin.ID, pin.Version, pin.PinnedIPs, pin.NameOnlyEffective || nameOnly
|
||||
c.log("allowed", fmt.Sprintf("Target %s is covered by pin v%d of %s.", ct.Target, pin.Version, c.scope.scopeName()), "", t)
|
||||
}
|
||||
|
||||
// blockRule matches the asset block rules against a target: its name, and its
|
||||
// addresses. A range is matched as written and by its network address.
|
||||
// addresses. A range is matched as written and by its network address. URL
|
||||
// rules are not matched here: run matches them once, on the declared URLs.
|
||||
func blockRule(rules []db.AssetInterceptRule, ct *checkedTarget) (db.AssetInterceptRule, bool) {
|
||||
var domains []string
|
||||
ips := ct.ips
|
||||
|
||||
@@ -0,0 +1,107 @@
|
||||
package intercept
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"net/http"
|
||||
)
|
||||
|
||||
// The HTTP clients the platform owns (WebFetch and the custom http tool)
|
||||
// follow redirects. The hook and the rendered-URL gate decide on the URL a call
|
||||
// names; a redirect sends the client to a URL nobody checked. RedirectCheck is
|
||||
// the redirect policy of those clients: the client asks it before it follows
|
||||
// each hop, and the hop goes through the same target decision as the call, on
|
||||
// the URL the client is about to request: the asset block rules on that URL and
|
||||
// on its target, before any lookup, then exemptions, resolution and pins.
|
||||
|
||||
// maxRedirects is the limit net/http applies to a client without a redirect
|
||||
// policy. Setting a policy replaces it, so RedirectCheck restates it, with the
|
||||
// same error text.
|
||||
const maxRedirects = 10
|
||||
|
||||
// RedirectCheck returns the redirect policy (http.Client.CheckRedirect) of a
|
||||
// platform-owned client run by the tool toolName. Everything it needs comes
|
||||
// from the context of the request, which net/http keeps on every hop: the
|
||||
// target scope of the session and the Interceptor that owns its gate.
|
||||
//
|
||||
// With the gate off, or with no scope in the context (the operator's test
|
||||
// endpoint), it only applies the limit of 10 hops: nothing is parsed, resolved,
|
||||
// read or written, and the client behaves as with the default policy.
|
||||
//
|
||||
// A hop no pin or exemption covers is not followed, and the policy never waits:
|
||||
// the fetch has its own deadline, which a human decision does not fit in. The
|
||||
// request row for the hop's target is found or created (it is durable, so an
|
||||
// approval given later lets the retried call follow), and the call fails at
|
||||
// once with TARGET_APPROVAL_PENDING. A block rule, a failed lookup or a hop
|
||||
// whose target cannot be read fails the call with its block code, and opens no
|
||||
// request.
|
||||
func RedirectCheck(toolName string) func(req *http.Request, via []*http.Request) error {
|
||||
return func(req *http.Request, via []*http.Request) error {
|
||||
if len(via) >= maxRedirects {
|
||||
return errors.New("stopped after 10 redirects")
|
||||
}
|
||||
ctx := req.Context()
|
||||
scope, on := renderedScope(ctx)
|
||||
if !on {
|
||||
return nil
|
||||
}
|
||||
return checkRedirectHop(ctx, scope, toolName, req.URL.String(), via[len(via)-1].URL.String())
|
||||
}
|
||||
}
|
||||
|
||||
// checkRedirectHop runs the gate decision on one hop, from the URL that
|
||||
// redirected (from) to the URL the client will request (hop).
|
||||
func checkRedirectHop(ctx context.Context, scope TargetScope, toolName, hop, from string) error {
|
||||
input, _ := json.Marshal(map[string]string{"url": hop, "redirect_from": from})
|
||||
blocked := func(res TargetResult) error {
|
||||
return &redirectError{res: res, from: from, hop: hop, scope: scope.scopeName()}
|
||||
}
|
||||
t, err := urlTarget(hop)
|
||||
if err != nil {
|
||||
return blocked(undeterminedTarget(ctx, scope, toolName, input, "the target of the redirect could not be read ("+err.Error()+")"))
|
||||
}
|
||||
i := scope.Interceptor
|
||||
if i == nil {
|
||||
return blocked(TargetResult{Code: TargetGateUnavailable, Host: t.Host, Port: t.Port, Reason: "the session's target scope carries no gate"})
|
||||
}
|
||||
var origin string
|
||||
if o, err := urlTarget(from); err == nil {
|
||||
origin = o.String()
|
||||
}
|
||||
ctx = WithCall(ctx, toolName, input)
|
||||
c := &targetCheck{i: i, ctx: ctx, scope: scope, tool: toolName, input: input, urls: []string{hop}, redirectFrom: origin}
|
||||
unpinned, res := c.run([]Target{t})
|
||||
if res.Code == "" && len(unpinned) > 0 {
|
||||
// Wait bound 0: the request is found or created, and the call does not wait.
|
||||
scope.WaitBound = 0
|
||||
for n := range unpinned {
|
||||
unpinned[n].RedirectFrom = origin
|
||||
}
|
||||
res = i.RequestTargets(ctx, scope, toolName, input, unpinned, nil)
|
||||
}
|
||||
if res.Code == "" {
|
||||
return nil
|
||||
}
|
||||
return blocked(res)
|
||||
}
|
||||
|
||||
// redirectError is what the client returns when a hop is not followed. Both
|
||||
// tools hand the client error to the model as the tool result.
|
||||
type redirectError struct {
|
||||
res TargetResult
|
||||
from, hop, scope string
|
||||
}
|
||||
|
||||
func (e *redirectError) Error() string {
|
||||
target := e.hop
|
||||
if e.res.Host != "" {
|
||||
target = targetName(TargetRequest{Host: e.res.Host, Port: e.res.Port})
|
||||
}
|
||||
msg := "[ARTEX platform control, not target defense] " + e.res.Code + ": " + e.from + " redirects to " + target
|
||||
if e.res.Code == TargetApprovalPending {
|
||||
return msg + ", which is not approved for " + e.scope + ". The redirect was not followed and an approval was requested. " +
|
||||
"Retry the same call after the approval. Do not fetch the redirect target directly or with another tool."
|
||||
}
|
||||
return msg + ": " + e.res.Reason + ". The redirect was not followed. Do not fetch the redirect target directly or with another tool."
|
||||
}
|
||||
@@ -0,0 +1,95 @@
|
||||
package intercept
|
||||
|
||||
import (
|
||||
"strconv"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
// Step 1.9 against PostgreSQL: a hop no pin covers opens the durable request
|
||||
// and fails the call at once; an approval lets the same call follow.
|
||||
|
||||
// A hop to an unpinned target is not followed: the redirect target receives
|
||||
// nothing, exactly one request row is opened for it, and the call fails with
|
||||
// TARGET_APPROVAL_PENDING without waiting, although the scope would wait five
|
||||
// minutes at the hook. The same call again attaches to that row. After the
|
||||
// approval it follows.
|
||||
func TestRedirectToUnpinnedHostNotFollowed(t *testing.T) {
|
||||
d := targetTestDB(t)
|
||||
ic, res := pgGate(t, d)
|
||||
scope := taskScope(t, d, ic, 5*time.Minute)
|
||||
ctx := WithTargetScope(t.Context(), scope)
|
||||
final, finalHits, finalKey := hopServer(t, "")
|
||||
start, startHits, startKey := hopServer(t, final.URL+"/final")
|
||||
|
||||
began := time.Now()
|
||||
_, err := gatedFetch(ctx, start.URL+"/start")
|
||||
if err == nil || !strings.Contains(err.Error(), TargetApprovalPending) ||
|
||||
!strings.Contains(err.Error(), start.URL+"/start redirects to "+finalKey) || !strings.Contains(err.Error(), "not followed") {
|
||||
t.Fatalf("unpinned hop: %v", err)
|
||||
}
|
||||
if elapsed := time.Since(began); elapsed > 10*time.Second {
|
||||
t.Fatalf("the hop waited %v", elapsed)
|
||||
}
|
||||
if startHits.Load() != 1 || finalHits.Load() != 0 {
|
||||
t.Fatalf("hits start=%d final=%d, want the redirect target untouched", startHits.Load(), finalHits.Load())
|
||||
}
|
||||
ids := openRows(t, d, scope)
|
||||
if len(ids) != 1 || allRows(t, d, scope) != 1 {
|
||||
t.Fatalf("open requests = %v (%d rows), want one", ids, allRows(t, d, scope))
|
||||
}
|
||||
detail, err := d.GetInterceptDetail(ids[0])
|
||||
if err != nil || detail == nil || detail.Audit == nil || len(detail.Audit.Targets) != 1 {
|
||||
t.Fatalf("request detail = %+v, %v", detail, err)
|
||||
}
|
||||
if tgt := detail.Audit.Targets[0]; tgt.Host+":"+strconv.Itoa(tgt.Port) != finalKey || tgt.RedirectFrom != startKey || tgt.Outcome != "requested" {
|
||||
t.Fatalf("requested target = %+v, want %s from %s", tgt, finalKey, startKey)
|
||||
}
|
||||
if !strings.Contains(detail.Reason, "A redirect from "+startKey) || !strings.Contains(string(detail.ToolInput), start.URL+"/start") {
|
||||
t.Fatalf("request reason %q / input %s, want the origin of the redirect", detail.Reason, detail.ToolInput)
|
||||
}
|
||||
|
||||
// The retried call stops at the same hop and attaches to the same row.
|
||||
if _, err := gatedFetch(ctx, start.URL+"/start"); err == nil || !strings.Contains(err.Error(), TargetApprovalPending) || finalHits.Load() != 0 {
|
||||
t.Fatalf("retry before the approval: %v, final hits %d", err, finalHits.Load())
|
||||
}
|
||||
if again := openRows(t, d, scope); len(again) != 1 || again[0] != ids[0] || allRows(t, d, scope) != 1 {
|
||||
t.Fatalf("after the retry: open %v, %d rows; want the same single request", again, allRows(t, d, scope))
|
||||
}
|
||||
|
||||
approveAll(t, d, ic, scope)
|
||||
if resp, err := gatedFetch(ctx, start.URL+"/start"); err != nil || resp.StatusCode != 200 || finalHits.Load() != 1 {
|
||||
t.Fatalf("after the approval: %v, final hits %d", err, finalHits.Load())
|
||||
}
|
||||
if res.total() != 0 {
|
||||
t.Fatalf("%d lookups for IP literals", res.total())
|
||||
}
|
||||
}
|
||||
|
||||
// http -> https on the same host is another key (port 443, not 80): a pin on
|
||||
// (host, 80) does not cover it, and the hop asks again.
|
||||
func TestRedirectHTTPToHTTPSAsksAgain(t *testing.T) {
|
||||
d := targetTestDB(t)
|
||||
ic, res := pgGate(t, d)
|
||||
res.set("app.example.com", "203.0.113.7")
|
||||
scope := taskScope(t, d, ic, time.Minute)
|
||||
pinURL(t, d, ic, scope, "http://app.example.com/")
|
||||
ctx := WithTargetScope(t.Context(), scope)
|
||||
|
||||
if err := hop(ctx, "http://app.example.com/next", "http://app.example.com/"); err != nil {
|
||||
t.Fatalf("hop on the pinned key: %v", err)
|
||||
}
|
||||
err := hop(ctx, "https://app.example.com/", "http://app.example.com/")
|
||||
if err == nil || !strings.Contains(err.Error(), TargetApprovalPending) || !strings.Contains(err.Error(), "redirects to app.example.com:443") {
|
||||
t.Fatalf("http -> https: %v", err)
|
||||
}
|
||||
ids := openRows(t, d, scope)
|
||||
if len(ids) != 1 {
|
||||
t.Fatalf("open requests = %v, want the one for port 443", ids)
|
||||
}
|
||||
detail, err := d.GetInterceptDetail(ids[0])
|
||||
if err != nil || detail == nil || detail.Audit == nil || detail.Audit.Targets[0].Port != 443 || detail.Audit.Targets[0].RedirectFrom != "app.example.com:80" {
|
||||
t.Fatalf("request = %+v, %v", detail, err)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,229 @@
|
||||
package intercept
|
||||
|
||||
import (
|
||||
"context"
|
||||
"net"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"net/url"
|
||||
"strings"
|
||||
"sync/atomic"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/Autumn-27/artex/db"
|
||||
)
|
||||
|
||||
// Step 1.9: every redirect hop of a platform-owned client goes through the gate.
|
||||
// Without a database: a hop that would open a request is covered by the
|
||||
// PostgreSQL tests.
|
||||
|
||||
// hopServer counts its requests and answers a fixed page, or a redirect to
|
||||
// location when it is set.
|
||||
func hopServer(t *testing.T, location string) (srv *httptest.Server, hits *atomic.Int64, key string) {
|
||||
t.Helper()
|
||||
hits = &atomic.Int64{}
|
||||
srv = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
hits.Add(1)
|
||||
if location != "" {
|
||||
http.Redirect(w, r, location, http.StatusFound)
|
||||
return
|
||||
}
|
||||
_, _ = w.Write([]byte("hop-reached"))
|
||||
}))
|
||||
t.Cleanup(srv.Close)
|
||||
u, err := url.Parse(srv.URL)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
return srv, hits, u.Host
|
||||
}
|
||||
|
||||
// hop calls the redirect policy of tool on one hop, as the client does.
|
||||
func hop(ctx context.Context, to string, from ...string) error {
|
||||
req, err := http.NewRequestWithContext(ctx, http.MethodGet, to, nil)
|
||||
if err != nil {
|
||||
panic(err)
|
||||
}
|
||||
via := make([]*http.Request, len(from))
|
||||
for n, f := range from {
|
||||
if via[n], err = http.NewRequestWithContext(ctx, http.MethodGet, f, nil); err != nil {
|
||||
panic(err)
|
||||
}
|
||||
}
|
||||
return RedirectCheck("WebFetch")(req, via)
|
||||
}
|
||||
|
||||
func gatedFetch(ctx context.Context, rawURL string) (*http.Response, error) {
|
||||
req, err := http.NewRequestWithContext(ctx, http.MethodGet, rawURL, nil)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
resp, err := (&http.Client{CheckRedirect: RedirectCheck("WebFetch")}).Do(req)
|
||||
if resp != nil {
|
||||
resp.Body.Close()
|
||||
}
|
||||
return resp, err
|
||||
}
|
||||
|
||||
// With the gate off, or without a scope, the policy is net/http's default:
|
||||
// every hop is followed, up to 10, with the same error after that. Nothing is
|
||||
// parsed, resolved, read or logged, not even a hop whose target cannot be read.
|
||||
func TestRedirectGateOffKeepsDefaultPolicy(t *testing.T) {
|
||||
g := newGate(t)
|
||||
g.res.set("app.example.com", "203.0.113.7")
|
||||
chain := make([]string, maxRedirects)
|
||||
for n := range chain {
|
||||
chain[n] = "http://app.example.com/"
|
||||
}
|
||||
for name, ctx := range map[string]context.Context{
|
||||
"no scope": context.Background(),
|
||||
"no flag": WithTargetScope(context.Background(), TargetScope{TaskID: "7", WaitBound: time.Minute, Interceptor: g.ic}),
|
||||
"flag off": WithTargetScope(context.Background(), TargetScope{TaskID: "7", Enabled: func() bool { return false }, Interceptor: g.ic}),
|
||||
} {
|
||||
if err := hop(ctx, "https://other.example.com/", chain[:1]...); err != nil {
|
||||
t.Errorf("%s: %v, want the hop followed", name, err)
|
||||
}
|
||||
if err := hop(ctx, "http:///no-host", chain[:1]...); err != nil {
|
||||
t.Errorf("%s, no host: %v, want the hop followed", name, err)
|
||||
}
|
||||
if err := hop(ctx, "https://other.example.com/", chain[:maxRedirects-1]...); err != nil {
|
||||
t.Errorf("%s, hop 9: %v", name, err)
|
||||
}
|
||||
if err := hop(ctx, "https://other.example.com/", chain...); err == nil || err.Error() != "stopped after 10 redirects" {
|
||||
t.Errorf("%s, hop 10: %v, want net/http's limit", name, err)
|
||||
}
|
||||
|
||||
// Through a real client: a hop to another port, which the gate would ask
|
||||
// for, is followed.
|
||||
final, finalHits, _ := hopServer(t, "")
|
||||
start, _, _ := hopServer(t, final.URL+"/final")
|
||||
if resp, err := gatedFetch(ctx, start.URL+"/start"); err != nil || resp.StatusCode != http.StatusOK || finalHits.Load() != 1 {
|
||||
t.Errorf("%s: chain not followed: %v, hits=%d", name, err, finalHits.Load())
|
||||
}
|
||||
loop := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
http.Redirect(w, r, r.URL.Path+"x", http.StatusFound)
|
||||
}))
|
||||
_, gotErr := gatedFetch(ctx, loop.URL+"/l")
|
||||
_, wantErr := (&http.Client{}).Get(loop.URL + "/l")
|
||||
loop.Close()
|
||||
if gotErr == nil || wantErr == nil || gotErr.Error() != wantErr.Error() {
|
||||
t.Errorf("%s: redirect loop: %v, want the default policy's %v", name, gotErr, wantErr)
|
||||
}
|
||||
}
|
||||
if g.store.reads != 0 || len(g.store.logged) != 0 || g.res.total() != 0 {
|
||||
t.Errorf("gate off: %d store reads, %d rows, %d lookups, want none", g.store.reads, len(g.store.logged), g.res.total())
|
||||
}
|
||||
// Gate on, the limit holds as well, before anything is read.
|
||||
if err := hop(g.ctx(), "https://app.example.com/", chain...); err == nil || err.Error() != "stopped after 10 redirects" || g.store.reads != 0 {
|
||||
t.Errorf("gate on, hop 10: %v, %d store reads", err, g.store.reads)
|
||||
}
|
||||
}
|
||||
|
||||
// A hop to a pinned target is followed, through a real client: the redirected
|
||||
// request keeps the context of the call, so the policy finds the scope. The
|
||||
// first use of the pin is logged with the origin of the redirect.
|
||||
func TestRedirectToPinnedHostFollowed(t *testing.T) {
|
||||
g := newGate(t)
|
||||
final, finalHits, finalKey := hopServer(t, "")
|
||||
start, startHits, startKey := hopServer(t, final.URL+"/final")
|
||||
host, port, _ := net.SplitHostPort(finalKey)
|
||||
pin := &db.TargetPin{ID: 1, Host: host, Port: atoiPort(t, port), Version: 1, Status: db.TargetPinActive, PinnedIPs: []string{host}}
|
||||
g.store.pins = []*db.TargetPin{pin}
|
||||
|
||||
resp, err := gatedFetch(g.ctx(), start.URL+"/start")
|
||||
if err != nil || resp.StatusCode != http.StatusOK || startHits.Load() != 1 || finalHits.Load() != 1 {
|
||||
t.Fatalf("pinned hop: %v, hits start=%d final=%d", err, startHits.Load(), finalHits.Load())
|
||||
}
|
||||
if got := g.store.outcomes(); len(got) != 1 || got[0] != "allowed/pin_match" {
|
||||
t.Fatalf("rows = %v, want the first use of the pin", got)
|
||||
}
|
||||
row := g.store.logged[0]
|
||||
if tgt := row.Audit.Targets[0]; tgt.Host != host || tgt.RedirectFrom != startKey || tgt.PinID != pin.ID {
|
||||
t.Fatalf("logged target = %+v, want %s from %s", tgt, finalKey, startKey)
|
||||
}
|
||||
if !strings.Contains(string(row.ToolInput), final.URL+"/final") || !strings.Contains(string(row.ToolInput), start.URL+"/start") {
|
||||
t.Fatalf("logged input = %s, want the hop and its origin", row.ToolInput)
|
||||
}
|
||||
if g.res.total() != 0 {
|
||||
t.Fatalf("%d lookups for an IP literal", g.res.total())
|
||||
}
|
||||
}
|
||||
|
||||
// A (host, 0) pin covers every port: http -> https on that host is followed.
|
||||
func TestRedirectToPortZeroPinnedHostFollowed(t *testing.T) {
|
||||
g := newGate(t)
|
||||
g.res.set("app.example.com", "203.0.113.7")
|
||||
g.store.pins = []*db.TargetPin{{ID: 1, Host: "app.example.com", Port: 0, Version: 1, Status: db.TargetPinActive, PinnedIPs: []string{"203.0.113.7"}}}
|
||||
if err := hop(g.ctx(), "https://app.example.com/login", "http://app.example.com/login"); err != nil {
|
||||
t.Fatalf("http -> https under a (host, 0) pin: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
// A block rule stops a hop before anything is resolved, whether it names the
|
||||
// hop's host or its URL, and even when the hop stays on a pinned host. No
|
||||
// request is opened.
|
||||
func TestRedirectToBlockedNameNotResolved(t *testing.T) {
|
||||
g := newGate(t)
|
||||
g.res.set("app.example.com", "203.0.113.7")
|
||||
g.res.set("evil.example", "198.51.100.9")
|
||||
g.store.pins = []*db.TargetPin{{ID: 1, Host: "app.example.com", Port: 443, Version: 1, Status: db.TargetPinActive, PinnedIPs: []string{"203.0.113.7"}}}
|
||||
g.store.rules = []db.AssetInterceptRule{
|
||||
{Enabled: true, Kind: "exact_domain", Pattern: "evil.example"},
|
||||
{Enabled: true, Kind: "exact_url", Pattern: "https://app.example.com/admin"},
|
||||
}
|
||||
|
||||
err := hop(g.ctx(), "http://evil.example/x", "https://app.example.com/")
|
||||
if err == nil || !strings.Contains(err.Error(), TargetRuleBlocked) || !strings.Contains(err.Error(), "https://app.example.com/ redirects to evil.example:80") {
|
||||
t.Fatalf("hop to a blocked name: %v", err)
|
||||
}
|
||||
if n := g.res.lookups("evil.example"); n != 0 {
|
||||
t.Fatalf("the blocked name was resolved %d times", n)
|
||||
}
|
||||
err = hop(g.ctx(), "https://app.example.com/admin", "https://app.example.com/")
|
||||
if err == nil || !strings.Contains(err.Error(), TargetRuleBlocked) {
|
||||
t.Fatalf("hop to a blocked URL on a pinned host: %v", err)
|
||||
}
|
||||
if got := g.store.outcomes(); len(got) != 2 || got[0] != "denied/rule_blocked" || got[1] != "denied/rule_blocked" {
|
||||
t.Fatalf("rows = %v, want two blocks", got)
|
||||
}
|
||||
if from := g.store.logged[0].Audit.Targets[0].RedirectFrom; from != "app.example.com:443" {
|
||||
t.Fatalf("redirect_from = %q", from)
|
||||
}
|
||||
if g.res.total() != 0 {
|
||||
t.Fatalf("%d lookups, want none", g.res.total())
|
||||
}
|
||||
}
|
||||
|
||||
// A hop whose target cannot be read is blocked with TARGET_GATE_UNAVAILABLE, as
|
||||
// a rendered URL is, and opens no request.
|
||||
func TestRedirectUnreadableHopBlocked(t *testing.T) {
|
||||
g := newGate(t)
|
||||
for _, to := range []*url.URL{
|
||||
{Scheme: "http", Path: "/no-host"},
|
||||
{Scheme: "http", Host: "app.example.com:99999", Path: "/"},
|
||||
} {
|
||||
req, _ := http.NewRequestWithContext(g.ctx(), http.MethodGet, "http://placeholder.example/", nil)
|
||||
req.URL = to
|
||||
via, _ := http.NewRequestWithContext(g.ctx(), http.MethodGet, "https://app.example.com/", nil)
|
||||
err := RedirectCheck("WebFetch")(req, []*http.Request{via})
|
||||
if err == nil || !strings.Contains(err.Error(), TargetGateUnavailable) {
|
||||
t.Errorf("%s: %v, want TARGET_GATE_UNAVAILABLE", to, err)
|
||||
}
|
||||
}
|
||||
if got := g.store.outcomes(); len(got) != 2 || got[0] != "denied/gate_unavailable" {
|
||||
t.Fatalf("rows = %v", got)
|
||||
}
|
||||
if g.res.total() != 0 {
|
||||
t.Fatalf("%d lookups, want none", g.res.total())
|
||||
}
|
||||
}
|
||||
|
||||
func atoiPort(t *testing.T, s string) int {
|
||||
t.Helper()
|
||||
p := validPort(s)
|
||||
if p == 0 {
|
||||
t.Fatalf("port %q", s)
|
||||
}
|
||||
return p
|
||||
}
|
||||
@@ -40,7 +40,7 @@ func GateRenderedURL(ctx context.Context, toolName, rawURL string) TargetResult
|
||||
if err != nil {
|
||||
return undeterminedTarget(ctx, scope, toolName, input, "the target of the rendered URL could not be read ("+err.Error()+")")
|
||||
}
|
||||
return gateRendered(ctx, scope, toolName, input, []Target{t})
|
||||
return gateRendered(ctx, scope, toolName, input, []Target{t}, []string{rawURL})
|
||||
}
|
||||
|
||||
// GateRenderedCommand is the target gate for the command a custom command tool
|
||||
@@ -62,7 +62,7 @@ func GateRenderedCommand(ctx context.Context, toolName, command string, readings
|
||||
for _, r := range readings {
|
||||
l.scan(r)
|
||||
}
|
||||
return gateRendered(ctx, scope, toolName, renderedInput("command", command), l.targets)
|
||||
return gateRendered(ctx, scope, toolName, renderedInput("command", command), l.targets, l.urls)
|
||||
}
|
||||
|
||||
func renderedScope(ctx context.Context) (TargetScope, bool) {
|
||||
@@ -79,9 +79,10 @@ func renderedInput(field, value string) []byte {
|
||||
|
||||
// gateRendered runs the gate decision on the targets of a rendered call, asks
|
||||
// for the approval of those no pin covers, and checks again after the
|
||||
// decisions. It never merges an ask: the rules and the judge decided at the
|
||||
// hook, before the tool ran.
|
||||
func gateRendered(ctx context.Context, scope TargetScope, toolName string, input []byte, targets []Target) TargetResult {
|
||||
// decisions. urls are the URLs the call renders, for the URL block rules. It
|
||||
// never merges an ask: the rules and the judge decided at the hook, before the
|
||||
// tool ran.
|
||||
func gateRendered(ctx context.Context, scope TargetScope, toolName string, input []byte, targets []Target, urls []string) TargetResult {
|
||||
if len(targets) == 0 {
|
||||
return TargetResult{}
|
||||
}
|
||||
@@ -95,7 +96,7 @@ func gateRendered(ctx context.Context, scope TargetScope, toolName string, input
|
||||
if !scope.Enabled() {
|
||||
return nil, TargetResult{}
|
||||
}
|
||||
c := &targetCheck{i: i, ctx: ctx, scope: scope, tool: toolName, input: input}
|
||||
c := &targetCheck{i: i, ctx: ctx, scope: scope, tool: toolName, input: input, urls: urls}
|
||||
return c.run(targets)
|
||||
}
|
||||
unpinned, res := check()
|
||||
|
||||
@@ -41,6 +41,9 @@ type TargetRequest struct {
|
||||
Reason string // no_pin | new_ip | revoked
|
||||
Pin *db.TargetPin // the active pin an approval would extend (new_ip); nil otherwise
|
||||
ExemptVoid bool // a stored exemption names the target and was void for this call
|
||||
// RedirectFrom is the origin (host:port) of the redirect that leads to the
|
||||
// target; empty when the call names the target itself.
|
||||
RedirectFrom string
|
||||
}
|
||||
|
||||
// TargetResult is the outcome of RequestTargets. Code is empty when every
|
||||
@@ -248,6 +251,7 @@ func (i *Interceptor) openTargetRequest(ctx context.Context, ref db.TargetScopeR
|
||||
Host: t.Host, Port: t.Port, Kind: t.Kind,
|
||||
ResolvedIPs: t.ResolvedIPs, Resolver: t.Resolver, ResolvedAt: t.ResolvedAt,
|
||||
Reason: t.Reason, Outcome: "requested", NameOnlyEffective: nameOnly, ExemptVoid: t.ExemptVoid,
|
||||
RedirectFrom: t.RedirectFrom,
|
||||
}
|
||||
if t.Pin != nil {
|
||||
target.PinID, target.PinVersion, target.PinnedIPs = t.Pin.ID, t.Pin.Version, t.Pin.PinnedIPs
|
||||
@@ -363,6 +367,9 @@ func targetReason(scope TargetScope, t TargetRequest, ask *Decision, nameOnly bo
|
||||
b.WriteString(ask.Message)
|
||||
b.WriteString("\nThis call also names a target that needs approval. ")
|
||||
}
|
||||
if t.RedirectFrom != "" {
|
||||
fmt.Fprintf(&b, "A redirect from %s leads to this target; the redirect was not followed. ", t.RedirectFrom)
|
||||
}
|
||||
name, bound := targetName(t), scope.scopeName()
|
||||
if t.Port == 0 {
|
||||
name += " (port not declared: every port)"
|
||||
@@ -377,7 +384,8 @@ func targetReason(scope TargetScope, t TargetRequest, ask *Decision, nameOnly bo
|
||||
fmt.Fprintf(&b, " Approving pins these addresses for %s until revoked.", bound)
|
||||
if nameOnly {
|
||||
b.WriteString(" Egress goes through the upstream proxy, which chooses the address it connects to." +
|
||||
" The addresses listed are what the platform resolved. This approval is name-only.")
|
||||
" The addresses listed are what the platform resolved. This approval is name-only." +
|
||||
" The platform does not bind the connection to these addresses.")
|
||||
}
|
||||
return b.String()
|
||||
}
|
||||
|
||||
@@ -24,6 +24,16 @@ type Resolver interface {
|
||||
// resolver unless one is set.
|
||||
func (i *Interceptor) SetResolver(r Resolver) { i.resolve.use(r) }
|
||||
|
||||
// SetBaseDialer replaces the dialer that opens the connections PinnedDialer
|
||||
// lets through, which is a net.Dialer with the settings of
|
||||
// http.DefaultTransport unless one is set. Tests use it to map addresses to
|
||||
// local listeners and to see what was dialled.
|
||||
func (i *Interceptor) SetBaseDialer(f func(ctx context.Context, network, addr string) (net.Conn, error)) {
|
||||
i.mu.Lock()
|
||||
i.dial = f
|
||||
i.mu.Unlock()
|
||||
}
|
||||
|
||||
// systemResolver is the resolver of the ARTEX process. It reads the same
|
||||
// resolver configuration as the tools that run in the same container.
|
||||
type systemResolver struct{}
|
||||
|
||||
+29
-12
@@ -620,9 +620,14 @@ func (s *Server) StartTriggeredRun(agentKey, title, message string, taskID int64
|
||||
return
|
||||
}
|
||||
cfg := s.readTriggerBehavior(agentKey) // DB read BEFORE the lock (never under queueMu)
|
||||
// A conversation triggered by a gated task is gated (the flag only, never pins).
|
||||
gated := false
|
||||
if t, ok := s.m.Task(strconv.FormatInt(taskID, 10)); ok && taskID > 0 {
|
||||
gated = t.targetGate.Load()
|
||||
}
|
||||
s.queueMu.Lock()
|
||||
s.triggerCfg[agentKey] = cfg
|
||||
s.triggerQ[agentKey] = append(s.triggerQ[agentKey], triggeredRun{agentKey: agentKey, title: title, message: message, taskID: taskID, taskDesc: taskDesc, taskGoal: taskGoal, mergeable: mergeable})
|
||||
s.triggerQ[agentKey] = append(s.triggerQ[agentKey], triggeredRun{agentKey: agentKey, title: title, message: message, taskID: taskID, taskDesc: taskDesc, taskGoal: taskGoal, mergeable: mergeable, targetGate: gated})
|
||||
s.pumpLocked(agentKey)
|
||||
s.queueMu.Unlock()
|
||||
}
|
||||
@@ -749,15 +754,26 @@ func mergeTriggeredRuns(items []triggeredRun) triggeredRun {
|
||||
fmt.Fprintf(&b, "\n── trigger %d ──\n%s\n", i+1, it.message)
|
||||
}
|
||||
return triggeredRun{
|
||||
agentKey: first.agentKey,
|
||||
title: fmt.Sprintf("Merged triggers · task#%d · %d items", first.taskID, len(items)),
|
||||
message: b.String(),
|
||||
taskID: first.taskID,
|
||||
mergeable: true,
|
||||
agentKey: first.agentKey,
|
||||
title: fmt.Sprintf("Merged triggers · task#%d · %d items", first.taskID, len(items)),
|
||||
message: b.String(),
|
||||
taskID: first.taskID,
|
||||
mergeable: true,
|
||||
targetGate: anyTriggerGated(items),
|
||||
// taskDesc/taskGoal left empty: header already embedded above.
|
||||
}
|
||||
}
|
||||
|
||||
// anyTriggerGated reports whether any fire of a merged run came from a gated task.
|
||||
func anyTriggerGated(items []triggeredRun) bool {
|
||||
for _, it := range items {
|
||||
if it.targetGate {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
// mergeAllRuns folds the ENTIRE queued burst into one run (merge_mode='all'),
|
||||
// regardless of type. Events are grouped by task (tasks in first-appearance order,
|
||||
// events in their original order within a task), so each task's context header — and
|
||||
@@ -791,11 +807,12 @@ func mergeAllRuns(items []triggeredRun) triggeredRun {
|
||||
}
|
||||
}
|
||||
return triggeredRun{
|
||||
agentKey: first.agentKey,
|
||||
title: fmt.Sprintf("Merged triggers · all · %d items", len(items)),
|
||||
message: b.String(),
|
||||
taskID: first.taskID,
|
||||
mergeable: true,
|
||||
agentKey: first.agentKey,
|
||||
title: fmt.Sprintf("Merged triggers · all · %d items", len(items)),
|
||||
message: b.String(),
|
||||
taskID: first.taskID,
|
||||
mergeable: true,
|
||||
targetGate: anyTriggerGated(items),
|
||||
// taskDesc/taskGoal left empty: per-task headers already embedded above.
|
||||
}
|
||||
}
|
||||
@@ -810,7 +827,7 @@ func (s *Server) runTriggeredRun(item triggeredRun) {
|
||||
}
|
||||
}()
|
||||
pg := s.m.pg
|
||||
c, err := pg.CreateConversation(item.agentKey, firstLine(item.title, 60), nil)
|
||||
c, err := pg.CreateConversationGated(item.agentKey, firstLine(item.title, 60), nil, item.targetGate)
|
||||
if err != nil {
|
||||
log.Printf("[trigger] create conversation for %s failed: %v", item.agentKey, err)
|
||||
return
|
||||
|
||||
+41
-4
@@ -455,7 +455,9 @@ func (s *Server) runHTTPTool(ctx context.Context, key string, execRaw json.RawMe
|
||||
req.Header.Set(k, renderTemplate(v, params, identity))
|
||||
}
|
||||
client := &http.Client{Timeout: timeoutOr(spec.TimeoutMs, 30000)}
|
||||
if tr := s.httpProxyTransport(spec); tr != nil {
|
||||
// Every redirect hop goes through the target gate, as the rendered URL did.
|
||||
client.CheckRedirect = intercept.RedirectCheck(key)
|
||||
if tr := s.httpToolTransport(ctx, key, spec); tr != nil {
|
||||
client.Transport = tr
|
||||
}
|
||||
resp, err := client.Do(req)
|
||||
@@ -469,14 +471,38 @@ func (s *Server) runHTTPTool(ctx context.Context, key string, execRaw json.RawMe
|
||||
return actool.Text(actool.Capture(tc, string(b))), nil
|
||||
}
|
||||
|
||||
// httpToolTransport is the transport of one http tool call, or nil
|
||||
// (http.DefaultTransport). A call through a proxy keeps httpProxyTransport: it
|
||||
// dials the proxy, which makes the connection to the target. A direct call in
|
||||
// a gated scope connects through the pinned dialer, to addresses a pin covers.
|
||||
func (s *Server) httpToolTransport(ctx context.Context, key string, spec httpExec) *http.Transport {
|
||||
if tr := s.httpProxyTransport(spec); tr != nil {
|
||||
return tr
|
||||
}
|
||||
if !intercept.GateOn(ctx) {
|
||||
return nil
|
||||
}
|
||||
base, ok := http.DefaultTransport.(*http.Transport)
|
||||
if !ok {
|
||||
base = &http.Transport{}
|
||||
}
|
||||
tr := base.Clone()
|
||||
// An environment proxy would be dialled instead of the target.
|
||||
tr.Proxy = nil
|
||||
tr.DialContext = intercept.PinnedDialer(key, true)
|
||||
// One request per call: no idle connection outlives the call.
|
||||
tr.DisableKeepAlives = true
|
||||
return tr
|
||||
}
|
||||
|
||||
// httpProxyTransport builds a Transport for the http tool's proxy config, or nil
|
||||
// (direct). use_recording_proxy routes through the recording proxy + trusts its CA.
|
||||
func (s *Server) httpProxyTransport(spec httpExec) *http.Transport {
|
||||
proxyStr := strings.TrimSpace(spec.Proxy)
|
||||
proxyStr := proxyURLString(spec.Proxy)
|
||||
var caFile string
|
||||
if spec.UseRecordingProxy {
|
||||
if addr := s.m.ProxyAddr(); addr != "" {
|
||||
proxyStr = "http://" + addr
|
||||
if addr := proxyURLString(s.m.ProxyAddr()); addr != "" {
|
||||
proxyStr = addr
|
||||
caFile = s.m.ProxyCACert()
|
||||
}
|
||||
}
|
||||
@@ -499,6 +525,17 @@ func (s *Server) httpProxyTransport(spec httpExec) *http.Transport {
|
||||
return tr
|
||||
}
|
||||
|
||||
// proxyURLString returns a proxy address as a URL: a bare host:port gets
|
||||
// "http://", an address that already has a scheme (as ProxyAddr returns it) is
|
||||
// kept as is.
|
||||
func proxyURLString(s string) string {
|
||||
s = strings.TrimSpace(s)
|
||||
if s == "" || strings.Contains(s, "://") {
|
||||
return s
|
||||
}
|
||||
return "http://" + s
|
||||
}
|
||||
|
||||
// ---------- helpers ----------
|
||||
|
||||
func identity(s string) string { return s }
|
||||
|
||||
@@ -0,0 +1,358 @@
|
||||
package server
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"fmt"
|
||||
"io"
|
||||
"net"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"slices"
|
||||
"strings"
|
||||
"sync"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/Autumn-27/artex/db"
|
||||
"github.com/Autumn-27/artex/intercept"
|
||||
)
|
||||
|
||||
// Step 2.1: the custom http tool connects directly through the pinned dialer
|
||||
// in a gated scope, and a gated worker's WebFetch end to end.
|
||||
|
||||
// routeDialer is the base dialer of the gate in these tests: it records every
|
||||
// address, connects the routed TEST-NET addresses to local listeners, and
|
||||
// refuses the rest.
|
||||
type routeDialer struct {
|
||||
mu sync.Mutex
|
||||
routes map[string]string
|
||||
dialed []string
|
||||
}
|
||||
|
||||
func newRouteDialer(g *gateServer) *routeDialer {
|
||||
d := &routeDialer{routes: map[string]string{}}
|
||||
g.m.interceptor.SetBaseDialer(d.dial)
|
||||
return d
|
||||
}
|
||||
|
||||
func (d *routeDialer) route(addr, to string) {
|
||||
d.mu.Lock()
|
||||
d.routes[addr] = to
|
||||
d.mu.Unlock()
|
||||
}
|
||||
|
||||
func (d *routeDialer) dial(ctx context.Context, network, addr string) (net.Conn, error) {
|
||||
d.mu.Lock()
|
||||
d.dialed = append(d.dialed, addr)
|
||||
to, ok := d.routes[addr]
|
||||
d.mu.Unlock()
|
||||
if !ok {
|
||||
return nil, &net.OpError{Op: "dial", Net: network, Err: errors.New("no route in the test dialer")}
|
||||
}
|
||||
return (&net.Dialer{}).DialContext(ctx, network, to)
|
||||
}
|
||||
|
||||
func (d *routeDialer) calls() []string {
|
||||
d.mu.Lock()
|
||||
defer d.mu.Unlock()
|
||||
return slices.Clone(d.dialed)
|
||||
}
|
||||
|
||||
func (r *countingResolver) set(host string, ips ...string) {
|
||||
r.mu.Lock()
|
||||
r.answers[host] = ips
|
||||
r.mu.Unlock()
|
||||
}
|
||||
|
||||
// approveTarget opens the request of a gated http tool call on key and approves it.
|
||||
func approveTarget(t *testing.T, g *gateServer, task *Task, tool interface {
|
||||
Name() string
|
||||
}, call func() (string, bool), key string) {
|
||||
t.Helper()
|
||||
if out, isErr := call(); !isErr || !strings.Contains(out, "TARGET_APPROVAL_PENDING") {
|
||||
t.Fatalf("%s before the approval: error=%v out=%q", tool.Name(), isErr, out)
|
||||
}
|
||||
id, _, _, ok := openTargetRequest(t, g.m.pg, task.ID, key)
|
||||
if !ok {
|
||||
t.Fatalf("no request on %s", key)
|
||||
}
|
||||
decide(t, g, id, "allowed")
|
||||
}
|
||||
|
||||
// A gated direct call reaches its target at the pinned address; once the name
|
||||
// answers another address, the rendered-URL gate passes on the cached answer
|
||||
// and the dial connects nowhere.
|
||||
func TestCustomHTTPDirectDialPinned(t *testing.T) {
|
||||
g := newGateServer(t)
|
||||
on := true
|
||||
task := g.newTask(t, db.TaskCreateOptions{TargetGate: &on})
|
||||
srv, hits, _, port := countingServer(t)
|
||||
res := &countingResolver{answers: map[string][]string{"api.example.com": {"203.0.113.7"}}}
|
||||
g.m.interceptor.SetResolver(res)
|
||||
dialer := newRouteDialer(g)
|
||||
dialer.route("203.0.113.7:"+port, srv.Listener.Addr().String())
|
||||
dialer.route("203.0.113.9:"+port, srv.Listener.Addr().String())
|
||||
key := "api.example.com:" + port
|
||||
tool := g.s.buildCustomTool(&db.Tool{Key: "probe_dial", Kind: "http",
|
||||
Exec: execJSON(t, map[string]any{"url": "http://" + key + "/dial"})})
|
||||
call := func() (string, bool) { return callTool(t, tool, gatedCtx(task, 0), `{}`, nil) }
|
||||
approveTarget(t, g, task, tool, call, key)
|
||||
|
||||
if out, isErr := call(); isErr || !strings.Contains(out, "probe-reached") || hits.Load() != 1 {
|
||||
t.Fatalf("pinned call: error=%v out=%q hits=%d", isErr, out, hits.Load())
|
||||
}
|
||||
res.set("api.example.com", "203.0.113.9")
|
||||
out, isErr := call()
|
||||
if !isErr || !strings.Contains(out, "TARGET_APPROVAL_PENDING: the connection to "+key+" was not opened") || hits.Load() != 1 {
|
||||
t.Fatalf("rebound name: error=%v out=%q hits=%d", isErr, out, hits.Load())
|
||||
}
|
||||
if got := dialer.calls(); !slices.Equal(got, []string{"203.0.113.7:" + port}) {
|
||||
t.Fatalf("dialled %v, want the pinned address once", got)
|
||||
}
|
||||
if _, toolName, input, ok := openTargetRequest(t, g.m.pg, task.ID, key); !ok || toolName != "probe_dial" || !strings.Contains(input, "dial") {
|
||||
t.Fatalf("request at the dial: ok=%v tool=%q input=%s", ok, toolName, input)
|
||||
}
|
||||
}
|
||||
|
||||
// With the gate off (and without a scope) the call keeps http.DefaultTransport:
|
||||
// no transport is built. A spec with a proxy keeps its proxy transport, without
|
||||
// a dialer. Gate on and direct: a transport with the pinned dialer, no
|
||||
// environment proxy, keep-alive off.
|
||||
func TestCustomHTTPGateOffTransportUnchanged(t *testing.T) {
|
||||
s := &Server{}
|
||||
direct := httpExec{URL: "http://api.example.com/"}
|
||||
scope := func(on bool) context.Context {
|
||||
return intercept.WithTargetScope(context.Background(), intercept.TargetScope{TaskID: "7", Enabled: func() bool { return on }})
|
||||
}
|
||||
for name, ctx := range map[string]context.Context{"no scope": context.Background(), "flag off": scope(false)} {
|
||||
if tr := s.httpToolTransport(ctx, "probe", direct); tr != nil {
|
||||
t.Fatalf("%s: transport %+v, want nil (http.DefaultTransport)", name, tr)
|
||||
}
|
||||
}
|
||||
if tr := s.httpToolTransport(scope(true), "probe", httpExec{URL: direct.URL, Proxy: "http://127.0.0.1:1"}); tr == nil || tr.Proxy == nil || tr.DialContext != nil {
|
||||
t.Fatalf("operator proxy: transport %+v, want the proxy transport without a dialer", tr)
|
||||
}
|
||||
if tr := s.httpToolTransport(scope(true), "probe", direct); tr == nil || tr.Proxy != nil || tr.DialContext == nil || !tr.DisableKeepAlives {
|
||||
t.Fatalf("gated direct call: transport %+v", tr)
|
||||
}
|
||||
}
|
||||
|
||||
// The proxy URL of the http tool's transport: an address with a scheme is kept
|
||||
// as is, a bare host:port gets "http://"; never a doubled scheme.
|
||||
func TestHTTPProxyTransportProxyScheme(t *testing.T) {
|
||||
req := httptest.NewRequest("GET", "http://api.example.com/", nil)
|
||||
for _, c := range []struct {
|
||||
name, globalProxy string
|
||||
spec httpExec
|
||||
want string
|
||||
}{
|
||||
{"recording proxy, global proxy with a scheme", "http://127.0.0.1:3128", httpExec{UseRecordingProxy: true}, "http://127.0.0.1:3128"},
|
||||
{"operator proxy with a scheme", "", httpExec{Proxy: "http://10.0.0.5:8080"}, "http://10.0.0.5:8080"},
|
||||
{"operator proxy as bare host:port", "", httpExec{Proxy: " 10.0.0.5:8080 "}, "http://10.0.0.5:8080"},
|
||||
} {
|
||||
s := &Server{m: &Manager{globalProxy: c.globalProxy}}
|
||||
tr := s.httpProxyTransport(c.spec)
|
||||
if tr == nil || tr.Proxy == nil {
|
||||
t.Fatalf("%s: transport %+v, want a proxy transport", c.name, tr)
|
||||
}
|
||||
u, err := tr.Proxy(req)
|
||||
if err != nil || u == nil || u.String() != c.want {
|
||||
t.Fatalf("%s: Proxy(req) = %v, %v; want %s", c.name, u, err, c.want)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// passRoundTripper stands in for an http.DefaultTransport that is not an
|
||||
// *http.Transport; it hands every request to the original transport.
|
||||
type passRoundTripper struct{ next http.RoundTripper }
|
||||
|
||||
func (p passRoundTripper) RoundTrip(r *http.Request) (*http.Response, error) {
|
||||
return p.next.RoundTrip(r)
|
||||
}
|
||||
|
||||
// With http.DefaultTransport replaced by another RoundTripper, a gated direct
|
||||
// call still gets a transport with the pinned dialer instead of a panic.
|
||||
func TestHTTPToolTransportDefaultTransportNotStd(t *testing.T) {
|
||||
orig := http.DefaultTransport
|
||||
http.DefaultTransport = passRoundTripper{next: orig}
|
||||
defer func() { http.DefaultTransport = orig }()
|
||||
ctx := intercept.WithTargetScope(context.Background(), intercept.TargetScope{TaskID: "7", Enabled: func() bool { return true }})
|
||||
tr := (&Server{}).httpToolTransport(ctx, "probe", httpExec{URL: "http://api.example.com/"})
|
||||
if tr == nil || tr.DialContext == nil {
|
||||
t.Fatalf("transport %+v, want one with the pinned dialer", tr)
|
||||
}
|
||||
}
|
||||
|
||||
// A redirect of a pinned origin to a pinned hop: the hop is dialled at the
|
||||
// hop's pinned address.
|
||||
func TestCustomHTTPRedirectHopDialPinned(t *testing.T) {
|
||||
g := newGateServer(t)
|
||||
on := true
|
||||
task := g.newTask(t, db.TaskCreateOptions{TargetGate: &on})
|
||||
final, finalHits, _, finalPort := countingServer(t)
|
||||
hopKey := "hop.example.com:" + finalPort
|
||||
start, _, startAddr := redirectingServer(t, "http://"+hopKey+"/final")
|
||||
_, startPort, _ := net.SplitHostPort(startAddr)
|
||||
originKey := "api.example.com:" + startPort
|
||||
res := &countingResolver{answers: map[string][]string{"api.example.com": {"203.0.113.7"}, "hop.example.com": {"203.0.113.8"}}}
|
||||
g.m.interceptor.SetResolver(res)
|
||||
dialer := newRouteDialer(g)
|
||||
dialer.route("203.0.113.7:"+startPort, start.Listener.Addr().String())
|
||||
dialer.route("203.0.113.8:"+finalPort, final.Listener.Addr().String())
|
||||
// Were the hop dialled at the origin's address, it would still reach it.
|
||||
dialer.route("203.0.113.7:"+finalPort, final.Listener.Addr().String())
|
||||
tool := g.s.buildCustomTool(&db.Tool{Key: "probe_hop", Kind: "http",
|
||||
Exec: execJSON(t, map[string]any{"url": "http://" + originKey + "/start"})})
|
||||
call := func() (string, bool) { return callTool(t, tool, gatedCtx(task, 0), `{}`, nil) }
|
||||
approveTarget(t, g, task, tool, call, originKey)
|
||||
approveTarget(t, g, task, tool, call, hopKey)
|
||||
|
||||
before := len(dialer.calls())
|
||||
if out, isErr := call(); isErr || !strings.Contains(out, "probe-reached") || finalHits.Load() != 1 {
|
||||
t.Fatalf("pinned hop: error=%v out=%q", isErr, out)
|
||||
}
|
||||
if got := dialer.calls()[before:]; !slices.Equal(got, []string{"203.0.113.7:" + startPort, "203.0.113.8:" + finalPort}) {
|
||||
t.Fatalf("dialled %v, want the origin's then the hop's pinned address", got)
|
||||
}
|
||||
}
|
||||
|
||||
// The custom-tool test endpoint has no scope (D14): its connection never goes
|
||||
// through the gate's dialer, and nothing is written.
|
||||
func TestCustomToolTestEndpointDialUngated(t *testing.T) {
|
||||
g := newGateServer(t)
|
||||
on := true
|
||||
g.newTask(t, db.TaskCreateOptions{TargetGate: &on})
|
||||
dialer := newRouteDialer(g)
|
||||
_, hits, host, port := countingServer(t)
|
||||
before := 0
|
||||
if err := g.m.pg.QueryRow(`SELECT count(*) FROM intercept_pending WHERE decision_source='target' OR target_key IS NOT NULL`).Scan(&before); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
code, out := g.do(t, "POST", "/api/tools/custom/test", fmt.Sprintf(`{"kind":"http","exec":{"url":"http://%s:%s/test"}}`, host, port))
|
||||
if code != 200 || out["is_error"] != false || hits.Load() != 1 || len(dialer.calls()) != 0 {
|
||||
t.Fatalf("test endpoint: %d %v hits=%d dialled %v", code, out, hits.Load(), dialer.calls())
|
||||
}
|
||||
after := 0
|
||||
if err := g.m.pg.QueryRow(`SELECT count(*) FROM intercept_pending WHERE decision_source='target' OR target_key IS NOT NULL`).Scan(&after); err != nil || after != before {
|
||||
t.Fatalf("the test endpoint wrote %d target rows (%v)", after-before, err)
|
||||
}
|
||||
}
|
||||
|
||||
// Documents a known limit: a custom http tool that goes through a proxy is not
|
||||
// bound to pins. The pinned dialer covers direct connections only; through a
|
||||
// proxy the connection to the target is the proxy's, and the proxy here
|
||||
// connects to a peer nobody pinned. Step 2.2 binds the recording proxy (and
|
||||
// flips its half of this test); an operator-written proxy stays unbound
|
||||
// (OPEN-6).
|
||||
func TestBypass_CustomHTTPProxyPeerNotPinned(t *testing.T) {
|
||||
g := newGateServer(t)
|
||||
on := true
|
||||
task := g.newTask(t, db.TaskCreateOptions{TargetGate: &on})
|
||||
_, hits, _, port := countingServer(t)
|
||||
peer := "127.0.0.1:" + port
|
||||
proxy := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
// Whatever the request names, the proxy connects to peer.
|
||||
resp, err := http.Get("http://" + peer + r.URL.Path)
|
||||
if err != nil {
|
||||
http.Error(w, err.Error(), http.StatusBadGateway)
|
||||
return
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
_, _ = io.Copy(w, resp.Body)
|
||||
}))
|
||||
t.Cleanup(proxy.Close)
|
||||
res := &countingResolver{answers: map[string][]string{"api.example.com": {"203.0.113.7"}}}
|
||||
g.m.interceptor.SetResolver(res)
|
||||
dialer := newRouteDialer(g)
|
||||
key := "api.example.com:" + port
|
||||
url := "http://" + key + "/bypass"
|
||||
direct := g.s.buildCustomTool(&db.Tool{Key: "probe_bypass", Kind: "http", Exec: execJSON(t, map[string]any{"url": url})})
|
||||
approveTarget(t, g, task, direct, func() (string, bool) { return callTool(t, direct, gatedCtx(task, 0), `{}`, nil) }, key)
|
||||
|
||||
// The global proxy carries a scheme, as in production (ProxyAddr returns it
|
||||
// as is with capture off); httpProxyTransport must not write a second one.
|
||||
g.m.mu.Lock()
|
||||
g.m.globalProxy = proxy.URL
|
||||
g.m.mu.Unlock()
|
||||
t.Cleanup(func() {
|
||||
g.m.mu.Lock()
|
||||
g.m.globalProxy = ""
|
||||
g.m.mu.Unlock()
|
||||
})
|
||||
for name, exec := range map[string]map[string]any{
|
||||
"operator proxy": {"url": url, "proxy": proxy.URL},
|
||||
"use_recording_proxy": {"url": url, "use_recording_proxy": true},
|
||||
} {
|
||||
before := hits.Load()
|
||||
tool := g.s.buildCustomTool(&db.Tool{Key: "probe_bypass", Kind: "http", Exec: execJSON(t, exec)})
|
||||
if out, isErr := callTool(t, tool, gatedCtx(task, 0), `{}`, nil); isErr || !strings.Contains(out, "probe-reached") || hits.Load() != before+1 {
|
||||
t.Fatalf("%s: error=%v out=%q", name, isErr, out)
|
||||
}
|
||||
}
|
||||
if got := dialer.calls(); len(got) != 0 {
|
||||
t.Fatalf("dialled %v; the pinned address 203.0.113.7 is never dialled through a proxy", got)
|
||||
}
|
||||
}
|
||||
|
||||
// A gated worker's WebFetch end to end: approved, the next call passes; the
|
||||
// name then answers another address from the next lookup on, so the following
|
||||
// call passes the hook on the cached answer and fails at the dial with
|
||||
// TARGET_APPROVAL_PENDING. The new_ip request is approved through the API and
|
||||
// the call after passes.
|
||||
func TestTargetGateEndToEndDialRebindBlocked(t *testing.T) {
|
||||
g := newGateServer(t)
|
||||
on := true
|
||||
task := g.newTask(t, db.TaskCreateOptions{TargetGate: &on})
|
||||
pg := g.m.pg
|
||||
srv, hits, _, port := countingServer(t)
|
||||
res := &countingResolver{answers: map[string][]string{"api.example.com": {"203.0.113.7"}}}
|
||||
g.m.interceptor.SetResolver(res)
|
||||
dialer := newRouteDialer(g)
|
||||
dialer.route("203.0.113.7:"+port, srv.Listener.Addr().String())
|
||||
dialer.route("203.0.113.9:"+port, srv.Listener.Addr().String())
|
||||
key := "api.example.com:" + port
|
||||
target := "http://" + key + "/e2e"
|
||||
p := &toolScript{calls: fetches(target, target, target), results: make(chan string, 16),
|
||||
hold: map[int64]chan struct{}{2: make(chan struct{}), 3: make(chan struct{})}}
|
||||
done := runScriptedWorker(t, g, task, p)
|
||||
|
||||
var id int64
|
||||
waitUntil(t, "the first request", func() bool {
|
||||
var ok bool
|
||||
id, _, _, ok = openTargetRequest(t, pg, task.ID, key)
|
||||
return ok
|
||||
})
|
||||
decide(t, g, id, "allowed")
|
||||
if r := p.next(t); !strings.Contains(r, "probe-reached") || hits.Load() != 1 {
|
||||
t.Fatalf("first call after the approval: %q hits=%d", r, hits.Load())
|
||||
}
|
||||
|
||||
res.set("api.example.com", "203.0.113.9")
|
||||
close(p.hold[2])
|
||||
if r := p.next(t); !strings.Contains(r, "TARGET_APPROVAL_PENDING: the connection to "+key+" was not opened") || hits.Load() != 1 {
|
||||
t.Fatalf("second call, rebound at the dial: %q hits=%d", r, hits.Load())
|
||||
}
|
||||
newIP, toolName, _, ok := openTargetRequest(t, pg, task.ID, key)
|
||||
if !ok || newIP == id || toolName != "WebFetch" {
|
||||
t.Fatalf("new_ip request: ok=%v id=%d tool=%q", ok, newIP, toolName)
|
||||
}
|
||||
detail, err := pg.GetInterceptDetail(newIP)
|
||||
if err != nil || detail == nil || detail.Audit == nil || detail.Audit.Targets[0].Reason != "new_ip" ||
|
||||
!slices.Equal(detail.Audit.Targets[0].ResolvedIPs, []string{"203.0.113.9"}) {
|
||||
t.Fatalf("new_ip request detail = %+v, %v", detail, err)
|
||||
}
|
||||
decide(t, g, newIP, "allowed")
|
||||
close(p.hold[3])
|
||||
if r := p.next(t); !strings.Contains(r, "probe-reached") || hits.Load() != 2 {
|
||||
t.Fatalf("third call after the new_ip approval: %q hits=%d", r, hits.Load())
|
||||
}
|
||||
if got := dialer.calls(); !slices.Equal(got, []string{"203.0.113.7:" + port, "203.0.113.9:" + port}) {
|
||||
t.Fatalf("dialled %v", got)
|
||||
}
|
||||
select {
|
||||
case <-done:
|
||||
case <-time.After(60 * time.Second):
|
||||
t.Fatal("the worker run did not end")
|
||||
}
|
||||
}
|
||||
@@ -571,6 +571,49 @@ func TestDenyRuleWinsBeforeRenderedTarget(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// Documents a known limit: script tools stay advisory (D9). A custom script
|
||||
// tool's target is in its stored code, which neither the hook nor the tool
|
||||
// reads, so in a gated task the call is allowed and the script reaches a target
|
||||
// nobody approved: no lookup, no request, no row. This test changes only if
|
||||
// that decision changes.
|
||||
func TestBypass_CustomScriptToolTargetNotGated(t *testing.T) {
|
||||
if detectPython() == "" {
|
||||
t.Skip("python3 unavailable")
|
||||
}
|
||||
g := newGateServer(t)
|
||||
on := true
|
||||
task := g.newTask(t, db.TaskCreateOptions{TargetGate: &on})
|
||||
res := &countingResolver{answers: map[string][]string{"localhost": {"127.0.0.1"}}}
|
||||
g.m.interceptor.SetResolver(res)
|
||||
_, hits, _, port := countingServer(t)
|
||||
|
||||
code := "import urllib.request\n" +
|
||||
"opener = urllib.request.build_opener(urllib.request.ProxyHandler({}))\n" +
|
||||
"print(opener.open('http://localhost:" + port + "/script', timeout=20).read().decode())\n"
|
||||
tool := g.s.buildCustomTool(&db.Tool{Key: "probe_script", Kind: "script", Exec: execJSON(t, map[string]any{"code": code})})
|
||||
// The gate sees no target in the call: only the parameters reach the hook.
|
||||
if got := intercept.ExtractTargets("probe_script", []byte(`{}`)); len(got) != 0 {
|
||||
t.Fatalf("the hook reads %+v; the test needs a target only the stored code names", got)
|
||||
}
|
||||
|
||||
p := &toolScript{calls: []scriptedCall{{"probe_script", `{}`}}, results: make(chan string, 16)}
|
||||
done := runScriptedWorker(t, g, task, p, tool)
|
||||
if r := p.next(t); !strings.Contains(r, "probe-reached") || strings.Contains(r, "TARGET_") {
|
||||
t.Fatalf("script tool in a gated task: %q, want it allowed and the target reached", r)
|
||||
}
|
||||
select {
|
||||
case <-done:
|
||||
case <-time.After(60 * time.Second):
|
||||
t.Fatal("the worker run did not end")
|
||||
}
|
||||
if hits.Load() != 1 {
|
||||
t.Fatalf("%d requests reached the unapproved target, want 1 (the gap)", hits.Load())
|
||||
}
|
||||
if n, rows := res.lookups(), targetRowCount(t, g.m.pg, task.ID); n != 0 || rows != 0 {
|
||||
t.Fatalf("%d lookups, %d target rows; the gate did see the script's target", n, rows)
|
||||
}
|
||||
}
|
||||
|
||||
// A task with the gate off (the default) runs as before: a worker's WebFetch
|
||||
// and the custom tools reach their targets, and the gate writes no row and
|
||||
// resolves no name.
|
||||
|
||||
+23
-1
@@ -13,6 +13,7 @@ import (
|
||||
|
||||
"github.com/Autumn-27/artex/agent"
|
||||
"github.com/Autumn-27/artex/db"
|
||||
"github.com/Autumn-27/artex/intercept"
|
||||
"github.com/Autumn-27/norma/permission"
|
||||
actool "github.com/Autumn-27/norma/tool"
|
||||
)
|
||||
@@ -253,7 +254,7 @@ func (s *Server) toolSpawnTask() actool.CoreTool {
|
||||
"plan_heartbeat_seconds": map[string]any{"type": "integer", "description": "optional: planner heartbeat interval (seconds). When this much time has passed since the last planning round ended/the task started with no trigger in between → run one planning round (deadlock backstop + wakes the planner to supervise in-flight workers). Empty or 0 = default 600 (10min);"},
|
||||
"seed_first_intent": map[string]any{"type": "boolean", "description": "optional: enable for simple tasks to issue one seed intent at creation (content = description + goal) so a worker can start testing right away without waiting for the first planner round; default false (the standard plan-then-execute flow)."},
|
||||
}, "description", "goal"),
|
||||
func(_ context.Context, in json.RawMessage) (actool.Result, error) {
|
||||
func(ctx context.Context, in json.RawMessage) (actool.Result, error) {
|
||||
var a struct {
|
||||
Description string `json:"description"`
|
||||
Goal string `json:"goal"`
|
||||
@@ -307,11 +308,32 @@ func (s *Server) toolSpawnTask() actool.CoreTool {
|
||||
if pin != nil {
|
||||
llmIDs = []int64{*pin}
|
||||
}
|
||||
// Target gate: a child spawned from a gated scope is gated too, and keeps
|
||||
// the block rules of the calling task. Read from the caller's scope, never
|
||||
// from parent_ref (optional and written by the model). Pins and allow rules
|
||||
// are never copied. Gate-off caller or no scope: created as before.
|
||||
var gate *bool
|
||||
var blockRules []db.TaskInterceptRuleInput
|
||||
if scope, ok := intercept.TargetScopeFromContext(ctx); ok && scope.Enabled != nil && scope.Enabled() {
|
||||
on := true
|
||||
gate = &on
|
||||
if callerID, err := strconv.ParseInt(scope.TaskID, 10, 64); err == nil && callerID > 0 {
|
||||
block, _, err := s.m.Assets().TaskInterceptRulesSplit(callerID)
|
||||
if err != nil {
|
||||
return actool.Errorf("read the block rules of the calling task: " + err.Error()), nil
|
||||
}
|
||||
for _, r := range block {
|
||||
blockRules = append(blockRules, db.TaskInterceptRuleInput{Enabled: r.Enabled, Action: r.Action, Kind: r.Kind, Pattern: r.Pattern, Note: r.Note})
|
||||
}
|
||||
}
|
||||
}
|
||||
t, err := s.m.CreateTaskWithOptions(a.Description, a.Goal, db.TaskCreateOptions{
|
||||
SourceTaskIDs: sourceIDs,
|
||||
LLMProfileIDs: llmIDs,
|
||||
TimeoutSeconds: a.TimeoutSeconds,
|
||||
PlanHeartbeatSeconds: a.PlanHeartbeatSeconds,
|
||||
InterceptRules: blockRules,
|
||||
TargetGate: gate,
|
||||
})
|
||||
if err != nil {
|
||||
return actool.Errorf(err.Error()), nil
|
||||
|
||||
@@ -147,6 +147,9 @@ type triggeredRun struct {
|
||||
taskDesc string // task description (task-level, same across one task); rendered once when merged
|
||||
taskGoal string // task goal (task-level, same across one task); rendered once when merged
|
||||
mergeable bool // true for finding/goal event triggers (merge by taskID)
|
||||
// targetGate: the source task had the target gate on when the event fired; a
|
||||
// merged run is gated if any of its fires is. Never carries pins.
|
||||
targetGate bool
|
||||
}
|
||||
|
||||
func New(ctx context.Context, m *Manager, skillDir string, dataDir string, keyDir string, opts ...Option) *Server {
|
||||
|
||||
+246
-21
@@ -5,16 +5,19 @@ import (
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"fmt"
|
||||
"iter"
|
||||
"net/http/httptest"
|
||||
"slices"
|
||||
"strconv"
|
||||
"strings"
|
||||
"sync/atomic"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/Autumn-27/artex/agent"
|
||||
"github.com/Autumn-27/artex/db"
|
||||
"github.com/Autumn-27/artex/intercept"
|
||||
"github.com/Autumn-27/norma/llm"
|
||||
)
|
||||
|
||||
// Target-gate opt-in flag, pins and decisions over the real mux and the real
|
||||
@@ -180,39 +183,261 @@ func TestCreateTaskAcceptsTargetGate(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// No inheritance: a task spawned by the orchestration agent starts with the
|
||||
// gate off, even from a gated parent.
|
||||
func TestSpawnedTaskStartsWithGateOff(t *testing.T) {
|
||||
g := newGateServer(t)
|
||||
on := true
|
||||
parent := g.newTask(t, db.TaskCreateOptions{TargetGate: &on})
|
||||
if !parent.targetScope(0).Enabled() {
|
||||
t.Fatal("control: the parent was expected to have the gate on")
|
||||
}
|
||||
in, _ := json.Marshal(map[string]any{"description": "spawned child", "goal": gateTestGoal, "parent_ref": parent.ID, "source_task_ids": []string{parent.ID}})
|
||||
res, err := g.s.toolSpawnTask().Call(context.Background(), in, nil)
|
||||
// ruleLines renders a task's intercept rules for comparison.
|
||||
func ruleLines(t *testing.T, as *db.AssetStore, taskID string) []string {
|
||||
t.Helper()
|
||||
n, _ := strconv.ParseInt(taskID, 10, 64)
|
||||
rules, err := as.ListTaskInterceptRules(n)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
childID, found := strings.CutPrefix(res.Flatten(), "task created: ")
|
||||
if !found {
|
||||
t.Fatalf("spawn_task result: %q", res.Flatten())
|
||||
var out []string
|
||||
for _, r := range rules {
|
||||
out = append(out, fmt.Sprintf("%s %s %s enabled=%v %q", r.Action, r.Kind, r.Pattern, r.Enabled, r.Note))
|
||||
}
|
||||
g.cleanupTask(t, childID)
|
||||
return out
|
||||
}
|
||||
|
||||
// checkSpawnedChild checks the target-gate state of a spawned task: the flag,
|
||||
// live and stored, no pin, and its own intercept rules.
|
||||
func (g *gateServer) checkSpawnedChild(t *testing.T, childID string, gate bool, rules []string) {
|
||||
t.Helper()
|
||||
child, ok := g.m.Task(childID)
|
||||
if !ok || child.ParentRef != parent.ID {
|
||||
t.Fatalf("spawned task = %+v (found=%v), want a child of %s", child, ok, parent.ID)
|
||||
if !ok {
|
||||
t.Fatalf("spawned task %s not found", childID)
|
||||
}
|
||||
if child.targetScope(0).Enabled() {
|
||||
t.Fatal("the spawned task inherited the gate")
|
||||
if child.targetScope(0).Enabled() != gate {
|
||||
t.Fatalf("spawned task gate = %v, want %v", !gate, gate)
|
||||
}
|
||||
n, _ := strconv.ParseInt(childID, 10, 64)
|
||||
if stored, err := g.m.pg.GetTask(n); err != nil || stored == nil || stored.TargetGate {
|
||||
t.Fatalf("stored child = %+v, %v; want the gate off", stored, err)
|
||||
if stored, err := g.m.pg.GetTask(n); err != nil || stored == nil || stored.TargetGate != gate {
|
||||
t.Fatalf("stored child = %+v, %v; want the gate %v", stored, err, gate)
|
||||
}
|
||||
if pins, err := g.m.pg.ListTargetPins(db.TargetScopeRef{TaskID: n}); err != nil || len(pins) != 0 {
|
||||
t.Fatalf("the spawned task has pins: %+v, %v", pins, err)
|
||||
}
|
||||
if got := ruleLines(t, g.m.Assets(), childID); !slices.Equal(got, rules) {
|
||||
t.Fatalf("spawned task rules = %q, want %q", got, rules)
|
||||
}
|
||||
}
|
||||
|
||||
// A task spawned through spawn_task takes the target gate of the calling scope
|
||||
// (D23) and, from a gated task, that task's block rules (D24). It never takes
|
||||
// pins or allow rules, and parent_ref plays no part. A gate-off caller and a
|
||||
// call with no scope create the child as before: gate off, no rules.
|
||||
func TestSpawnedTaskInheritsGateFromCaller(t *testing.T) {
|
||||
g := newGateServer(t)
|
||||
on := true
|
||||
parentRules := []db.TaskInterceptRuleInput{
|
||||
{Enabled: true, Action: "block", Kind: "exact_domain", Pattern: "blocked.example.com", Note: "out of scope"},
|
||||
{Enabled: false, Action: "block", Kind: "cidr", Pattern: "198.51.100.0/24"},
|
||||
{Enabled: true, Action: "allow", Kind: "exact_domain", Pattern: "allowed.example.com"},
|
||||
}
|
||||
gated := g.newTask(t, db.TaskCreateOptions{TargetGate: &on, InterceptRules: parentRules})
|
||||
open := g.newTask(t, db.TaskCreateOptions{InterceptRules: parentRules})
|
||||
if !gated.targetScope(0).Enabled() || open.targetScope(0).Enabled() {
|
||||
t.Fatal("control: one parent gated, the other not")
|
||||
}
|
||||
// The gated parent holds one pin, which no child may get.
|
||||
if p, ok, err := g.m.pg.ResolveTargetRequest(openTargetRow(t, g.m.pg, taskRef(t, gated), "app.example.com", "203.0.113.7"), true, "ARTEX", "192.0.2.1"); err != nil || !ok || p == nil {
|
||||
t.Fatalf("pin the parent: %+v ok=%v err=%v", p, ok, err)
|
||||
}
|
||||
conv, err := g.m.pg.CreateConversationGated("auto", "spawn from a gated chat", nil, true)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
t.Cleanup(func() { _ = g.m.pg.DeleteConversation(conv.ID) })
|
||||
gatedChat := intercept.TargetScope{ConversationID: conv.ID, Enabled: func() bool { return true },
|
||||
WaitBound: intercept.DefaultTargetWaitBound, Interceptor: g.m.interceptor}
|
||||
scoped := func(s intercept.TargetScope) context.Context {
|
||||
return intercept.WithTargetScope(context.Background(), s)
|
||||
}
|
||||
blockOnly := []string{
|
||||
`block exact_domain blocked.example.com enabled=true "out of scope"`,
|
||||
`block cidr 198.51.100.0/24 enabled=false ""`,
|
||||
}
|
||||
|
||||
for _, tc := range []struct {
|
||||
name string
|
||||
ctx context.Context
|
||||
parentRef string
|
||||
gate bool
|
||||
rules []string
|
||||
}{
|
||||
{"gated task", scoped(gated.targetScope(intercept.DefaultTargetWaitBound)), "", true, blockOnly},
|
||||
{"gated task, parent_ref names a gate-off task", scoped(gated.targetScope(0)), open.ID, true, blockOnly},
|
||||
{"gated conversation", scoped(gatedChat), "", true, nil},
|
||||
{"gate-off task", scoped(open.targetScope(0)), "", false, nil},
|
||||
{"gate-off task, parent_ref names a gated task", scoped(open.targetScope(0)), gated.ID, false, nil},
|
||||
{"no scope, parent_ref names a gated task", context.Background(), gated.ID, false, nil},
|
||||
} {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
args := map[string]any{"description": "spawned child", "goal": gateTestGoal}
|
||||
if tc.parentRef != "" {
|
||||
args["parent_ref"] = tc.parentRef
|
||||
}
|
||||
in, _ := json.Marshal(args)
|
||||
res, err := g.s.toolSpawnTask().Call(tc.ctx, in, nil)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
childID, found := strings.CutPrefix(res.Flatten(), "task created: ")
|
||||
if !found {
|
||||
t.Fatalf("spawn_task result: %q", res.Flatten())
|
||||
}
|
||||
g.cleanupTask(t, childID)
|
||||
if child, _ := g.m.Task(childID); child == nil || child.ParentRef != tc.parentRef {
|
||||
t.Fatalf("spawned task = %+v, want parent_ref %q", child, tc.parentRef)
|
||||
}
|
||||
g.checkSpawnedChild(t, childID, tc.gate, tc.rules)
|
||||
})
|
||||
}
|
||||
// The callers are unchanged.
|
||||
if pins, err := g.m.pg.ListTargetPins(taskRef(t, gated)); err != nil || len(pins) != 1 {
|
||||
t.Fatalf("parent pins = %+v, %v; want still one", pins, err)
|
||||
}
|
||||
if got := ruleLines(t, g.m.Assets(), gated.ID); len(got) != 3 {
|
||||
t.Fatalf("parent rules = %q, want the three it was created with", got)
|
||||
}
|
||||
}
|
||||
|
||||
// toolCallProvider is a model that makes one tool call on its first turn and
|
||||
// ends the run on the next.
|
||||
type toolCallProvider struct {
|
||||
tool, input string
|
||||
turn atomic.Int64
|
||||
}
|
||||
|
||||
func (p *toolCallProvider) Stream(context.Context, llm.CompletionRequest) iter.Seq2[llm.StreamEvent, error] {
|
||||
events := []llm.StreamEvent{{Type: llm.SETextDelta, Text: "done"}, {Type: llm.SEMessageDelta, StopReason: "end_turn"}}
|
||||
if p.turn.Add(1) == 1 {
|
||||
events = []llm.StreamEvent{
|
||||
{Type: llm.SEToolUseStart, ToolID: "call-1", ToolName: p.tool},
|
||||
{Type: llm.SEToolInputJSON, Text: p.input},
|
||||
{Type: llm.SEMessageDelta, StopReason: "tool_use"},
|
||||
}
|
||||
}
|
||||
return func(yield func(llm.StreamEvent, error) bool) {
|
||||
for _, event := range events {
|
||||
if !yield(event, nil) {
|
||||
return
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func (p *toolCallProvider) Complete(ctx context.Context, req llm.CompletionRequest) (llm.Message, string, llm.Usage, error) {
|
||||
return accumulateStreamForTest(ctx, p.Stream, req)
|
||||
}
|
||||
|
||||
// spawn_task called by the model of an auto conversation, through the real
|
||||
// harness, tool binding and tool context: the child takes the conversation's
|
||||
// flag. The unit test above builds the caller's context by hand; this one shows
|
||||
// the conversation's scope reaches the tool.
|
||||
func TestSpawnTaskSeesCallerScopeThroughHarness(t *testing.T) {
|
||||
g := newGateServer(t)
|
||||
for _, gate := range []bool{true, false} {
|
||||
t.Run(fmt.Sprintf("conversation gate %v", gate), func(t *testing.T) {
|
||||
desc := fmt.Sprintf("harness child %v %d", gate, time.Now().UnixNano())
|
||||
in, _ := json.Marshal(map[string]any{"description": desc, "goal": gateTestGoal})
|
||||
conv, err := g.m.pg.CreateConversationGated("auto", "spawn through the harness", nil, gate)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
t.Cleanup(func() { _ = g.m.pg.DeleteConversation(conv.ID) })
|
||||
g.s.cfgMu.Lock()
|
||||
g.s.chatAgent = agent.NewChatAgent(&toolCallProvider{tool: "spawn_task", input: string(in)}, "test-model", g.m.dir, nil, 10000)
|
||||
g.s.cfgMu.Unlock()
|
||||
// The server context of this fixture is cancelled; the turn gets its own.
|
||||
ctx, cancel := context.WithCancelCause(intercept.WithConvID(context.Background(), conv.ID))
|
||||
g.s.runConversationTurn(ctx, cancel, conv, "spawn the child task", g.s.convBusyKey(conv.ID))
|
||||
var childID string
|
||||
for _, task := range g.m.List() {
|
||||
if task.Description == desc {
|
||||
childID = task.ID
|
||||
}
|
||||
}
|
||||
if childID == "" {
|
||||
t.Fatal("the model's spawn_task call created no task")
|
||||
}
|
||||
g.cleanupTask(t, childID)
|
||||
g.checkSpawnedChild(t, childID, gate, nil)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// A conversation started by a trigger of a gated task is gated (D25): a single
|
||||
// fire, a by-task merge, and a merge across tasks of which one is gated. A fire
|
||||
// of a gate-off task, or with no task, starts it gate off as before. The flag is
|
||||
// copied, never pins.
|
||||
func TestTriggeredConversationInheritsGate(t *testing.T) {
|
||||
g := newGateServer(t)
|
||||
g.s.cfgMu.Lock()
|
||||
g.s.chatAgent = agent.NewChatAgent(newScopeProbeProvider(), "test-model", g.m.dir, nil, 10000)
|
||||
g.s.cfgMu.Unlock()
|
||||
on := true
|
||||
gated, open := g.newTask(t, db.TaskCreateOptions{TargetGate: &on}), g.newTask(t, db.TaskCreateOptions{})
|
||||
if p, ok, err := g.m.pg.ResolveTargetRequest(openTargetRow(t, g.m.pg, taskRef(t, gated), "app.example.com", "203.0.113.7"), true, "ARTEX", "192.0.2.1"); err != nil || !ok || p == nil {
|
||||
t.Fatalf("pin the gated task: %+v ok=%v err=%v", p, ok, err)
|
||||
}
|
||||
gatedID, openID := taskRef(t, gated).TaskID, taskRef(t, open).TaskID
|
||||
|
||||
// The server context is cancelled, so StartTriggeredRun only queues. The test
|
||||
// takes the next run with the merge mode under test and runs it as the pump would.
|
||||
trigger := func(t *testing.T, mode string, taskIDs ...int64) *db.Conversation {
|
||||
t.Helper()
|
||||
key := fmt.Sprintf("gate-trigger-%d", time.Now().UnixNano())
|
||||
for _, id := range taskIDs {
|
||||
g.s.StartTriggeredRun(key, "trigger", "event body", id, id > 0, "desc", "goal")
|
||||
}
|
||||
g.s.queueMu.Lock()
|
||||
item := g.s.nextTriggerRun(key, triggerBehavior{runMode: "serial", mergeMode: mode})
|
||||
left := len(g.s.triggerQ[key])
|
||||
delete(g.s.triggerQ, key)
|
||||
delete(g.s.triggerCfg, key)
|
||||
g.s.queueMu.Unlock()
|
||||
if left != 0 {
|
||||
t.Fatalf("%d fires left in the queue, want one run", left)
|
||||
}
|
||||
item.title = key
|
||||
g.s.runTriggeredRun(item)
|
||||
convs, err := g.m.pg.ListConversations()
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
for _, c := range convs {
|
||||
if c.Title == key {
|
||||
t.Cleanup(func() { _ = g.m.pg.DeleteConversation(c.ID) })
|
||||
return c
|
||||
}
|
||||
}
|
||||
t.Fatal("the trigger created no conversation")
|
||||
return nil
|
||||
}
|
||||
|
||||
for _, tc := range []struct {
|
||||
name string
|
||||
mode string
|
||||
tasks []int64
|
||||
gate bool
|
||||
}{
|
||||
{"gated task", "none", []int64{gatedID}, true},
|
||||
{"gated task, merged by task", "by_task", []int64{gatedID, gatedID}, true},
|
||||
{"merge across tasks, gated second", "all", []int64{openID, gatedID}, true},
|
||||
{"gate-off task", "none", []int64{openID}, false},
|
||||
{"gate-off task, merged by task", "by_task", []int64{openID, openID}, false},
|
||||
{"no task", "none", []int64{0}, false},
|
||||
} {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
c := trigger(t, tc.mode, tc.tasks...)
|
||||
if c.TargetGate != tc.gate {
|
||||
t.Fatalf("triggered conversation gate = %v, want %v", c.TargetGate, tc.gate)
|
||||
}
|
||||
if pins, err := g.m.pg.ListTargetPins(db.TargetScopeRef{ConversationID: c.ID}); err != nil || len(pins) != 0 {
|
||||
t.Fatalf("the triggered conversation has pins: %+v, %v", pins, err)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// The conversation flag is set on create and on patch, and the turn that starts
|
||||
|
||||
@@ -0,0 +1,162 @@
|
||||
package server
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"net"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"strings"
|
||||
"sync/atomic"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/Autumn-27/artex/db"
|
||||
)
|
||||
|
||||
// Step 1.9: the redirect hops of the custom http tool and of a worker's
|
||||
// WebFetch go through the target gate.
|
||||
|
||||
// redirectingServer answers every request with a redirect to location and
|
||||
// counts the requests. Its host:port is an IP literal: the gate never resolves it.
|
||||
func redirectingServer(t *testing.T, location string) (srv *httptest.Server, hits *atomic.Int64, key string) {
|
||||
t.Helper()
|
||||
hits = &atomic.Int64{}
|
||||
srv = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
hits.Add(1)
|
||||
http.Redirect(w, r, location, http.StatusFound)
|
||||
}))
|
||||
t.Cleanup(srv.Close)
|
||||
return srv, hits, srv.Listener.Addr().String()
|
||||
}
|
||||
|
||||
func decide(t *testing.T, g *gateServer, id int64, decision string) {
|
||||
t.Helper()
|
||||
if code, body := g.do(t, "POST", fmt.Sprintf("/api/intercept/pending/%d/decide", id), `{"decision":"`+decision+`"}`); code != 200 {
|
||||
t.Fatalf("decide %d: %d %v", id, code, body)
|
||||
}
|
||||
}
|
||||
|
||||
// A custom http tool whose rendered URL is pinned, and which redirects to a
|
||||
// target no pin covers: the hop is not followed, one request is opened for its
|
||||
// target, and the call fails at once. After the approval the same call follows.
|
||||
func TestCustomHTTPRedirectTargetGated(t *testing.T) {
|
||||
g := newGateServer(t)
|
||||
on := true
|
||||
task := g.newTask(t, db.TaskCreateOptions{TargetGate: &on})
|
||||
pg := g.m.pg
|
||||
final, finalHits, fhost, fport := countingServer(t)
|
||||
finalKey := net.JoinHostPort(fhost, fport)
|
||||
start, startHits, startKey := redirectingServer(t, final.URL+"/final")
|
||||
|
||||
tool := g.s.buildCustomTool(&db.Tool{Key: "probe_redirect", Kind: "http",
|
||||
Exec: execJSON(t, map[string]any{"method": "GET", "url": start.URL + "/start"})})
|
||||
// The rendered URL itself first: its request, approved.
|
||||
if out, isErr := callTool(t, tool, gatedCtx(task, 0), `{}`, nil); !isErr || !strings.Contains(out, "TARGET_APPROVAL_PENDING") || startHits.Load() != 0 {
|
||||
t.Fatalf("rendered URL: error=%v out=%q", isErr, out)
|
||||
}
|
||||
id, _, _, ok := openTargetRequest(t, pg, task.ID, startKey)
|
||||
if !ok {
|
||||
t.Fatal("no request for the rendered URL")
|
||||
}
|
||||
decide(t, g, id, "allowed")
|
||||
|
||||
// The wait bound is long: the hop must not use it.
|
||||
began := time.Now()
|
||||
out, isErr := callTool(t, tool, gatedCtx(task, time.Minute), `{}`, nil)
|
||||
if !isErr || !strings.Contains(out, "TARGET_APPROVAL_PENDING") || !strings.Contains(out, start.URL+"/start redirects to "+finalKey) {
|
||||
t.Fatalf("redirect to an unpinned target: error=%v out=%q", isErr, out)
|
||||
}
|
||||
if elapsed := time.Since(began); elapsed > 10*time.Second {
|
||||
t.Fatalf("the hop waited %v", elapsed)
|
||||
}
|
||||
if startHits.Load() != 1 || finalHits.Load() != 0 {
|
||||
t.Fatalf("hits origin=%d target=%d, want the target untouched", startHits.Load(), finalHits.Load())
|
||||
}
|
||||
hopID, toolName, toolInput, ok := openTargetRequest(t, pg, task.ID, finalKey)
|
||||
if !ok || toolName != "probe_redirect" || !strings.Contains(toolInput, final.URL+"/final") || !strings.Contains(toolInput, start.URL+"/start") {
|
||||
t.Fatalf("request for the hop: ok=%v tool=%q input=%s", ok, toolName, toolInput)
|
||||
}
|
||||
var requests int
|
||||
if err := pg.QueryRow(`SELECT count(*) FROM intercept_pending WHERE task_id=$1 AND target_key IS NOT NULL`, task.ID).Scan(&requests); err != nil || requests != 2 {
|
||||
t.Fatalf("%d requests, %v; want the origin's and the hop's", requests, err)
|
||||
}
|
||||
|
||||
decide(t, g, hopID, "allowed")
|
||||
if out, isErr := callTool(t, tool, gatedCtx(task, 0), `{}`, nil); isErr || !strings.Contains(out, "probe-reached") || finalHits.Load() != 1 {
|
||||
t.Fatalf("after the approval: error=%v out=%q target hits=%d", isErr, out, finalHits.Load())
|
||||
}
|
||||
}
|
||||
|
||||
// The custom-tool test endpoint has no approval scope (D14): its redirects are
|
||||
// followed as before, and nothing is written.
|
||||
func TestCustomToolTestEndpointRedirectUngated(t *testing.T) {
|
||||
g := newGateServer(t)
|
||||
on := true
|
||||
g.newTask(t, db.TaskCreateOptions{TargetGate: &on})
|
||||
final, finalHits, _, _ := countingServer(t)
|
||||
start, _, _ := redirectingServer(t, final.URL+"/final")
|
||||
count := func() int {
|
||||
var n int
|
||||
if err := g.m.pg.QueryRow(`SELECT count(*) FROM intercept_pending WHERE decision_source='target' OR target_key IS NOT NULL`).Scan(&n); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
return n
|
||||
}
|
||||
before := count()
|
||||
code, out := g.do(t, "POST", "/api/tools/custom/test", fmt.Sprintf(`{"kind":"http","exec":{"url":%q}}`, start.URL+"/start"))
|
||||
if code != 200 || out["is_error"] != false || !strings.Contains(fmt.Sprint(out["output"]), "probe-reached") || finalHits.Load() != 1 {
|
||||
t.Fatalf("test endpoint: %d %v target hits=%d", code, out, finalHits.Load())
|
||||
}
|
||||
if after := count(); after != before {
|
||||
t.Fatalf("the test endpoint wrote %d target rows", after-before)
|
||||
}
|
||||
}
|
||||
|
||||
// A gated worker's WebFetch end to end: the origin is approved at the hook, the
|
||||
// redirect stops at the hop with TARGET_APPROVAL_PENDING and leaves one request
|
||||
// open; once it is approved through the API, the same call follows.
|
||||
func TestRedirectRequestSurvivesAndRetryPasses(t *testing.T) {
|
||||
g := newGateServer(t)
|
||||
on := true
|
||||
task := g.newTask(t, db.TaskCreateOptions{TargetGate: &on})
|
||||
pg := g.m.pg
|
||||
final, finalHits, fhost, fport := countingServer(t)
|
||||
finalKey := net.JoinHostPort(fhost, fport)
|
||||
start, startHits, startKey := redirectingServer(t, final.URL+"/final")
|
||||
p := &toolScript{calls: fetches(start.URL+"/start", start.URL+"/start"), results: make(chan string, 16),
|
||||
hold: map[int64]chan struct{}{2: make(chan struct{})}}
|
||||
done := runScriptedWorker(t, g, task, p)
|
||||
|
||||
var id int64
|
||||
waitUntil(t, "the request for the origin", func() bool {
|
||||
var ok bool
|
||||
id, _, _, ok = openTargetRequest(t, pg, task.ID, startKey)
|
||||
return ok
|
||||
})
|
||||
decide(t, g, id, "allowed")
|
||||
if r := p.next(t); !strings.Contains(r, "TARGET_APPROVAL_PENDING") || !strings.Contains(r, "redirects to "+finalKey) {
|
||||
t.Fatalf("first call: %q", r)
|
||||
}
|
||||
if startHits.Load() != 1 || finalHits.Load() != 0 {
|
||||
t.Fatalf("hits origin=%d target=%d, want the target untouched", startHits.Load(), finalHits.Load())
|
||||
}
|
||||
hopID, toolName, _, ok := openTargetRequest(t, pg, task.ID, finalKey)
|
||||
if !ok || toolName != "WebFetch" {
|
||||
t.Fatalf("request for the hop: ok=%v tool=%q", ok, toolName)
|
||||
}
|
||||
detail, err := pg.GetInterceptDetail(hopID)
|
||||
if err != nil || detail == nil || detail.Audit == nil || len(detail.Audit.Targets) != 1 || detail.Audit.Targets[0].RedirectFrom != startKey {
|
||||
t.Fatalf("hop request detail = %+v, %v", detail, err)
|
||||
}
|
||||
|
||||
decide(t, g, hopID, "allowed")
|
||||
close(p.hold[2])
|
||||
if r := p.next(t); !strings.Contains(r, "probe-reached") || finalHits.Load() != 1 {
|
||||
t.Fatalf("the same call after the approval: %q target hits=%d", r, finalHits.Load())
|
||||
}
|
||||
select {
|
||||
case <-done:
|
||||
case <-time.After(60 * time.Second):
|
||||
t.Fatal("the worker run did not end")
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user